Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 11:18:52 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Akhil R <akhilrajeev@nvidia.com>, christian.koenig@amd.com,
        digetx@gmail.com, ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        sumit.semwal@linaro.org, wsa@kernel.org,
        Zubair Waheed <zwaheed@nvidia.com>
Subject: Re: [PATCH] i2c: tegra: Set ACPI node as primary fwnode
Message-ID: <Y3dcDCgC42QcMX3k@orome>
References: <20221117100415.20457-1-akhilrajeev@nvidia.com>
 <29db0e24-4f7c-e3dc-91ce-2decf6a253a5@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="FutM8JfzTk8389nd"
Content-Disposition: inline
In-Reply-To: <29db0e24-4f7c-e3dc-91ce-2decf6a253a5@nvidia.com>
User-Agent: Mutt/2.2.8 (2022-11-05)
Precedence: bulk


--FutM8JfzTk8389nd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 18, 2022 at 09:38:52AM +0000, Jon Hunter wrote:
>=20
> On 17/11/2022 10:04, Akhil R wrote:
> > Set ACPI node as the primary fwnode of I2C adapter to allow
> > enumeration of child devices from the ACPI table
> >=20
> > Signed-off-by: Zubair Waheed <zwaheed@nvidia.com>
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > ---
> >   drivers/i2c/busses/i2c-tegra.c | 1 +
> >   1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-te=
gra.c
> > index 954022c04cc4..69c9ae161bbe 100644
> > --- a/drivers/i2c/busses/i2c-tegra.c
> > +++ b/drivers/i2c/busses/i2c-tegra.c
> > @@ -1826,6 +1826,7 @@ static int tegra_i2c_probe(struct platform_device=
 *pdev)
> >   	i2c_dev->adapter.class =3D I2C_CLASS_DEPRECATED;
> >   	i2c_dev->adapter.algo =3D &tegra_i2c_algo;
> >   	i2c_dev->adapter.nr =3D pdev->id;
> > +	ACPI_COMPANION_SET(&i2c_dev->adapter.dev, ACPI_COMPANION(&pdev->dev));
> >   	if (i2c_dev->hw->supports_bus_clear)
> >   		i2c_dev->adapter.bus_recovery_info =3D &tegra_i2c_recovery_info;
>=20
>=20
> Do we always want to set as the primary fwnode even when booting with
> device-tree? I some other drivers do, but I also see some others ...
>=20
>  if (has_acpi_companion(dev))
>         ACPI_COMPANION_SET(&i2c_dev->adapter.dev,
>                            ACPI_COMPANION(&pdev->dev));
>=20
> It would be nice to know why it is OK to always do this even for device-t=
ree
> because it is not clear to me.

ACPI_COMPANION() returns NULL if there is no ACPI companion, which will
cause ACPI_COMPANION_SET() to set the primary fwnode to NULL. If I read
the code for set_primary_fwnode() correctly, that's essentially a no-op
for DT devices.

I guess that the extra check might save a few cycles by not having to
run through all the various conditionals, but it seems a rather minor
saving.

Either way is fine with me, though.

Thierry

--FutM8JfzTk8389nd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmN3XAkACgkQ3SOs138+
s6GiZhAAiPts5oA6T5oXg4xKYVPjsnsJNEEkfsSwNQm0MwuFNyiZvSoHonmwB/2r
nktVg9pG2Rf2QfQZG10BWx4kBqrvyOrT6JO4JgKEFwtOub23F/P2OeykJmbCY11g
tP7MxQnMA/4qEsjFos2EEG5EJrgoCtM31O9QXXnfvuWH6q6Yv9uoUvXTp/huQvl2
21knzvr0tT9nGvb+sdfSvAD5GyNu6I7C38wCsHTAQly1MCkjqF3afkkB+shDc2dN
6t+z/nE+v8/0Wqb2g17CmlFb59SV1ESHoxpHfn6B9Z/YbeDKQCxgPHxfwkmXNORs
sqoM6vbtpIaKTvgx6cMtxQ+dteQRZHBdace1IIEHFnztwSjKpr+S0VqV0oSJQThQ
noDq8NC/8wfeMA/2H66nSH4xP7jFA3vkbyFbVWFLN8PR5KnMhL9/nV34aSAauZAv
Ybjhs+ll0pQyx+JKL+nuMuEL5fWWEw2g77LR4hsL57lnSiP1nNwyPm6yI00Bivhy
XMDFrThYUI6NH/g/GNaTrRdxKMR0E/a2DatYASm+42VUFmuEMX47uSr5RJXPe9OB
JRA/JmTEtLcdUHxqCV9swuY/O28+AxwoiwFlYC1oLqX3WVpCxeDtHVk5kf7+0zeT
trotAZOs0nNRufTycA8p3DpGHhhZ3c0ftKlkYDSs8UhupE5GMno=
=rjSE
-----END PGP SIGNATURE-----

--FutM8JfzTk8389nd--