Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
Subject: RE: [PATCH v3 2/2] iio: frequency: adf4377: add support for ADF4377
Thread-Topic: [PATCH v3 2/2] iio: frequency: adf4377: add support for ADF4377
Thread-Index: AQHY+OJ39zHNcri0L0KekFRAlfFmI65EfPaQ
Date:   Fri, 18 Nov 2022 10:33:03 +0000
Message-ID: <SJ0PR03MB6778D5319F22812F1D2FBE7899099@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <20221115110041.71495-1-antoniu.miclaus@analog.com>
 <20221115110041.71495-2-antoniu.miclaus@analog.com>
In-Reply-To: <20221115110041.71495-2-antoniu.miclaus@analog.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KBLkTegMI4oKqXWtMwRqsI/x8HvXDopRCEitsdOVzqdREH3dHAdYwlF12F?=
 =?iso-8859-1?Q?lh2/ebGB0ee8qKaf1P88TjP3ND8n0mlPyjxxs3wqugk17FxK+o6iLRrFhN?=
 =?iso-8859-1?Q?cC8NUdrXvu0b7jGoxx6zIrxbbGggExZec9wQPSj0SFK4awMBmlQmqEe6JY?=
 =?iso-8859-1?Q?eVZryJODPwedmwBuDWPCOgpxzG8nG2pBJaZi/0gA2NBMF5oZZAaStfg7pV?=
 =?iso-8859-1?Q?6xwxXvNt74s8Bury7QJioN/Bshhs96zRCm0zNhLu3moYHB2Sjg92gHZ8ly?=
 =?iso-8859-1?Q?ellREmylzDnqfK8ymvkE0io1gRtCtcLZiGAanTAV8MsSZBG9AyGpx0VSYI?=
 =?iso-8859-1?Q?MFJCvYlUPBSo5ej6gXjcBKiQ15oSh99dl6qoJIutDQypswAoLhjMggHnop?=
 =?iso-8859-1?Q?koPVmmK8p7HQ2rNOeMjGx4Gw8jgCsScSiiRIoBUS2D8Jku2mSdQZPqg1dc?=
 =?iso-8859-1?Q?dFlXm8z3QJ4h6CdCUEor0Es0rjnEVyH1zBFSEA6SPSjd8bGIWE282t2vX8?=
 =?iso-8859-1?Q?qJcI72n9N0bzQ0y0NMrNPLt2H24fvhJeYxZKyX3cN2PEuTtsqbaeWhY+kD?=
 =?iso-8859-1?Q?3eKO8gBgC+ZO07oRi4hktT93kTz3ktx8AQ+WbLHOIjMtIKU2mZUEDLs1nG?=
 =?iso-8859-1?Q?UnikxSQyBw+7lH2DX7QhSBXXfJMjd3B/5FoQhQG5G42lAXGWIEHj+HKNfW?=
 =?iso-8859-1?Q?4cEZ6UUrbhJslPGrWWLYsvMz7/UhVncoGvJRFHrzsYxyWLVBtKRNxE81aG?=
 =?iso-8859-1?Q?rJrSa9O0aCK0SDfPb9UGij4kkIHSqOK+vGxqotqCAqjkGR4bKZr/90/JCu?=
 =?iso-8859-1?Q?2fem6s6WNE0SbK1nUJ6hlpK5+GH1BBjsj91ccAbA+VcFmjr/sgp9FyWjIt?=
 =?iso-8859-1?Q?1rfBXB3PZLyAVEv6Q8miUfeJZ62w1I7QBDEcQAjthZ+9KFJ4j49MqNEx+Z?=
 =?iso-8859-1?Q?PNsqESXzU1XvkbXQfkH3nD17jsZu4RfkAwyJ34pIi/KW5ksB0DdCHj+T4W?=
 =?iso-8859-1?Q?FdNEXvqrG2DrYVsoBRurow1Isn4csbGVvUsXS1S/VPNcX6Zr9MlU+PRTX7?=
 =?iso-8859-1?Q?04l80VQbQDgBuWaPexHjYs3UKKXRXh3gFihunToUfUW7scOp0HGJsf6m6S?=
 =?iso-8859-1?Q?6w/mdUINPM83Fmf8N0Gq9QL+4O6DfcgdX3KYPIhQABCWYupVG6wf+CWUkc?=
 =?iso-8859-1?Q?DWz+PLtWUUGkNh/vC7bDWre+H4a+VIF70KauexT5GTMHO4w0DJgCDL0ej5?=
 =?iso-8859-1?Q?WIPvb9cOlrln8R4GZDI9YBDF9eDj4RcUtJNY997+pPgtARPj/ZwTpbTSO1?=
 =?iso-8859-1?Q?iPr8GDqz3SJgil06pUjrzA0IRKJWb6bOb7mmVYfOo/uWopSfSrYpXZ3tJq?=
 =?iso-8859-1?Q?u9VSdePH04zNwjZrVL1Z2HyPhvdWBgGXQGIrDRTcds/H9sPdgd+H6w4dm7?=
 =?iso-8859-1?Q?2tLR8OE+/quoYJfz9NObkADNpwygadJXgBwXRh2ZTX4d5oKVdvlV9Xkn8y?=
 =?iso-8859-1?Q?Nu3Hl9Gou23DdKMupsm8wQwjthjfKHCTAeoqItxPFCLt1aiZa6boQZV8bL?=
 =?iso-8859-1?Q?B2KNNLtPjsXs3+c0JORhr9MSYpfUd5eZgvD056q1AwD8lRmi0OV45fU4DQ?=
 =?iso-8859-1?Q?xVN421Oi9aOgwM3XpjnH/R0hrT74nGUw/K?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a7618b1-0bc4-48d9-8d87-08dac95045cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 10:33:03.1255
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XfFUGGwN91FxBEnLDVNjXz1YBDdwv20Ui9uRLpN2usckbZSz2Pm+2SZUbGzSl+AMP9xHvNmJV/jqUgDKukALuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6667
X-Proofpoint-ORIG-GUID: Ls7ezVkf0tdDyo4GbQ4YIiVt6I9gSXC_
X-Proofpoint-GUID: Ls7ezVkf0tdDyo4GbQ4YIiVt6I9gSXC_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_06,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211180062
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Sent: Tuesday, November 15, 2022 12:01 PM
> To: jic23@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linux-iio@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Subject: [PATCH v3 2/2] iio: frequency: adf4377: add support for ADF4377
>=20
> [External]
>=20
> The ADF4377 is a high performance, ultralow jitter, dual output integer-N
> phased locked loop (PLL) with integrated voltage controlled oscillator
> (VCO) ideally suited for data converter and mixed signal front end (MxFE)
> clock applications.
>=20
> Datasheet: https://www.analog.com/media/en/technical-
> documentation/data-sheets/adf4377.pdf
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v3:
>  - add register name/value for the macro definitions
>  - use `__aligned(IIO_DMA_MINALIGN)`
>  - add extra spacing for `reg_sequence` structure
>  - check frequency value before reg writes in `adf4377_set_freq` function
>  - remove ternary operators inside `adf4377_write` and `adf4377_read`
>  - remove comma after null terminator
>  drivers/iio/frequency/Kconfig   |  10 +
>  drivers/iio/frequency/Makefile  |   1 +
>  drivers/iio/frequency/adf4377.c | 994
> ++++++++++++++++++++++++++++++++
>  3 files changed, 1005 insertions(+)
>  create mode 100644 drivers/iio/frequency/adf4377.c
>=20
> diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfi=
g
> index f3702f36436c..9e85dfa58508 100644
> --- a/drivers/iio/frequency/Kconfig
> +++ b/drivers/iio/frequency/Kconfig
> @@ -50,6 +50,16 @@ config ADF4371
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called adf4371.
>=20
> +config ADF4377
> +	tristate "Analog Devices ADF4377 Microwave Wideband Synthesizer"
> +	depends on SPI && COMMON_CLK
> +	help
> +	  Say yes here to build support for Analog Devices ADF4377
> Microwave
> +	  Wideband Synthesizer.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called adf4377.
> +
>  config ADMV1013
>  	tristate "Analog Devices ADMV1013 Microwave Upconverter"
>  	depends on SPI && COMMON_CLK
> diff --git a/drivers/iio/frequency/Makefile b/drivers/iio/frequency/Makef=
ile
> index 48add732f1d3..b616c29b4a08 100644
> --- a/drivers/iio/frequency/Makefile
> +++ b/drivers/iio/frequency/Makefile
> @@ -7,6 +7,7 @@
>  obj-$(CONFIG_AD9523) +=3D ad9523.o
>  obj-$(CONFIG_ADF4350) +=3D adf4350.o
>  obj-$(CONFIG_ADF4371) +=3D adf4371.o
> +obj-$(CONFIG_ADF4377) +=3D adf4377.o
>  obj-$(CONFIG_ADMV1013) +=3D admv1013.o
>  obj-$(CONFIG_ADMV1014) +=3D admv1014.o
>  obj-$(CONFIG_ADMV4420) +=3D admv4420.o
> diff --git a/drivers/iio/frequency/adf4377.c
> b/drivers/iio/frequency/adf4377.c
> new file mode 100644
> index 000000000000..26abecbd51e0
> --- /dev/null
> +++ b/drivers/iio/frequency/adf4377.c
> @@ -0,0 +1,994 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * ADF4377 driver
> + *
> + * Copyright 2022 Analog Devices Inc.
> + */
> +
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/clk.h>
> +#include <linux/clkdev.h>
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/notifier.h>
> +#include <linux/property.h>
> +#include <linux/spi/spi.h>
> +#include <linux/iio/iio.h>
> +#include <linux/regmap.h>
> +#include <linux/units.h>
> +
> +#include <asm/unaligned.h>
> +

...

> +
> +/* Specifications */
> +#define ADF4377_SPI_READ_CMD			BIT(7)
> +#define ADF4377_MAX_VCO_FREQ			(12800ULL *
> HZ_PER_MHZ)
> +#define ADF4377_MIN_VCO_FREQ			(6400ULL *
> HZ_PER_MHZ)
> +#define ADF4377_MAX_REFIN_FREQ			(1000 *
> HZ_PER_MHZ)
> +#define ADF4377_MIN_REFIN_FREQ			(10 * HZ_PER_MHZ)
> +#define ADF4377_MAX_FREQ_PFD			(500 * HZ_PER_MHZ)
> +#define ADF4377_MIN_FREQ_PFD			(3 * HZ_PER_MHZ)
> +#define ADF4377_MAX_CLKPN_FREQ
> 	ADF4377_MAX_VCO_FREQ

Well, I think we are more than fine in using s64 :). Anyways, as the write
side is still a bit weird, let's stay with extended attr.=20

...

> +static int adf4377_get_freq(struct adf4377_state *st, u64 *freq)
> +{
> +	unsigned int ref_div_factor, n_int;
> +	u64 clkin_freq;
> +	int ret;
> +
> +	mutex_lock(&st->lock);
> +	ret =3D regmap_read(st->regmap, 0x12, &ref_div_factor);
> +	if (ret)
> +		goto exit;
> +
> +	ret =3D regmap_bulk_read(st->regmap, 0x10, st->buf, sizeof(st->buf));
> +	if (ret)
> +		goto exit;
> +
> +	clkin_freq =3D clk_get_rate(st->clkin);
> +	ref_div_factor =3D FIELD_GET(ADF4377_0012_R_DIV_MSK,
> ref_div_factor);
> +	n_int =3D FIELD_GET(ADF4377_0010_N_INT_LSB_MSK |
> ADF4377_0011_N_INT_MSB_MSK,
> +			  get_unaligned_le16(&st->buf));
> +
> +	*freq =3D div_u64(clkin_freq, ref_div_factor) * n_int;
> +exit:
> +	mutex_unlock(&st->lock);
> +
> +	return ret;
> +}
> +
> +static int adf4377_set_freq(struct adf4377_state *st, u64 freq)
> +{
> +	unsigned int read_val;
> +	u64 f_vco;
> +	int ret;

Could initialize ret to -EINVAL and save one line of code :)...

Anyways...

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>