Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>
Subject: RE: [PATCH v3 00/10] Add '__adis_enable_irq()'
Thread-Topic: [PATCH v3 00/10] Add '__adis_enable_irq()'
Thread-Index: AQHY+ygqNNA15+PT+EaU6gI4mRLz265EdnzA
Date:   Fri, 18 Nov 2022 10:19:05 +0000
Message-ID: <SJ0PR03MB6778AF1B1558319DB50D13E899099@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <20221118083118.9641-1-ramona.bolboaca@analog.com>
In-Reply-To: <20221118083118.9641-1-ramona.bolboaca@analog.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?cjprE9D0WI6yKpnHiCnYRmcHhTahAxHLwW26Vw/PDewna8myF5IYiucuzb?=
 =?iso-8859-1?Q?tmulEamIVSnJ4p9kUkcVRgHSuUBenRLD1uZ/ZKec/3KIBZJPhktQkkB8Ei?=
 =?iso-8859-1?Q?efiLPNjX0EMYCEYMeP2JbWrWZi/i9FbV/8Wlhptm8bnoSWvfiUweUzgsJk?=
 =?iso-8859-1?Q?mOszdDnMPVZbDezRLzokjeMx0UnZzYSRbWbkh4idY0Fn6+72F2jJ3OOde2?=
 =?iso-8859-1?Q?i0+LWcQdTR2Kfs0R2TSuh7yCxhGGkYNCh1Oznaq/91IIoBTDK8OSGnYsZM?=
 =?iso-8859-1?Q?QKgSlmYGrm5/QgcCpB496wMxxyK2K9NFQcC/vXcJhvjLvvmfmR7KvYE5Dd?=
 =?iso-8859-1?Q?lZT8v3hejrBhFuSYKxr58tlIg21ozTqB3NvCS1SOSiAMyJwxP77QZ5dEST?=
 =?iso-8859-1?Q?GZ5SH2J4fu/E2bYu6LwcMI6ngEtuuqUB7Ngbv6O4TnatfjiuyPdNnkulGN?=
 =?iso-8859-1?Q?oZjqxERVuiFNUPqsCcYiKoBnFMsg4bZduhsI+ReSFnUZjqmCIOoMXjPwu9?=
 =?iso-8859-1?Q?sBul21x6a2G5rNIEHsHC4ifsDmwUzbixPcAxUpHvd3YAY/QU4eM/Squ0+h?=
 =?iso-8859-1?Q?v6BUAAiRifYD75fy58cd7BxrRsQ3r25Pdk2cVrJGXSsUcM06tragFQLana?=
 =?iso-8859-1?Q?FXPHoUxfEJCQa/JuWyRLQIFLaDiSUVNoTHqr7shQrAq2bbtdRK9KuDeT6R?=
 =?iso-8859-1?Q?Guubp4gL9GBr2+ZCloJsw0wgN1pYpBntLiAV+Xr3pWMxQo5LqiGJsBGrZ/?=
 =?iso-8859-1?Q?MV7+w5ZKB8qBH8zl/fAP89pv+86JCgfR/f4sG4yXGR2sfHat+4ehQsCI6i?=
 =?iso-8859-1?Q?R9snvFt0u1vNKIQ3PqY5yRVglf6GhlnOFnYjmFC818I8bOBiFXBY6N37SC?=
 =?iso-8859-1?Q?1BhD5wjIN5Jg+N9uaI+rLtE8dCKcFYSnUOSBCX91DH3LjD3BSFts4sxJc6?=
 =?iso-8859-1?Q?QyTtjo9Cvfa79D07IpEH8V3Boe+GdBw4V6sxoltbN0wch2KFioZNfRhB8p?=
 =?iso-8859-1?Q?yLqWIJwTzbJcf2vct0xhrEaJrQwUIJqWj8PfADvu+YD4XKcQXge0+F6blP?=
 =?iso-8859-1?Q?5a3wj2UX54n5RG2OatCciEKxPcdJ65inyi8YFHaHdVqoo+yHCCFGH+N4iv?=
 =?iso-8859-1?Q?2gAI6nQm4+HlnAd0v8cKQLCYbSvSgecsCKCSWrfiWjLjuVLpM+AvbULWqs?=
 =?iso-8859-1?Q?enDudTjNTyW4vzJhdWLJAEzzHzZrIOCJEtQTK9CEHj13IeJIeWG5hRU6hH?=
 =?iso-8859-1?Q?PJZxMs5s07x4XaItNh+3XN0GHiWKWbGkltgBmAUriwthxwVEVM9m5SJXYR?=
 =?iso-8859-1?Q?CcD1Ve9NH27XuJ0uR5AUH9Bg/7APFSl7D4bCQJE2fuVSK5ZZVGvCeHiZKe?=
 =?iso-8859-1?Q?N+z+xf9d9AwQFN0WQavIz3D5wZns9FirDAUbrBC6KpKRNAx7swtZ/B50JJ?=
 =?iso-8859-1?Q?GXBRpG2VcYLvc8X6qeKZWZ0EZxcDwwPZsDM7EOuKfE5qjXWY1jSEKIGraF?=
 =?iso-8859-1?Q?fdbmQj+/YzeUGXuVyccPUmklEQ8Re74JrtBsCgtmXp+UJ5DGwCb59u6BBW?=
 =?iso-8859-1?Q?MfRxCNFDKXU8W2by+VlmuXvSkF9MrSmKCaIazmp/oz9hPHGhPT9E1pqiSE?=
 =?iso-8859-1?Q?Xs5D89u5YjyBMRR85K9Nh4LJ70ofja8z/I?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66eb0052-936f-4b76-43f7-08dac94e5258
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 10:19:05.2331
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PUS2sYTBU1eqNwkajvcb/BbrdJ2is1/2+AzDjmUWfl3YIJVmyoEh3bHjZH7wNvn9kaBscSEEea290ME4tBPfEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5757
X-Proofpoint-ORIG-GUID: 2mk-FyAGz1jV7pWSyJtaVrOIQMQoLVBr
X-Proofpoint-GUID: 2mk-FyAGz1jV7pWSyJtaVrOIQMQoLVBr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_06,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=892
 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211180061
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ramona Bolboaca <ramona.bolboaca@analog.com>
> Sent: Friday, November 18, 2022 9:31 AM
> To: jic23@kernel.org; Sa, Nuno <Nuno.Sa@analog.com>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@analog.com>
> Subject: [PATCH v3 00/10] Add '__adis_enable_irq()'
>=20
> Added implementation for '__adis_enable_irq()' and called it instead of
> 'adis_enable_irq()' inside '__adis_initial_startup()'.
> Replaced 'adis_initial_startup()' calls in probe, with its unlocked
> variant.
> changes in v3:
>  new patches: 1,2
>  changed commit message for patches 2-9
>=20
> Ramona Bolboaca (10):
>   iio: adis: add '__adis_enable_irq()' implementation
>   iio: adis: Call '__adis_enable_irq()' in '__adis_initial_startup()'
>   iio: accel: adis16201: Call '__adis_initial_startup()' in probe
>   iio: accel: adis16209: Call '__adis_initial_startup()' in probe
>   iio: gyro: adis16136: Call '__adis_initial_startup()' in probe
>   iio: gyro: adis16260: Call '__adis_initial_startup()' in probe
>   iio: imu: adis16400: Call '__adis_initial_startup()' in probe
>   staging: iio: accel: adis16203: Call '__adis_initial_startup()'
>   staging: iio: accel: adis16240: Call '__adis_initial_startup()'
>   iio: imu: adis: Remove adis_initial_startup function
>=20
>  drivers/iio/accel/adis16201.c         |  2 +-
>  drivers/iio/accel/adis16209.c         |  2 +-
>  drivers/iio/gyro/adis16136.c          |  2 +-
>  drivers/iio/gyro/adis16260.c          |  2 +-
>  drivers/iio/imu/adis.c                | 28 ++++++++++-----------------
>  drivers/iio/imu/adis16400.c           |  2 +-
>  drivers/staging/iio/accel/adis16203.c |  2 +-
>  drivers/staging/iio/accel/adis16240.c |  2 +-
>  include/linux/iio/imu/adis.h          | 16 +++++++--------
>  9 files changed, 24 insertions(+), 34 deletions(-)
>=20

I would squash patch 1 & 2 as we need to backport them both
and adding ''__adis_enable_irq()' is a direct consequence of fixing the
deadlock. Other than that:

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>