Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp393708rwb; Fri, 18 Nov 2022 03:05:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf4GtgqV/4ixG/qzspz1j7T/mdeL0dGQgOUCj4E+63f1tjO4USuXhva15b/0ydJXLP9JTyA4 X-Received: by 2002:a17:902:e94c:b0:186:a636:b135 with SMTP id b12-20020a170902e94c00b00186a636b135mr6988140pll.93.1668769547451; Fri, 18 Nov 2022 03:05:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668769547; cv=none; d=google.com; s=arc-20160816; b=Nlxdk5X4dyolRmUvcECO1Oh7EWWUhnLSG0FK/0TZvxLBG4eJnlltH1OvRtDOlZ4LYr AHauaIdjACgbMcM2/3N5Y4jZYLRTQF4hDu+1rQ928i4AW24F711uEFk3NJ03ubh5ZZIG i24ilqAUjX1/hiU9aZVo+OQ8jVZd7n2ZiKpFFee6LleLS6zfohg9BfORr7vZ4KOljf5P uIQagnZi30e1+D3qD9+4Oor5ih7MjbFoeW4D7OmrTZYAdbX67EVwniQKK+NM4uI/VZDw qqixm3Lsx32nKxFD7IKpS0tm2R+b5G/agC2dTx1l9nFkWkOUAX4U+zu8M93uAb5z/T1F nqXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GeQulJikjqDnx9dXPYJbJ1jmVen4q6hWxrPrTahU4S0=; b=DsrT5x05KQiDopxmfTLMnIo7SLt9y8zUaMjVk3ZsITpZdBj9kECyeW/93cLdWaw3Ss orUb0CzNMLEK9SoOJFP8RI5UU7vIfUuips6dpaxZL6pwyC9oMhiq6UmuFeL4bS3VyqDr LYCWppOn4w5GQglLJhol0uBUGyS7tt2pD0w2sVcWtquXM1hjaXj48B18UyHr0vJGNeIK j7RhTuQGtdyGwSBvLo5IINcnGzvcEOdgdni48fQKGprEto5vb0cXsT9ta+tS6Kl/x3/Z 5ASBjgas60Bj5TADTmaqNV3dNyQcA4tRCbO57o038t5xvUmngWoFui8nIOAJkkZPIGHi TEAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JQpp1WFB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i23-20020a17090acf9700b002004c680032si3295392pju.160.2022.11.18.03.05.27; Fri, 18 Nov 2022 03:05:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JQpp1WFB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241438AbiKRKn7 (ORCPT + 91 others); Fri, 18 Nov 2022 05:43:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241417AbiKRKny (ORCPT ); Fri, 18 Nov 2022 05:43:54 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05BF825CD; Fri, 18 Nov 2022 02:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668768234; x=1700304234; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DHRMI6V+sgPcLuSWMPQRiljM1njAubVpXALqbHLr3x4=; b=JQpp1WFBleX2ZtDbqmDb32Dplq+9buhKwIt2QS6xQxWBEXQXSnRTg2P8 4r1QUvYsIntT8dIJJctLtNMuS/OHCUMgSReVj7hfJ40jd0ouvcxxJKT1g Z7kMdsb0igwXhb855TYdjYZcq/rhKvWrWSm1PPEwStiMrmdwfPr7pdt7T C9JxTbalmaT3m6LgH2kTMcpKrswmei7LR6Qv1rPi7QODL22trMdvqLfBq YCqDJ9T6sCtU58dd+MP9q3iCgRVveKKZeAviOe3WvVPwBjLrYsKTvPmz4 JyyK5cUkOshVsFOTFNEV+FKyR3pSB6EsKwXYHvoVgj3TovEohMNR1XT5Q w==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="300645903" X-IronPort-AV: E=Sophos;i="5.96,174,1665471600"; d="scan'208";a="300645903" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 02:43:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="814874069" X-IronPort-AV: E=Sophos;i="5.96,174,1665471600"; d="scan'208";a="814874069" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2022 02:43:48 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ovyqX-00E03u-2C; Fri, 18 Nov 2022 12:43:45 +0200 Date: Fri, 18 Nov 2022 12:43:45 +0200 From: Andy Shevchenko To: Tharunkumar.Pasumarthi@microchip.com Cc: Kumaravel.Thiagarajan@microchip.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, macro@orcam.me.uk, jay.dolan@accesio.com, cang1@live.co.uk, u.kleine-koenig@pengutronix.de, wander@redhat.com, etremblay@distech-controls.com, jk@ozlabs.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, phil.edworthy@renesas.com, lukas@wunner.de, UNGLinuxDriver@microchip.com, colin.i.king@gmail.com Subject: Re: [PATCH v5 tty-next 2/4] 8250: microchip: pci1xxxx: Add serial8250_pci_setup_port definition in 8250_pcilib.c Message-ID: References: <20221117050126.2966714-1-kumaravel.thiagarajan@microchip.com> <20221117050126.2966714-3-kumaravel.thiagarajan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 09:40:37AM +0000, Tharunkumar.Pasumarthi@microchip.com wrote: > > Sent: Thursday, November 17, 2022 12:26 PM > > To: Kumaravel Thiagarajan - I21417 > > > > Subject: Re: [PATCH v5 tty-next 2/4] 8250: microchip: pci1xxxx: Add > > serial8250_pci_setup_port definition in 8250_pcilib.c > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Thu, Nov 17, 2022 at 10:31:24AM +0530, Kumaravel Thiagarajan wrote: > > > Move implementation of setup_port API to serial8250_pci_setup_port > > > > Don't you have a dependency issue here? > > Okay, I will explain the need for the changes done in commit description. What I meant is that the 8250_pci patch should be _prerequisite_ to your stuff and not otherwise. -- With Best Regards, Andy Shevchenko