Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f887630-cdfe-dda9-c907-278a96b0650c@intel.com>
Date:   Fri, 18 Nov 2022 13:32:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH 2/3] mmc: block: Limit queue size for consecutive requeues
Content-Language: en-US
To:     =?UTF-8?Q?Christian_L=c3=b6hle?= <CLoehle@hyperstone.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        "vincent.whitchurch@axis.com" <vincent.whitchurch@axis.com>
References: <3dd3f33e5cc44657bcc2ebedc6d9dd2f@hyperstone.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <3dd3f33e5cc44657bcc2ebedc6d9dd2f@hyperstone.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26/10/22 10:30, Christian Löhle wrote:
> In case mmcblk relies on requeueing to fulfill block layer requests due to
> hardware or driver restricting the max_blk_count to 1 also limit the
> hardware queue size to 1 to get consecutive accesses instead of a
> round-robin on all queued reads.
> 
> See SDHCI_QUIRK_NO_MULTIBLOCK for such a restriction.
> 
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>  drivers/mmc/core/queue.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index fefaa901b50f..3a20f3933502 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -425,6 +425,8 @@ struct gendisk *mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card)
>  	if (host->cqe_enabled && !host->hsq_enabled)
>  		mq->tag_set.queue_depth =
>  			min_t(int, card->ext_csd.cmdq_depth, host->cqe_qdepth);
> +	else if (host->max_blk_count == 1)

I suggest adding a big comment here about why this is needed.
Perhaps like the information in your cover letter email.

> +		mq->tag_set.queue_depth = 1;
>  	else
>  		mq->tag_set.queue_depth = MMC_QUEUE_DEPTH;
>  	mq->tag_set.numa_node = NUMA_NO_NODE;