Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 08:47:45 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     akpm@linux-foundation.org, akinobu.mita@gmail.com,
        dvyukov@google.com, willy@infradead.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] mm: fix unexpected changes to
 {failslab|fail_page_alloc}.attr
Message-ID: <Y3d+8dgq05akRC14@nvidia.com>
References: <20221118100011.2634-1-zhengqi.arch@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221118100011.2634-1-zhengqi.arch@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ypT8aGU2uk/GeY0kj2cmSxfkQpVwUf0BznsbbPs9QW4fPt3ubdM/Q2XJaPwb?=
 =?us-ascii?Q?8t2ZFbIjXIjqJGXWPM4mTkBnUhJdnHm2GXaxfJvh6FWN+ytuzou27+pfyeSj?=
 =?us-ascii?Q?DYyM+d3wjwZP1tWezoha514zjtBTuSfowaLVP19Z/OBUpo8AkQmyxQOeUmuP?=
 =?us-ascii?Q?h1BRF4cY8g3WLhyUIFu7c5CJ/UiTae6aG48kOPolX2q51nozRTR5UurlLxVZ?=
 =?us-ascii?Q?GxUqE31QGjfWiHcLZFax6/5A/TNM+pRVZ51+mnh2OWFZt1836dkGB0pcu5A1?=
 =?us-ascii?Q?b6PES2StdfrXSf02neoYuZAFTVJDQuEmpbm5/NwPYOS8wEBZUrOqsatf4OXx?=
 =?us-ascii?Q?qTuReKFZPv4wsnI0I7jS/m6tJw7JraRETvKpNv0c49Vjezc+OH/jzvisuSri?=
 =?us-ascii?Q?BQs1UnxP4UEMKAKzFYm+sHatUxYGk5jrbXaJdmu8NzKrqB+a01vVsWfDBFom?=
 =?us-ascii?Q?x9F2bCREP1Zwx8uzu+DKhnWqv+wIO0nlZtWUNM/uUCRyo+ngyQomz7oEpVTv?=
 =?us-ascii?Q?a856GUp6Nut2HYgDNfwv8Piy+sgIflnfFqfuJhUTuARxyOYgldsmJVed/DWK?=
 =?us-ascii?Q?91hBbt7DmIJn6HUXaH8rH+vvBd80uyiPUCM8itUAeCvIyJUzSOI2vRx4c7UI?=
 =?us-ascii?Q?OeobFSmQmzpn8X34U+h2ac7By+H9KVcgp0LHnXtjeW4Jl3GSmgGrQ4JoQwJ2?=
 =?us-ascii?Q?m0+2VbvckzQW8l2uPMBHmXUM+2i+yCjn0T2pD1CXOw6LQYUiZQnoMa6G5It4?=
 =?us-ascii?Q?2lelPGT8zqWY0T6gzJgRGSw0SbsRxS5X34NVxeK2Hx79ijNPQMfnV4f5G1qP?=
 =?us-ascii?Q?WPzni9fm7+0jdtG6LfjU4RTRHd8nEwaUTkLBBaFXYJj44qweLYTGZr7h87lt?=
 =?us-ascii?Q?x2s9GKN9nGfRjPWx658LA6lbnbgm9L6bzbzyVrdoGRQrYUpIJHm0uG5x9IXp?=
 =?us-ascii?Q?2iDy7A5vkGHEzYh1BtY/Bn6uasCEQFdxN1IAE1UqcJ8/E7J2UPmhbEDJN9L4?=
 =?us-ascii?Q?hxnUEoqU8TjvEGGijJUxuZoHrQ0SQkQIgG2fsiAC9DsIY14/3jVdc+BEPN1R?=
 =?us-ascii?Q?kANIUjJm+VvB+OMf18T6nlt8+w4LId5LwVUmGOlGe99Oe0769XMQDVtAMJec?=
 =?us-ascii?Q?s5Z4i8D5Cz9gmIiEMIYaW+n1OQKRypZFf00KDQHkBgNi8oVO0LkKI6EwDpeg?=
 =?us-ascii?Q?1K8iYd9n1pUfsD/DvOWtJUHwqf9D/6ucCp5a3YpHqTmZqs3UVP2xgIVgIzTf?=
 =?us-ascii?Q?JuSInuOxoOpwK9PH5x6PG5sPz/rptNvFtrqpBST/6Zy7rhlH+morPKkeMK8/?=
 =?us-ascii?Q?JkqeFUGPDFZSB23VVjzlK5ye9r0oF7xBLCF4QTHY+J5TURDr7j+JzWddTspG?=
 =?us-ascii?Q?LQSr2Dnou3ivMcbu/UOFenMxDvb6G7qqh+a/j/vP7/PlPgrmGwx2adJl2zEv?=
 =?us-ascii?Q?1cNs3UqAKzfs2VLsVNWB9T8dqI2t5rVbU35W+dGmXWSon/Uo1C60yEbjoR0F?=
 =?us-ascii?Q?Sh3lHRg31Lb81Sg5FJucuqxnBIxZzo4MGQfC57LhTSU6ASLfvujt4ZBTz8AS?=
 =?us-ascii?Q?8aVOPDhnrD/q0hbmpZk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c37910d-49e9-4bec-d272-08dac963179e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:47:46.3607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M7cKFK1gpoQDuNieUpFM0meofcmev9g2mz6ojeTXs3nfz/2c04bQ1zGbAwF2a4pj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6435
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2022 at 06:00:11PM +0800, Qi Zheng wrote:
> When we specify __GFP_NOWARN, we only expect that no warnings
> will be issued for current caller. But in the __should_failslab()
> and __should_fail_alloc_page(), the local GFP flags alter the
> global {failslab|fail_page_alloc}.attr, which is persistent and
> shared by all tasks. This is not what we expected, let's fix it.
> 
> Cc: stable@vger.kernel.org
> Fixes: 3f913fc5f974 ("mm: fix missing handler for __GFP_NOWARN")
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
>  v1: https://lore.kernel.org/lkml/20221107033109.59709-1-zhengqi.arch@bytedance.com/
>  v2: https://lore.kernel.org/lkml/20221108035232.87180-1-zhengqi.arch@bytedance.com/

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason