Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp560336rwb; Fri, 18 Nov 2022 05:27:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf572e5fDvC+CSN1aZG8MKB7BKB/CfdV/UJSxg5TfDAWU7lxQobkhMl5ax0nIxeTyNYeDMUq X-Received: by 2002:a17:902:ef93:b0:185:3d08:968b with SMTP id iz19-20020a170902ef9300b001853d08968bmr7657752plb.49.1668778023224; Fri, 18 Nov 2022 05:27:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668778023; cv=none; d=google.com; s=arc-20160816; b=Qy6qw545HpK8/xpcX1mVUwZXypisuZcPsDHZtdPas6TA/JLFfns3zf7piANXMtEOjq 3kHsXBQyyqT1XG7VlDsGVKYQCztbIahOk+wAFKoxx+lZoLceDtIit24jsnLg5rKLqLo5 Xu8OwN0mqwEgtDev8zXosrGS8NBl/PcHbYru3d4hQESajeS5+IknCJ1cHkVqjte/3zMh E5aDunVnvsLBggUaYUcPMHfgv+5L0ookqnAqMp7lxeSCk42posJB6w5J8EV6zW+Zx8AX Tt7p4ZKuaxZaMDSkNkqJsiN4/b7ZSzK826Jh1devH7Jaz2c8CPdqNk+EsLQkfh3ZsjDe 6Njg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=jwTtajpbIgGcblOg9C67UrHpiJhPHV2badNEQXK9VaE=; b=IK1pc5X11ZmA+c4OmG+rRd7rcV2yt1BzTIB0slLEG3u/NTPMliWwCCpZHYkEHb9gN1 xmsbWwbBaCJ20zPuDGbl2ZoOtv1eXYXmQd+FDgTorvYThZxY+f5cJoE4oaCh/zLeASx3 w+e6bDJxvvF3GNxDKEP0rPrDvCOi1Wz4u4lKp/CT1zm5fEKwAjTNGaz1lww5C17X5dlj Im3427kqeXOXsRC2TuuawENUw3uGlkwXuPdMGZpcZ8CPJ9cQfdF45AyEeed1ct50S5/N veJ+pEMcl5Ud6swgSt4uGYvMC4GxBhdMJ1nERMr5E6d29ToXYBQesrr0caQgsQJ2cR+B PLyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a632115000000b0044fb27b64c7si3909012pgh.326.2022.11.18.05.26.50; Fri, 18 Nov 2022 05:27:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235382AbiKRMw4 (ORCPT + 92 others); Fri, 18 Nov 2022 07:52:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiKRMwy (ORCPT ); Fri, 18 Nov 2022 07:52:54 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6F37A1AF09; Fri, 18 Nov 2022 04:52:51 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C0373807E; Fri, 18 Nov 2022 12:42:44 +0000 (UTC) Date: Fri, 18 Nov 2022 14:52:49 +0200 From: Tony Lindgren To: Maxim Korotkov Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] pinctrl: single: fix potential NULL dereference Message-ID: References: <20221118104332.943-1-korotkov.maxim.s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118104332.943-1-korotkov.maxim.s@gmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Maxim Korotkov [221118 10:33]: > Added checking of pointer "function" in pcs_set_mux(). > pinmux_generic_get_function() can return NULL and the pointer > "function" was dereferenced without checking against NULL. Reviewed-by: Tony Lindgren