Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp561148rwb; Fri, 18 Nov 2022 05:27:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5TUFuY/RJQQeJfkbzHcuGS9WlsAU61bDcvH99zczTWvgZA2qX+dL0oNhaUbpt5fEqyUmOW X-Received: by 2002:a63:1c10:0:b0:476:a396:4908 with SMTP id c16-20020a631c10000000b00476a3964908mr6602414pgc.444.1668778062375; Fri, 18 Nov 2022 05:27:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668778062; cv=none; d=google.com; s=arc-20160816; b=OtQbDwo+IOjv+/e3rVBG/CZ09OasqLPq45LweX/DegKRz5j6Fp7LXvdzPY1REX5+9t j8ZIy9W/wbPNk1V2ktcwJRfO2EApVEIBzGKY3/WziD1RROFGcOU4UCNsV0NYE772IEvO /tPd/AKGZcXWTCwdEeGS1nk6PUpjvwKF8hSqINKW7kMv7FOvUcvnTrAIsuemIP9zpVj6 mRk2wx3aAHXCVAnHvOMlHBxMvA0ypArbiYEkXnbLR6RHDlu+nOD20jVBIOvgBiolEADH o4sE0ZD5PsCPTsHiCMyB16jSpcjLqtMUqR4dl/FXo0K8B+4gi6uhQNQ8PV9uwN1Yrufc zIhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=PirMro+3wre34v1gdha0CkDSRtZ6gfXZ/7hOFG3jsZE=; b=T56Y+t9YC28/j4ewm7xdYcQGcFbwqze2Fi5St58rXdJOb6twNAkpOFZzeL6eOApVZh NRT62YAvgV8HKG6nXoOg2l0RIxj5ous+bdZLjB82H/kbIKn9UOMn2Wg1n5fG+iN/7kho xwZiiJCjxP4Zr0nzhccY0YtKjIGozp6Q7yqZDNUk2FqF4X4MB39u0pu/4eB6OQTe401s 31SS29UBZHEh0SGQZRMp3j6WoGh2cLEdGnLfDbHSKioxGMgkYFSUfzEyzpyDT89XMKgl vb8c/n5wF6H/JpGf/Iwv8qoFm1EUzZDO1XzJ2p7dk86SUuwBLa/8xuPgFVykJqqLbgZj SOcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TYAMn7Ql; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nv5-20020a17090b1b4500b0020a613f8c79si8217715pjb.129.2022.11.18.05.27.30; Fri, 18 Nov 2022 05:27:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TYAMn7Ql; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235333AbiKRNKX (ORCPT + 91 others); Fri, 18 Nov 2022 08:10:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239931AbiKRNKS (ORCPT ); Fri, 18 Nov 2022 08:10:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B58B8C087; Fri, 18 Nov 2022 05:10:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E512EB823B5; Fri, 18 Nov 2022 13:10:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6ABCCC433D7; Fri, 18 Nov 2022 13:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668777015; bh=hD5pqTfRz9MxhjvgbTdX3fi22qgWfYtD8znIx6/jpI4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=TYAMn7QlPNkPkyF1yXp8I/XcUni7K+DS+jRxMr32fvHn27qhmv7E7cXRL7++v4VKr 0szw8a/htflGHCAlKfF4w9Cjyey1YZI6zFilb8ayFp+PWo9AviftdsTwAeJ6sXRebd pAspcyq7ek2Jb4fGvbckoFoBXsi4bNkxEoGFRh6s0mY7WYBqCQmxHVJ+ubLXtejvtT psG4zmE0BHpJjUba6dOLuv33bMRudzm54b38PyvFAtrJfUNcDU7rVGWs1sPnMNvAHE plALNQJ61XuFJH7Sl+gPfPmFKheMJGKkRWBb2MoeMGJNzRv6NTs4BLhKqWBLDF3+4z ZoI4kDSBMWbqA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 337E4E29F44; Fri, 18 Nov 2022 13:10:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: pch_gbe: fix potential memleak in pch_gbe_tx_queue() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166877701520.19854.17834649129969422685.git-patchwork-notify@kernel.org> Date: Fri, 18 Nov 2022 13:10:15 +0000 References: <20221117065527.71103-1-wanghai38@huawei.com> In-Reply-To: <20221117065527.71103-1-wanghai38@huawei.com> To: Wang Hai Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andriy.shevchenko@linux.intel.com, liuhangbin@gmail.co, masa-korg@dsn.okisemi.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 17 Nov 2022 14:55:27 +0800 you wrote: > In pch_gbe_xmit_frame(), NETDEV_TX_OK will be returned whether > pch_gbe_tx_queue() sends data successfully or not, so pch_gbe_tx_queue() > needs to free skb before returning. But pch_gbe_tx_queue() returns without > freeing skb in case of dma_map_single() fails. Add dev_kfree_skb_any() > to fix it. > > Fixes: 77555ee72282 ("net: Add Gigabit Ethernet driver of Topcliff PCH") > Signed-off-by: Wang Hai > > [...] Here is the summary with links: - [net] net: pch_gbe: fix potential memleak in pch_gbe_tx_queue() https://git.kernel.org/netdev/net/c/2360f9b8c4e8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html