Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp689354rwb; Fri, 18 Nov 2022 07:05:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf7H1N7uqr9k4MoVAM5XRSMNyml2nWE4eTUvKD29YLlOvhoessSovZ/SnMi+lsDX/++X1ax/ X-Received: by 2002:a05:6512:390b:b0:49a:d52c:8e62 with SMTP id a11-20020a056512390b00b0049ad52c8e62mr2444575lfu.331.1668783915402; Fri, 18 Nov 2022 07:05:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668783915; cv=none; d=google.com; s=arc-20160816; b=vPv+ibpehRFVKEhBgWiiZU1cpWuFOhEOEjuVGrE7/vEI1G+t5P5/xzeCD2Dqa64DFK ZDxZq7w9mVlZjFGVJbbOyvuNJnBnwAmTSfVmf4uETRW8u/HmbuHi9udgsTSXmuywD456 ubXsTZtda5FNsOK+lFf93vT1CuONJwZAVd+diEFFuwU2tdyUCeTfJZu3/EmL/67NsmfY ntma0ZHhqpnP9lBWHyQpP6hjSsPnnNO7kyq9ViTqSmv8zQf5LFhyhu0HiF8s8B7VZ1NB RD51ReavDW3q/gMI3BtXflI6IkTNEi+1pcPjXnZNkI7+b/x8bf4Y3BMiz06HyTQUz6t/ ijbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BI9SdldArhmncLFH70O4J/hpnFzVxZH3XrA9hQ5k3Aw=; b=d9eBCKTyumhWxKsodZjz0IORp6aMoGmvoqLY/Mj80nPo/VAvR0jePn147Akhr3CC32 lNMENH0dQuZ/ZnsOuiYp8g/GXkOVbVgVjdgoT4sPib7zm13gvBGdWg6OWtBM+OXN9V2S wfYJ5CJKKgpOhn/4A3RuCVOo4DfpAC4V/smrcIuulZEFc4/0d/AxubStsiFnwQlQXqxQ 75AB83u9k289SLkyVT1QnkQDAaBRTm5+29xjM2f6GIfVRZ+aIHj4SfdOiiLaKpB1tnjJ 4/KOgz8YKIp0pdN6lcczR+Ws5meAJfyAzNO/RV/md5WlIwLpGdsnK5WNHEF6gHALCfK9 r68Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ysDnTCow; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t20-20020a056402525400b004661bfac392si3718390edd.311.2022.11.18.07.04.51; Fri, 18 Nov 2022 07:05:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ysDnTCow; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235307AbiKRNvq (ORCPT + 91 others); Fri, 18 Nov 2022 08:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiKRNvn (ORCPT ); Fri, 18 Nov 2022 08:51:43 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FC431BE96; Fri, 18 Nov 2022 05:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BI9SdldArhmncLFH70O4J/hpnFzVxZH3XrA9hQ5k3Aw=; b=ysDnTCowTe79OLtvxyo5sxMCMs pEjYhuFonAHzBB441fpc8CyzHnnZhAaWxMpdcKlSJGDgzOHozSJXTpIWOZpkm7ER6JdDnLm5merqK NmetfTIxoJOe9J0zprtyO8JCp+khsHUuwSRYgGlz3L1HYMjCIYtaMndxzqRib5CDPhz4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ow1mH-002nbf-7w; Fri, 18 Nov 2022 14:51:33 +0100 Date: Fri, 18 Nov 2022 14:51:33 +0100 From: Andrew Lunn To: netdev@kapio-technology.com Cc: Vladimir Oltean , Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support Message-ID: References: <20221115111034.z5bggxqhdf7kbw64@skbuf> <0cd30d4517d548f35042a535fd994831@kapio-technology.com> <20221115122237.jfa5aqv6hauqid6l@skbuf> <20221115145650.gs7crhkidbq5ko6v@skbuf> <20221115161846.2st2kjxylfvlncib@skbuf> <20221116102406.gg6h7gvkx55f2ojj@skbuf> <54b489e65712e50e5ee67b746c0fec74@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54b489e65712e50e5ee67b746c0fec74@kapio-technology.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Would it not be appropriate to have a define that specifies the > value instead of the same value two places as it is now? Yes. > And in so case, what would be an appropriate name? MV88E6XXX_WAIT_TIMEOUT_MS ? Andrew