Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp758272rwb; Fri, 18 Nov 2022 07:55:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ykWLj4jCT06rzsNux8lB5D7kVDN+oKnhJPSlH301o80Z1XZCHY+mOGXvNpFoEqzUFNEA9 X-Received: by 2002:a17:902:6b8b:b0:188:a40b:47c9 with SMTP id p11-20020a1709026b8b00b00188a40b47c9mr127387plk.75.1668786908050; Fri, 18 Nov 2022 07:55:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668786908; cv=none; d=google.com; s=arc-20160816; b=tn5GVY7A26BxlbBeu/iv58qNHJdkQOPVABrxB3oyFWT90DAIJHifkheWbbOmRYDpel KqYwkA1ekiIC9ktnaaLwRTcKgqVnvs8k/e5edc/7pePt0F7kVICHV8fxW41mJMb9M0vO 487APcUk/Z0vpUkuEyawj378eJCQCYzylPrnhpqcjaS8biRJZlUM9ndHv7j+CPcb99gN izdHq99k0wdKwv5xmIgdGx7ANldyTSef77MQIAD1DPt0BTXMdslPgLMufSMDozTNcOXb Z4xdaYWkRamtDFilxrfkJgIEE/y/0K/s2Zkkhxk8T+ezzw2lkb9RvyhXPtLqA1Oln3fw ++xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=Yr8fQqxOuxgfsh7aSNnZ2DOYglECy5/Eal4thUcsDrg=; b=dAgFP/Uf3x6/oTm2LSqPHdLyNi2gDCKrmmkliYotzPdteWp0iLwEHVpONud0Px1wd6 xeDUXW7u1SkB27YO/NLe8hCKSB28pK+yTwHulZdQqT9fB1Yvq66ytnBV3alU8AnYKovl +5N7cY95cGplWVCqWvW4Z5hsaYzjh7yR5KfbX0cWKY2HD/wwl3AOY82qkXnKkc3vs1mJ uvY11HotlTIsRTsfWZSTrKNy8kgzuerO14EsQ17URs6mY6NgB+qSf7iX/pl3sSDaXlBi UqPmS+3AWSuT2XfwFPaL9+bcwMKuYwvgNPoeQdTCKM2aBvled9tYnQ08WR7aWmvv+EM2 owJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cjr.nz header.s=dkim header.b=SMUz7ChD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cjr.nz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ik2-20020a170902ab0200b00186ab03eebfsi3770922plb.418.2022.11.18.07.54.57; Fri, 18 Nov 2022 07:55:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cjr.nz header.s=dkim header.b=SMUz7ChD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cjr.nz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241918AbiKROuE (ORCPT + 91 others); Fri, 18 Nov 2022 09:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241828AbiKROt7 (ORCPT ); Fri, 18 Nov 2022 09:49:59 -0500 Received: from mx.cjr.nz (mx.cjr.nz [51.158.111.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30ECB12607; Fri, 18 Nov 2022 06:49:59 -0800 (PST) Received: from authenticated-user (mx.cjr.nz [51.158.111.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pc) by mx.cjr.nz (Postfix) with ESMTPSA id BC4AE7FD25; Fri, 18 Nov 2022 14:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjr.nz; s=dkim; t=1668782997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yr8fQqxOuxgfsh7aSNnZ2DOYglECy5/Eal4thUcsDrg=; b=SMUz7ChDot1X5TtFeHknvJ01g7SHxh3GY2WPHCNbCbPifrwZqCZWO7jJv09cn16Gs4V9M0 2O7DUoDkVO+m+jyMRCiThIAgIPEa9dXhYT1ced9lQ8QH8VGI0Vyyb1a88awHuQQpt+S2YD M3XcR7B3JEJIDXXgCCYk5h22tM1bWgdT3cFxM25z3bN0rrmufMaB+fKKX2Pjbs+oW863dG XEQsBEubSCE9OtwQUhGV+CT5mtHo3qhmpJkwhuXZYnn9Y3xmrU9fOv1u5WySEZjpe42kT9 MicDg1HVWZrMrd2IeupQwOjG7ALu5A4WmhWjFxfYfpi7IWWwusj+rMMR6yPSZQ== From: Paulo Alcantara To: Anastasia Belova , Steve French Cc: Anastasia Belova , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] cifs: add check for returning value of SMB2_set_info_init In-Reply-To: <20221116141027.10947-1-abelova@astralinux.ru> References: <20221116141027.10947-1-abelova@astralinux.ru> Date: Fri, 18 Nov 2022 11:51:15 -0300 Message-ID: <87a64ojoyk.fsf@cjr.nz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anastasia Belova writes: > If the returning value of SMB2_set_info_init is an error-value, > exit the function. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 0967e5457954 ("cifs: use a compound for setting an xattr") > > Signed-off-by: Anastasia Belova > --- > fs/cifs/smb2ops.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Paulo Alcantara (SUSE)