Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 12:38:42 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH 1/5] RDMA/rxe: Remove rxe_phys_buf.size
Message-ID: <Y3e1EvHE4uk2LLLv@nvidia.com>
References: <1668141030-2-1-git-send-email-lizhijian@fujitsu.com>
 <1668141030-2-2-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1668141030-2-2-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U6L7LYrMz5opAX8kqxBCaUUYY+ivWriEVu1or36lqSCYPR42GLvDo1UHGDYV?=
 =?us-ascii?Q?x4Tg2JS7w6MFyKRPeTHBgWLTNJczCZtaZsOIIv+2mxNgTKlKaYAjIreiwWmS?=
 =?us-ascii?Q?jkX6vX4WXQIfKd280kLgrBe8BBJjEcgVe8s8aBZSn/KqUR4Rr3go42o/kJ8j?=
 =?us-ascii?Q?/YiYJ1Av+aFMMqgejg8PnincT2lC19AwyinJdSFbf9MbXlTqSmXmija4DEN/?=
 =?us-ascii?Q?yLhjWRioJddWCHRBRC0rlKQQdufZpN7JhDZ+mRF/6XGGYeRsruN2Jwf4AaHh?=
 =?us-ascii?Q?JlOelb1Gw8SfRCQZ+v3LX/y9+0s+AacxMAFzfY3u77lFuqn2NDuGIzM8KUCX?=
 =?us-ascii?Q?wKrIAZk7cYemRHmD5CB/1r+Jjg7Pd07egnqCJ7KE9FJqFfB4l8i8/Of3Po7E?=
 =?us-ascii?Q?1HGQDChoiHYb1AMr6RD5bZ6yto5v1AGYa9d92Rb4gYq+msGcVPe4A5vpRWTf?=
 =?us-ascii?Q?+oyXIdUZP3UdOK65lpXrER3xn4tnmrHW5HaxZn/gZFd+7HlPB4y21VW4QU4f?=
 =?us-ascii?Q?BBqAXLXNB4zdovvGw9WrVOYlsl/XPkiJKhd43WGKNzIh0zUd26JF4R0zY8ho?=
 =?us-ascii?Q?UBbNJ5+j75IkKZF8pjs1ZIq5xGm0Q76FZQlfzBBvAlVgNOKAaEBNMfS92LYz?=
 =?us-ascii?Q?mSVkxMtcEigMIQYOCyVA4wOMar0k/WgpdLZ30RbTHEFVhcX5QRatrKFPz47Y?=
 =?us-ascii?Q?H7RHCwHPQk0219t3XRBeShdpthIDG+VnE1u08/COXHJABybsEEcfZPTReBeg?=
 =?us-ascii?Q?YffnfVnnuz5eQ7QxtgPW43iD8KmWsG4Isu457CXIPH6mNybPw/2QhNGxe4+h?=
 =?us-ascii?Q?3s8786u08lQirsKelHkvkKpqfEHxS/u3Q53CXKSGinNowj9behzdfQG7FSGy?=
 =?us-ascii?Q?n7IiSp/KXR+Gr90j+VuZsML5oS3u9mdI/vDLJxJS8ygraetGtNVKEvvhMr/O?=
 =?us-ascii?Q?Hq6sqU2Rhyhmpse6mxWKQBe6xtUGZe2zynS70QNitchTMgNd1+UWYRpHSewd?=
 =?us-ascii?Q?tPHkWG2i6H4IwNHgAKcBcUJZlruOkHWJOJWpPMiOouA1rtXj2hLBlezaqvOS?=
 =?us-ascii?Q?Gm4tCve/PjW8lwakwZwoA4hXQOZWDQ7dRctn6Deo8ozWwBHtmLb5rVnd1raR?=
 =?us-ascii?Q?HLFNcyWNyt4zz9YZuNdMYcdT2cSLq6/zbTSeeMY6IM4cChxPCZQqYnCSrzk8?=
 =?us-ascii?Q?ynFrrxdd5Kwxft7lrrLp2Rb8kg1gbyWiJl4G78gpDxMIpbRPBaPoKI8CSXqA?=
 =?us-ascii?Q?MAeKNNbpMIw5yodZuoCDK9KoqgzVSukTsXNfT6Yf6Gr+ngj0E1e/PZHs1yMs?=
 =?us-ascii?Q?/mGtVOfryXe4hOW2UxBvXfDiVpxf6WEexh8jQynO7uc4JYay5xzCXJT0VHwA?=
 =?us-ascii?Q?SHfd2maCWHCnDolsmer+BT9Zht6Ff+j9gCHl/maJujqjuZmURytK5jDd9X/S?=
 =?us-ascii?Q?Kb5aJgGMPeFfFjvy6jGKCAR75cJTxTgTZbojX4qFp07ytXflDVEzYti6GIpI?=
 =?us-ascii?Q?ad3IVwfCTnzvoc58UlR+htXHiOoPYDZJNlMMjrlgLoWqiMjy3ITrECxtRhmW?=
 =?us-ascii?Q?Shr1REG2obG/UkpARHo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 004ae2dc-d913-442f-22ea-08dac9835af7
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 16:38:43.4921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iIwQFrS2ne3SJzgwNPOsahz/zFNnwXrpTiiysiULw6qd65weAbHnuDLeBvQcNFUT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5934
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 04:30:26AM +0000, Li Zhijian wrote:
> Every rxe_phys_buf used by either IB_MR_TYPE_MEM_REG or IB_MR_TYPE_USER
> has the same size, which should be same with ibmr->page_size. So we can
> use ibmr->page_size correspondingly.

ibmr->page_size is really only supposed to be used by MRs that are
going to be used with FMR. It is some protocol to pass information to
the IB_WR_REG_MR op

The whole way rxe stores the MRs really could stand to be modernized,
just replace the whole mr->map and everything under it with a simple
xarray of page pointers.

You are right though, the page_size of the logical page array should
be global to the mr, not stored in every entry. It isn't a sgl, it is
a dynamic array. Just don't abuse ibmr->page_size for it..

Jason