Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Luca Weiss <luca@z3ntu.xyz>
To:     Rob Herring <robh@kernel.org>, Jonathan Cameron <jic23@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        afd@ti.com, Lars-Peter Clausen <lars@metafoo.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles
Date:   Fri, 18 Nov 2022 18:10:17 +0100
Message-ID: <2259963.ElGaqSPkdT@g550jk>
In-Reply-To: <20221106121310.3ad643be@jic23-huawei>
References: <20221031182456.952648-1-luca@z3ntu.xyz> <20221102163136.GA4004075-robh@kernel.org> <20221106121310.3ad643be@jic23-huawei>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Jonathan,

On Sonntag, 6. November 2022 13:13:10 CET Jonathan Cameron wrote:
> On Wed, 2 Nov 2022 11:31:36 -0500
> 
> Rob Herring <robh@kernel.org> wrote:
> > On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:
> > > As in other bindings, let's use specific compatibles together with the
> > > fallback compatible. Adjust the bindings for it.
> > 
> > You should state users are already doing this.
> 
> I can fix that up whilst applying.  However it raises the question:
> Should I treat this as a fix, or a tidy up (that can wait for next merge
> window)?
> 
> I'm also fine with this going with the other patch in the series (that lore
> found for me as it didn't go to linux-iio) if that makes more sense.
> 

Sorry for the delay in answering.
The dts patch (2/2) has already been picked up through qcom tree, so I think 
you can apply this one to your tree.
It's definitely not urgent, so next merge window would be perfect.

Regards
Luca

> If that happens
> 
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Jonathan
> 
> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > > ---
> > > Changes in v2:
> > > * New patch
> > > 
> > >  .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > Acked-by: Rob Herring <robh@kernel.org>