Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 12:41:26 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH 2/5] RDMA/rxe: use iova_to_vaddr to transform
 iova for rxe_mr_copy
Message-ID: <Y3e1tsbskwijGZA7@nvidia.com>
References: <1668141030-2-1-git-send-email-lizhijian@fujitsu.com>
 <1668141030-2-3-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1668141030-2-3-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lNOTL8eN95ggwIOPdyjO4GCO1rlpQHqjp9dRUkbiOYTv9RWPQ2iNm2KFo7Su?=
 =?us-ascii?Q?YVBb0/pWj0gk/ZIhXJMUGhiklSXBzi8RmXZPCSmYPG/R8DnCz/uVzJIpRfYk?=
 =?us-ascii?Q?cXYJ85az32DBkK9hWWExsterU5famiLG+atG1ckSFz6kqGUIyuDKE64n4G9f?=
 =?us-ascii?Q?O9w1FnmXeBLK6HUYdUfEHcceScG7+F2Xq20VMkmuNspvMyjZH05QpG79+1m0?=
 =?us-ascii?Q?a+Cx2nmAiA60INnY9uZf+lqsyXvi203v+DLEmw3ntqyLDVDQJzqNwLZSXrur?=
 =?us-ascii?Q?/s2FoUQouVpJsM6GkPeqVrZ5OuWEFR5aDPpuAZ0IgY+VTVrevUtSE/t5CpI7?=
 =?us-ascii?Q?cIV94LAp9VQZwE9/sL31LYSqxgIG25qVLHz/Sf2iAggLw0hUqW67jX0oayEL?=
 =?us-ascii?Q?pUYfaCmD/79EJ9cz3M5UvEgCiOaZfNx1O0A+XxM/VJyfvxay7xtodbPj4OhF?=
 =?us-ascii?Q?mmBDkCBC/FDbVrMh86IVcNh4b/vKieCIpdIjDJXRFQu3ZxPXnUA+axWIyK+f?=
 =?us-ascii?Q?perl5hVpH0fYI4D+NOHt39JRi7G3AqhiGIE5Q8ITHjyY03Zzw5cwjhso114C?=
 =?us-ascii?Q?0dO+ricl75KxbRaSoVUntlfKE8RZRcoEYh/nAuaRO+gQixmJ/JPJ0NGJvPa5?=
 =?us-ascii?Q?DNzLTRklA3djuB2z+mAjGypqVWCBmlq4PX/CuiZys0v4ru82WASIxG/XYr+B?=
 =?us-ascii?Q?vFuO5GZ+XSdEOx/h/K/41yuJzx1yAXYQG6kj6/4t9j3aiKvoiCMXPjfZiiY3?=
 =?us-ascii?Q?fIt+D1sWfsS6kdOSLYs4rivxIvseZSiwXmyfbB7qVHXyAX4GfBvGpLVqAdAn?=
 =?us-ascii?Q?jXO0adCq3SD04lNbwV6rgCHTAiVMOzjG7h09xolY0xSvIDg3CFo9cH5df3W9?=
 =?us-ascii?Q?vU0QNyUPIdylrN5btxz/pUsXkL7aQCFyqIi7hddoTfqYLVBKU2sDvSg5W39/?=
 =?us-ascii?Q?2jZYTzsOSsvGwjg260MTA1lmNNqyjkFpQuXZBXaTUr8xdNXzev2XPb4ucesH?=
 =?us-ascii?Q?9C4yZuP5U3BnntNK0zV8mblYvUWyYMoxZEaN+6wYg0qNdRWHm1cAw8xVPzOd?=
 =?us-ascii?Q?BvSAUVtJXqoGfwBZ7LNAdw7AO81OMRe3S2NGafjKdYM+vJTRdVVI2yYhgejE?=
 =?us-ascii?Q?i4saRh2qJGL3UgL4puwAL6I5YtHhWvNUo6aS4fz0hdV0ycK/9906/dRuYSTU?=
 =?us-ascii?Q?eSk7hJdgVsrL3nyJI7aaXyfRIy04bYpYYRAhugkgh28hTF7XFIK4h3Im5oZR?=
 =?us-ascii?Q?CGRRZkHCdS2X19OOAic+kHoR+WDSiWHJI8+k3BYwtpLynTsu2mo0v940mNAM?=
 =?us-ascii?Q?qhglY35FZkVvjEtFlMBXP3lJvYzuHXhLz84Nm6QZY/fNqganvNajQX78gHMn?=
 =?us-ascii?Q?DMuMtMXlv7zHcJfpHSRQIfyIvNdcJgHm1x1zii1y7RlvESXBmQ6IamxrcBtd?=
 =?us-ascii?Q?BA8QtPtvr3FznMSv5DWJA2Ge/uIOCpxb20FM43DkM70U7n+07At4s+zECxar?=
 =?us-ascii?Q?aVZjekYbF7f+aXLnelRSrINRv1lceZw3lhXStZxzUJnvqpsewd4OHKeUIbWr?=
 =?us-ascii?Q?NWgi6MPDDvdgZL2Tb6M=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 433c558b-bc19-4407-61e6-08dac983bca7
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 16:41:27.1206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7CivUY758VCqRH9gpyZjLU/HrsQFmZs98HDcLbDI3EHWwslv4CV0TXdmYHOAFktt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5140
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 04:30:27AM +0000, Li Zhijian wrote:
> Make the code more friendly and readable by using iova_to_vaddr()

But the point of this is to be faster because it knows pages are in a
linear list

As with my previous suggestion, just convert this to an xarray and
then it is a trivial and fast xas_for_each_range() returning struct
pages.

Jason