Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kees Cook <keescook@chromium.org>
To:     nathan@kernel.org, alain.volmat@foss.st.com
Cc:     Kees Cook <keescook@chromium.org>, llvm@lists.linux.dev,
        trix@redhat.com, samitolvanen@google.com, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        ndesaulniers@google.com
Subject: Re: [PATCH] drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()
Date:   Fri, 18 Nov 2022 09:40:02 -0800
Message-Id: <166879319847.2080862.11821072640113889089.b4-ty@chromium.org>
In-Reply-To: <20221102155623.3042869-1-nathan@kernel.org>
References: <20221102155623.3042869-1-nathan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2 Nov 2022 08:56:23 -0700, Nathan Chancellor wrote:
> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help mitigate
> ROP attacks. If they are not identical, there is a failure at run time,
> which manifests as either a kernel panic or thread getting killed. A
> proposed warning in clang aims to catch these at compile time, which
> reveals:
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()
      https://git.kernel.org/kees/c/0ad811cc08a9

-- 
Kees Cook