Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 13:33:30 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH 4/5] RDMA/rxe: refactor iova_to_vaddr
Message-ID: <Y3fB6jhde7hpIm5/@nvidia.com>
References: <1668141030-2-1-git-send-email-lizhijian@fujitsu.com>
 <1668141030-2-5-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1668141030-2-5-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WlkXujKbSqqMOl/FceC/dzz/5U2U93hzp0rzCw7w2TP06pEMHbQrZFmlyqme?=
 =?us-ascii?Q?CjNY049zQJRdOs//o7Ofkbnf6gqgKYUSV6DcBZh2fQTRS4pGMvq2czvq5TLu?=
 =?us-ascii?Q?Wmmh3+t0tbiU5sWp1XoTrqTeAJUPJcbwF9M4sdvZ6BVWDB39e8rgSsAIey05?=
 =?us-ascii?Q?oKBFpGurcgPcp69SvX/VCXm9PUTyFA+nYxB/DhFTE17Z+5yxZGmlPU5yMjLv?=
 =?us-ascii?Q?ISnvzcvuA17DtWDpbPp+uxSfBCoExzm9NpCfoNoLUgoGnB35Qemue2iEUjTg?=
 =?us-ascii?Q?POGb1oAT40e4Byy59VW4eBWzaNPp2LTj8wI22cUa6b5av74Ah7+e+x007LMR?=
 =?us-ascii?Q?fvAVfHP9VHeXQ8j/hvYtMceLnW57tLEyGpKtrR1gVr7OwlOgtRWxW5/wA2dL?=
 =?us-ascii?Q?zssknMEYchTD4qRm/aed5d+MDAlecnbwxh/rZ3z0X9go7irEYlnrf4BACxnU?=
 =?us-ascii?Q?qR3vswKsqHChsCGYKcD8xqcl8E5nBQws89jLqjy9j9sfAcscgY58pdEm9+7R?=
 =?us-ascii?Q?X4qS7DsQsQP8u22uAfRClXhTCLtBVqR/9Gy97nbXL/zJDCvUccft7wQeS593?=
 =?us-ascii?Q?hPUhMHg8tSMo48SUI2SQyM8jhBuuJxet7gd50Enny1OPs13cCp+yn1s/MGAx?=
 =?us-ascii?Q?IWXf5osQ/BnAxlWT7qFPhlO1er3ycC1SryjhOIyL0URgNKXJNWn+qB3eGGy1?=
 =?us-ascii?Q?xf3kzPPiOCWiTmo16k9oaizotZg1ZTWvSmxpX4sJUup6J6AEc8bcUi6fdaV7?=
 =?us-ascii?Q?lhsBHWZVTkrjCHSwrje0LhuzQl8HA7FW9gNHWOkn1LOM5axb9g3miaUqs6Bu?=
 =?us-ascii?Q?ksg6egRENw5hh1eoPNkL1QbVp5LIj3ZBajqmGIEW3CTrOx0MsiOeBHs/MbXu?=
 =?us-ascii?Q?wbfRfDk4ASNN6ndLVVnHfQf6BnpcA1OEp4St4swjrqu8dIzZPkiWwNN1eZ/+?=
 =?us-ascii?Q?zjnrtPQVG0yrs89HoLtcBIUbLuzW91vWrTx8n5553OF9IQIcF0WLNOqtHgDH?=
 =?us-ascii?Q?Sn3lwR9mK0I5MvPtHyHGyRaELSrPVGAKF8tDI+Ke0gf2YLRtY/WZUjq9KAO3?=
 =?us-ascii?Q?FQJfXQ2AeHFRBibFBAdQ1RM0pnABKoTkH53qRYFJPH1A0hcuGrY7pa8+VxkE?=
 =?us-ascii?Q?2OQVUCAHPIO14OtndkfAarSeNhkJD/Ehkh0Bmdal6rtvK+a+YpiXgk/ZePsF?=
 =?us-ascii?Q?X+Z19F52FaY403iQaQOhsce5hDYlG6rx0NO1T1szj4b2EoKLuMMcgbnJjqUq?=
 =?us-ascii?Q?9WwQ6V58NKL0Yh4/wbpZl6iR/00bZ8cvUr1PROhisb4XKzaSRzVjAo39JWPd?=
 =?us-ascii?Q?OLPtHAXVyir0IuW0cThTZqnd5GivPHIVuFSdtxLuatZ8op9mmM4x5rTQFDaT?=
 =?us-ascii?Q?Wkvk59FzPc3B3tdMAXejncQ6wwx+MduaCrcxnYXkOpAPUr01vjIvqAsl8XEf?=
 =?us-ascii?Q?4v0M2FUsnBz+lkeMFk5y60sRqSnE+MvxyKvu6d8IY7/Jsct/MsCLxUVmZolJ?=
 =?us-ascii?Q?qLw0hkNoJkW9TmqpFZxhTCT3CihSzp2bjqxJTIhVqo28Eq8hu6noh35d3woH?=
 =?us-ascii?Q?TJOS9zbFx8JIHIJGZYU=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d56512b-e72e-41d0-7fa0-08dac98b02e6
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 17:33:31.4987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7zZ0m7oj1X45KLlfHJHRgUNfSlCnypb+UNM3ushOakY9fqMe9NH0Dan6XHzqf5Xr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5503
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2022 at 04:30:29AM +0000, Li Zhijian wrote:

> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
> index acab785ba7e2..6080a4b32f09 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.h
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
> @@ -280,7 +280,10 @@ enum rxe_mr_lookup_type {
>  #define RXE_BUF_PER_MAP		(PAGE_SIZE / sizeof(struct rxe_phys_buf))
>  
>  struct rxe_phys_buf {
> -	u64      addr;
> +	union {
> +		u64 addr; /* IB_MR_TYPE_MEM_REG */
> +		struct page *page; /* IB_MR_TYPE_USER */
> +	};

Everything rxe handles is a struct page, even the kernel
registrations.

Jason