Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1018520rwb; Fri, 18 Nov 2022 11:24:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf6aUIevaYS0u4HI+SlDjnue/eOIRs5zIWEe8anAXgZFlubx2zWPFPz4eQbzEpz8jWoIRwW4 X-Received: by 2002:a05:6a00:84d:b0:56d:5709:a03e with SMTP id q13-20020a056a00084d00b0056d5709a03emr9211716pfk.23.1668799492724; Fri, 18 Nov 2022 11:24:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668799492; cv=none; d=google.com; s=arc-20160816; b=khxOFcxZpHhov1bQpCDMj8tUlPt9SGpNkpNDTXf3iv+tTuXXheQwJQpHXM87CWXWvU 7aZiJQvTIdHH2OdzAoemdSACfdHr1LYB5Y9PP783ZCg6VvBAxkZOkuiFu5NFmdae6AWU 9q4KOOjZ0afy6HT3GG0ulSBXmv9dXWCO3PB11uzJb/jtAPSsFj4bbelkU4BQKVgmVYIY ohgMe8GmUCOgK0JZW7aF1fgJ5HdU2lI0hm6demqfCJ/BO/d5/YKTZy3h1eSmIZJCbFf/ rjgs2yHkt14MGfA/YrCHuS/oOAOjkB1m553FLPSEZ9iX2qQQOX6fn5E4k3XTG28LCqzy /Jcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bjJQgdhCImWkeCRBvWJ7qLNfjqyKIYHkYnv8P42ph7o=; b=03YKAuwB/3GNNS7WDYVHCbznLFZxfEOIJj8iN+EYis1V1nQGjRzqNeLnKPNdNh5azK 4Rg9vwn9YIxkGsA8wO5alRaTO99Ij8NDtS7Cn5ZvdFskUodc0ZZYUmAjqcNBxm/R2JbZ VhtJNdSmkXXHMAwUBd/eE7bdW4mSZMhwVWfowLSHILsYdyiqlxhT0ZgcOAYJHyUGB52l SWnJespwFcm649IWgIG8n+R+LAJWoYNDySh7GHj7Db01IHwtP+cFeFgJYFNMx0H/jcbS Q6oCA1/hMQ+tjNJiERP7fLyrZ7WVeIWJKuYr1hRRT7QOHAKOknoVWsaSqWhGrOJRrLLi xB/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=TBmmkn8h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d62-20020a633641000000b00476de006c16si4464231pga.723.2022.11.18.11.24.41; Fri, 18 Nov 2022 11:24:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=TBmmkn8h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242796AbiKRS2d (ORCPT + 90 others); Fri, 18 Nov 2022 13:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242753AbiKRS1i (ORCPT ); Fri, 18 Nov 2022 13:27:38 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763FCA7C1F; Fri, 18 Nov 2022 10:26:35 -0800 (PST) Received: from zn.tnic (p200300ea9733e767329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e767:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7DB381EC058B; Fri, 18 Nov 2022 19:26:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668795993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=bjJQgdhCImWkeCRBvWJ7qLNfjqyKIYHkYnv8P42ph7o=; b=TBmmkn8hcQKg3kKMcLjxUnCPDj5i7LlUotsd2o48hzlHlvbAx1mi7SI3JPf5RW+kA8OKDz 4KePM33CWFfoGDGkW/d4aEcmDyKyVsxNQjUhjxRLh2G00fnm6EPzseDy8IMiLj7v7Mu6KI AKsGsKWS+z9QJO9kNSru8AmD1gDEsF8= Date: Fri, 18 Nov 2022 19:26:29 +0100 From: Borislav Petkov To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , Michael Roth Subject: Re: [PATCH v2 00/16] x86: head_64.S spring cleaning Message-ID: References: <20220921145422.437618-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220921145422.437618-1-ardb@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2022 at 04:54:06PM +0200, Ard Biesheuvel wrote: > arch/x86/boot/compressed/Makefile | 8 +- > arch/x86/boot/compressed/efi_mixed.S | 337 ++++++++++++++++++++ > arch/x86/boot/compressed/efi_thunk_64.S | 195 ----------- > arch/x86/boot/compressed/head_32.S | 4 - > arch/x86/boot/compressed/head_64.S | 299 +---------------- > arch/x86/boot/compressed/mem_encrypt.S | 152 ++++++++- > drivers/firmware/efi/libstub/x86-stub.c | 2 +- > 7 files changed, 496 insertions(+), 501 deletions(-) > create mode 100644 arch/x86/boot/compressed/efi_mixed.S > delete mode 100644 arch/x86/boot/compressed/efi_thunk_64.S Ok, it all looks ok to me. You could send me a refreshed version ontop of latest tip/master, after having tested the EFI side and I'll test the memory encryption side. If there's no fallout, I think we could queue this. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette