Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1038810rwb; Fri, 18 Nov 2022 11:45:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4dFtH3zdHbPMl7MM6jM5OJj2NggamZedkUmdk+WwA0x0jD+6qct1mm2saqFlAbUZ2Z7YIW X-Received: by 2002:a65:60c9:0:b0:470:48c1:aae9 with SMTP id r9-20020a6560c9000000b0047048c1aae9mr8015646pgv.4.1668800751846; Fri, 18 Nov 2022 11:45:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668800751; cv=none; d=google.com; s=arc-20160816; b=z3/ksK1JuuqF77niFnG43zkusbC8OHgV6QgMh1unRF0jpRAUFhWoUZvEAg4+gv1rSA 12WEo0mJj7MzV1Z3z22s91zSyWXezr70GzGSsoWBonk5sLyObvtqWa84XWkdWcOSXWfd kVSZJVJ1CjjkQuqenE9Yx9q26be1YWlMAvKCKEANgzvyJxQY4IR+OjHJcXuL9f+wZZhY vvFEEFcP/ATNAbjz0Tye7GEg+ZuGz3OKXgmLtRFMtuy1FAkysVOIe1ncpN6Xx+yof6O9 crWuNWUWysgam/KhkJVxlV6WTPy2eNUI/a0jUhtGxZF3uV7FhzTwcV1mXB9GSmqPhy5T kvcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yM8YjKxPVpE+au25Xb48me+tZQoRh0bx9dycjFTtUXs=; b=yLQZeuyshSxZnFluxgNGAcx5/PsHvI5u9OrYg+KDhL8YVOmSdzE09HNtcsGyKrXls6 Cj91S1HiAeVcT3bR/6uC1ZW+r4dprdWgPZBXCuNlLb3uGbqg2bV91GsWW5j3dQnQbEeQ 27H+3x8MvOfSyJYsfWV2wHoIJm33ObU1Sa4ZFMqhJIbqqsFPB7WemapZARGorHZ6LHqG qyRtk+ooaYF37qpdqQIiNgpTyWkgdSkS0LFQACErvp/LnTtKaHwzblbGfGsaoYFo0aXo QoPXsMV9nVgR36M5xW2ObFFkVzasx6huQgZaos5FL35jtuAjHUBFGya3EAjaOgaQFaZO hoDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NylGndkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l193-20020a6391ca000000b004772bd99e54si2509318pge.32.2022.11.18.11.45.40; Fri, 18 Nov 2022 11:45:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NylGndkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241100AbiKRTk6 (ORCPT + 91 others); Fri, 18 Nov 2022 14:40:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235210AbiKRTk5 (ORCPT ); Fri, 18 Nov 2022 14:40:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95DCF23173 for ; Fri, 18 Nov 2022 11:40:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EC146275F for ; Fri, 18 Nov 2022 19:40:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0821EC433B5; Fri, 18 Nov 2022 19:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668800455; bh=ao7w8PGY6CvyH02T0fXtKub8Tk+v9jD93VP1ZNrkqgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NylGndkcK8YJtHRgU20W6RmSYGDXrl/E8KySgSyxkW/RF07lwN1DYTJQcZe/z/3uU Rbj5iYOpPBdFFDt642TOmR5i7BT7BUmc/r1LvfY1DqLDpeLQxjboP/L1+sYAOCzLvN pOXSsrOioltTxM1scu6Gpe/ZuMg32cK2O465EHZHTGAGdXtTE7MUt5oKxdaqx6mVn7 xoiBXoq1XQVr2NiWwVA7F5IPLtEiC4f51n/EQ/N8yZ7pmMedk0GJQ7+Qeai52foay1 PmeAlwL7rxjIeF1CU7VUuSY+70UPZl2qcLsgpSb9oHcZ0j7HHg3YdZffY62hwMsC/a l31FOkfKCIzhA== From: Will Deacon To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Mark Rutland , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/mm: Drop redundant BUG_ON(!pgtable_alloc) Date: Fri, 18 Nov 2022 19:40:38 +0000 Message-Id: <166878064180.1782449.376709845468504621.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221118053102.500216-1-anshuman.khandual@arm.com> References: <20221118053102.500216-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Nov 2022 11:01:02 +0530, Anshuman Khandual wrote: > __create_pgd_mapping_locked() expects a page allocator used while mapping a > virtual range. This page allocator function propagates down the call chain, > while building intermediate levels in the page table. Passed page allocator > is a necessary ingredient required to build the page table but its presence > can be asserted just once in the very beginning rather than in all the down > stream functions. This consolidates BUG_ON(!pgtable_alloc) checks just in a > single place i.e __create_pgd_mapping_locked(). > > [...] Applied to arm64 (for-next/trivial), thanks! [1/1] arm64/mm: Drop redundant BUG_ON(!pgtable_alloc) https://git.kernel.org/arm64/c/9ed2b4616d4e Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev