Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Oscar Salvador <osalvador@suse.de>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        Vlastimil Babka <vbabka@kernel.org>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Subject: [PATCH] hugetlb: Fix __prep_compound_gigantic_page page flag setting
Date:   Fri, 18 Nov 2022 11:52:49 -0800
Message-Id: <20221118195249.178319-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SfVZoPUlBbAqmvouTOhUvEzRpTAZzpCfAV6Kdz/k7Fi8GK222go2/ONscc9a?=
 =?us-ascii?Q?0QofgwObF2mLcBqqE85y3tdheZ1AynTIEoiV1o8E3lIgFZt2hRuJtB1M+old?=
 =?us-ascii?Q?F3nWYuJCTb5fNlOxXtlWaB6HZ9KvN4Xhz0fgTSbPR9qGEAguNbRbhNs7vwDc?=
 =?us-ascii?Q?hL1LuvjH8R9Y5NOqyyRYVfQjOTUicPgFbBBH5dSt+suWKTQCh/O9fLqFTmsa?=
 =?us-ascii?Q?YEtIuXGfS2tWMUifFXC9DtIoA7Y5C9A1p7FiG7f7DO1sRak646kiMqceyMWZ?=
 =?us-ascii?Q?cDO/DJPkXMLmaDJ2lRDY2CX+1Su4hL8Q9QyH++J/yJ0Lzncb2n9V+aQ7vu64?=
 =?us-ascii?Q?KcroG7cLFaly7+JFYxMNdK5dY6oh6itIdw3s+s5qU9FlqNya8LchRdO91FYC?=
 =?us-ascii?Q?nLlaFoNNgCf+KKiDKL32rg2OZ+A6mXXvp/godHimW9tk+fZSaqkLr9yWSQnw?=
 =?us-ascii?Q?lZMllc5Yv+lNXTFWxPkboj9WWJWJwLSjzXRVWohyWOF+915Gi9D/HER6hdPx?=
 =?us-ascii?Q?HX5/gO1NDq44cH2zp0neNukGtvek3kxLusOj/oQpMtrkGAx64wJ7/2V/S/Hk?=
 =?us-ascii?Q?YwSs29qtQyrw8TgFYWLkU4BNsto3o5qHSbHwao5+bJfsDun7YY2oJgK4wZWE?=
 =?us-ascii?Q?gGuYtYTBTBJYnLT8ldgglsLZgTw+RFcqHz92njeGQ4WWD1p9RiRCnpe2w/7q?=
 =?us-ascii?Q?z726yljZqskLxPQT4KeVejGQOwduHc9/Mk36Xv4qxaLGAFmY4Gn523SMV8lL?=
 =?us-ascii?Q?L3ekMBRbRuT39CcPp7YteFcCKvi2dfF1LsifvD9lNDFnD5dVh3J+lfEknNpe?=
 =?us-ascii?Q?p2iNW+sHOSlBOle+etdVAPPuqd50z1KgI7zD/xY1GqH9JwH26boT9QvnYD/x?=
 =?us-ascii?Q?IXF3IdY2Q66RQV7f+c5Uvu/2eHOklLopAeOFaeEk2yLx8+RbrKCzEAAjwe/e?=
 =?us-ascii?Q?CPaBl3QOISLPSE/kafnYNCoW7kUHE8BWf7pi4wDV5e5pbJV72PRbOlLyND3Y?=
 =?us-ascii?Q?ykSmWEUYsoRckT5pLBGp7EtxPRX1YGBwsuJDtBuFMNzHPBfF+OXlXEP7l8u4?=
 =?us-ascii?Q?xW9nEnZ/kg/LItbWq1/YNgjQ5zoWrCGZyh4mxsPtYuRR8dEzU4eS3LGu5Dj4?=
 =?us-ascii?Q?92lAUiVK6drw1wP91L5i8s6TtWT0Kv4X66maO0ugP8PU4VsWHst+RUoqwz+t?=
 =?us-ascii?Q?Wlj6D2lmeuVKWkLY2V9ukwsSKq/L8ppIfyBRW1QmxYoD90OICJ3SJwcppM0S?=
 =?us-ascii?Q?3SJHUe68+KA34car8Sp2+iPfmjHfyQW7ghVjHUwlruzk0UyewupATAtuv4uq?=
 =?us-ascii?Q?kalTM7cEINGy0zNVhyhjvkE3LQkbEnhYbVAtpRmeaAM18USGBSlsG2Ma7J9W?=
 =?us-ascii?Q?dCO+4Yb+LdU93WoUsqkmNOk3u5/SDxlA2H+di6HTaPfVEJmYrAMQGBiV+I23?=
 =?us-ascii?Q?VdNwHiPlk2i/hhHnDg6aDwj3tH+Gomwmg2HzD6haTubM/u1DTkkSKEiU3J6V?=
 =?us-ascii?Q?OvbfyG8SsWLLqOEMmNNUgZtKk+pHeY7I8UzOSiS5prTrSWAzv1a825we3Qux?=
 =?us-ascii?Q?uCveAG/TfSo3aKE5ANklP0I2e7YdprFc5RQUivFNCAcg64ke2dIA8XwsZSgi?=
 =?us-ascii?Q?ow=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?OtRA2sNvVCO92UWO5C1BUp6buNN1Rd4Oqg3DE9YBzrrXcb40f9Hlv4gTi52/?=
 =?us-ascii?Q?+mTlyI4uNSeNVYycR3wuNk1Z4n5y5q6UquBCrUqcMtPryeL++JeRkCd5m1pv?=
 =?us-ascii?Q?/6WPcRHUJpNmkGzCzmOaw3LvEHxUO/yvxkvtG16M8KK1L+1cfEJQ8mX9dh6G?=
 =?us-ascii?Q?gYaVUtJuzTWF7gU22FRh1wfiCblCW/IqzutgC3aze/mhzqR56KxNcCPAMJ2c?=
 =?us-ascii?Q?0XQrDyeXOJZblFEhItEtSx+sr5SMK1hzl9upnJm6UsXIbZDNchXy0oBGxFdQ?=
 =?us-ascii?Q?OUgMNgVPiAHaWxdD+3dFuqFkNuFEuhf/Kc+NSV6hb8aypuLiJ59Y5aSTAVeT?=
 =?us-ascii?Q?u1thqKz8qNYFqDDbJIEOK484sOyyy/d83cLLXMQp/KpL8U9KRfKI+HBqtWmK?=
 =?us-ascii?Q?gNg2RGCxHCPiYE7CsF9omjBY6aQ/ld2+pYc4+cB11T1yV41t5aLn6NPzQSdu?=
 =?us-ascii?Q?yP6xD2qvWVvLkwru3Jp//s78X4fxpo+NAOBbrRhipFnK3UIth24aqQjPlJUw?=
 =?us-ascii?Q?2NINHIOcUMhxfTktVjAFMXfMeg5YOSp1lIaPZsBY7xh6PMq4uiKP3KJoEso+?=
 =?us-ascii?Q?f7mlXwSYc+4c2671A3eRd2BO3FaJONb7SzntgdClUvLkcPPRWRuyYyupbcxk?=
 =?us-ascii?Q?M8DjqgQRe7EHnF6LrWA4q/LJ2Ze1cE/YaGnbqnxEWmZDyE1wcveA+Sq/K5dK?=
 =?us-ascii?Q?aKYAKQoNpr0AskPzshMVNNCgHxOMeqQKL5r85DdbAIrf5xIaIy+QneTZedCg?=
 =?us-ascii?Q?CR2r8rRJuCxkBtIi3RZANwgl5k5QMlSUvPE0nbLOpyMof7agyJfq0LsHHhf5?=
 =?us-ascii?Q?aZnv7OkTlEnhmd5NFskY51CnMsu+xfE0Lz6e1utSgpRE7XtwFAu4lewdoUly?=
 =?us-ascii?Q?ldA3nPNvWntZv2eb5788OYvpQme96qXcAqGi++4Fodm1JXWtn6nTZxQQU3pJ?=
 =?us-ascii?Q?ozFy3AI31GhH1TH0OpavYgYEa0x70KU990VVG4NMYMKzQIxhIrCd/E+ZOeX1?=
 =?us-ascii?Q?5FXItj0zO6W9/8QWvh3kp1Rk+xukDOTAl+YNAPnTkYptH8r0fheD81ntDYNe?=
 =?us-ascii?Q?/KILZU+fkRwGuPC17PHxMe/ScBo43Mj8gd7t4W5mQytz8iX0Bg4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc9d111f-4c0b-46b9-3868-08dac99e7caa
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 19:52:56.1298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gIQl78e+xMLWQ8YDTA0rEmpCEjeEVm27cQb6ky9OZTlC45OvEQLuAQUtfnVB8HrrtfmrJZI70InpmXQuHsAkLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4434
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-18_06,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211180118
X-Proofpoint-GUID: RGNoDk4MaqG9hRay7QuU2Rla3_M_H_7T
X-Proofpoint-ORIG-GUID: RGNoDk4MaqG9hRay7QuU2Rla3_M_H_7T
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit 2b21624fc232 ("hugetlb: freeze allocated pages before creating
hugetlb pages") changed the order page flags were cleared and set in the
head page.  It moved the __ClearPageReserved after __SetPageHead.
However, there is a check to make sure __ClearPageReserved is never
done on a head page.  If CONFIG_DEBUG_VM_PGFLAGS is enabled, the
following BUG will be hit when creating a hugetlb gigantic page:

    page dumped because: VM_BUG_ON_PAGE(1 && PageCompound(page))
    ------------[ cut here ]------------
    kernel BUG at include/linux/page-flags.h:500!
    Call Trace will differ depending on whether hugetlb page is created
    at boot time or run time.

Make sure to __ClearPageReserved BEFORE __SetPageHead.

Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Fixes: 2b21624fc232 ("hugetlb: freeze allocated pages before creating hugetlb pages")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 mm/hugetlb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index e48f8ef45b17..f1385c3b6c96 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1800,6 +1800,7 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order,
 
 	/* we rely on prep_new_huge_page to set the destructor */
 	set_compound_order(page, order);
+	__ClearPageReserved(page);
 	__SetPageHead(page);
 	for (i = 0; i < nr_pages; i++) {
 		p = nth_page(page, i);
@@ -1816,7 +1817,8 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order,
 		 * on the head page when they need know if put_page() is needed
 		 * after get_user_pages().
 		 */
-		__ClearPageReserved(p);
+		if (i != 0)	/* head page cleared above */
+			__ClearPageReserved(p);
 		/*
 		 * Subtle and very unlikely
 		 *
-- 
2.38.1