Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1103596rwb; Fri, 18 Nov 2022 12:50:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6TID33i0PI7juBkf43vo1U0vAJ20XE/W0EgqEymewmtCjkh3Vpgm3YpXsjOgKLu3CWc/CB X-Received: by 2002:a17:903:44b:b0:188:fc3a:3f9e with SMTP id iw11-20020a170903044b00b00188fc3a3f9emr1099484plb.158.1668804608422; Fri, 18 Nov 2022 12:50:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668804608; cv=none; d=google.com; s=arc-20160816; b=PeSZ/GNESa+4VZ5AGozq/S+SZdTok2XeuobS/T6rBsXvpdAiM/dSVpJO2Yc9oR6kWN 0E8D8As62BF6hYO/iaMk8+niU/KdsqQBkMFWdGxfrUC+lPHxPX2NW7OzAE+NKHCWYq8D 8G/MCShArO1Q8yMEYIbtS1ajZ+mJG5oiU6dT7jMrSrX+FLBpIP442duU6LptLSYNGnRp 6g6aCAQ+KvRAS5r895PmqUvoHd5pMiF0iP+GItrLOny58xyccHdqFOS0Qg41sHSHA9rp lVzofNOAI6x1CO+85JIEMOdyyW1UOvwD2Hn1TxLtTRPJiCE0JAjtG41OBtN+xV2ZPTSL GUOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=JQWsUxn8iwDG50vb73epK+aFJHJq3RHHQdvaYLtLc8M=; b=ya55GYHgbINZAPEqDmO16zx6ecUe/AqOkEOUL45p6+rj6qj7m3pwHR40EygEBUVzOc Hd3rALVWTXKxmsuaorPYaUkqI2ivOf9yXp4uamigEA6qhrTBjeFNw4azdGRWdCpHywCo h+fSOHpAXEhttoKBPfbu3RtwIWWyuwiSmslE/FXQd0/sNiu2jBhXs5y0xBzNkS8/kLLE vLu6rfNPMBFZKY/sZ7qiBSoZNzjP7pTsj0/lNPZhBrCbtpyVylO9j1g9TZOM6g2ZTlI4 M9/K2Zk2vpmHSdRIzZ/ZjRVtE1gZSA3p1q7D0kCkTo0fcRxqwYZTtQG2Fz2ScmL/2hUu irug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=IhIDSHWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e23-20020a656897000000b0042ad0333df1si2571412pgt.479.2022.11.18.12.49.56; Fri, 18 Nov 2022 12:50:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=IhIDSHWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiKRT5Q (ORCPT + 90 others); Fri, 18 Nov 2022 14:57:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231171AbiKRT5O (ORCPT ); Fri, 18 Nov 2022 14:57:14 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A59C0514 for ; Fri, 18 Nov 2022 11:57:12 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id u6-20020a17090a5e4600b0021881a8d264so3687860pji.4 for ; Fri, 18 Nov 2022 11:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JQWsUxn8iwDG50vb73epK+aFJHJq3RHHQdvaYLtLc8M=; b=IhIDSHWHRA81XwNFxfXs+jo0NJ3lWJ8tuEBe+JujRGcXjrjswvxlmNznET4cKtE8an 6KezJ3dOjrK5IkAW9lFUdIYD6oJ/XRjJJbojEa4utMg32tUa9JEbBfobHPeHa0EbQRFe l1D8tobow+LbkZxnaf/6WlYRSkTV2Uk9yu0yh0Texq6Rno2f1g+kobJKa/oR/5gQFEbV oGbltDDYy0pEySTtpHAqT8DQRYlI32qziiQtPWQfqmEafItXYO3X8SD5W9Yu3NucmZtX gzRtim1vu++2MCVW7OL0zWqigD7aw8rrBbNpNj67c5wdK/sS0R+aqnyyqBRRqdl+NfpS zuDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JQWsUxn8iwDG50vb73epK+aFJHJq3RHHQdvaYLtLc8M=; b=DgiGBsliT42uXsZ26tmTDqoQzrYvv1L8vpW3To2/IfKW7XrPqwqmokGC+UwSYnbrah nlLZ8P/7n6VPFmloiXEhrXSbVcutE/lP/z0Vdp7tqZpiqrk5mIJzDFgAyd+Ew5Pr0goi inn4AK8q9IeGQYRgFjfeHh+vyGfXHoYvlfTPwr4R5pNqt1xYruLuExdgt+z7iGNRugnd ejzqYn12MZXVWveg0fnVxVnpc6ZMa+uz6h8MsZ4Vy/Vvk7sw+1sgYGDdgHrBlqddpiDN Z2yuoqv+ZGu8oKYjm+lL+2HouhUYFAT4sGWMpMvFZOOOc+t38SV299lfsjCH4gg32T2d Bc+Q== X-Gm-Message-State: ANoB5plhF1GrsypLxvuwrRae6J/q4sfIu3sGxL0P10VL9ynPAxsgvqi9 iPcHOm8TmRmmqADDzFot4sGAteRAShPrxoVpEoDjDBXM9V8= X-Received: by 2002:a17:902:a5cc:b0:186:de87:7ffd with SMTP id t12-20020a170902a5cc00b00186de877ffdmr949005plq.94.1668801432393; Fri, 18 Nov 2022 11:57:12 -0800 (PST) MIME-Version: 1.0 References: <20221118001548.635752-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Fri, 18 Nov 2022 11:57:00 -0800 Message-ID: Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes To: Andrew Lunn , Ansuel Smith Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn wrote: > > > Andrew, > > > > I completely agree with you but I haven't seen how that can be done > > yet. What support exists for a PHY driver to expose their LED > > configuration to be used that way? Can you point me to an example? > > Nobody has actually worked on this long enough to get code merged. e.g. > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > https://lists.archive.carbon60.com/linux/kernel/3396223 > > This is probably the last attempt, which was not too far away from getting merged: > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > I seem to NACK a patch like yours every couple of months. If all that > wasted time was actually spent on a common framework, this would of > been solved years ago. > > How important is it to you to control these LEDs? Enough to finish > this code and get it merged? > Andrew, Thanks for the links - the most recent attempt does look promising. For whatever reason I don't have that series in my mail history so it's not clear how I can respond to it. Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs with offload triggers' [1]? I'm not all that familiar with netdev led triggers. Is there a way to configure the default offload blink mode via dt with your series? I didn't quite follow how the offload function/blink-mode gets set. Best Regards, Tim [1] https://patches.linaro.org/project/linux-leds/list/?submitter=10040