Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8947162f-762e-5ee1-5be7-73ba641149d0@amd.com>
Date:   Fri, 18 Nov 2022 16:05:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] drm/amd/dc/dce120: Fix audio register mapping, stop
 triggering KASAN
Content-Language: en-US
To:     Alex Deucher <alexdeucher@gmail.com>, Lyude Paul <lyude@redhat.com>
Cc:     amd-gfx@lists.freedesktop.org, Alan Liu <HaoPing.Liu@amd.com>,
        Leo Li <sunpeng.li@amd.com>, David Airlie <airlied@gmail.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20221114222046.386560-1-lyude@redhat.com>
 <CADnq5_PrarJPZQu6uRwDdCqhZr7Hvbtxo_HuhiQ7H1DYRgSyqQ@mail.gmail.com>
 <CADnq5_O+bTG3992uZKvJct6-iRWL9nW1xEzXhh3SShm1=VLFtQ@mail.gmail.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <CADnq5_O+bTG3992uZKvJct6-iRWL9nW1xEzXhh3SShm1=VLFtQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3lYZnhyNHVFL1lSNVZlVjlmSkZIcXNkeXBGSzYraDVDWmJNQTRjSE9UVVFT?=
 =?utf-8?B?SDdScE4yL0luNjNMTDhFMjZpN2crVzZNT3o5enZKeFRlR3dQam1yNE5heDFO?=
 =?utf-8?B?MUx4VEo2bVZKVm14ejVmakJBa0JiOStUc2U0eS9MVWFZdkNaMXAyWkJuYW4w?=
 =?utf-8?B?T0FUdDFoUUt5VWdreWRxbEFreVBpZjJRUmF4WVVhQ3N5dDFRdjFwV1BEZnls?=
 =?utf-8?B?eU10cEY2cHg2U2JQUUMyWlI1cGxYSUpocFpVSm5QZ01aLy9PNUxJWVRlT3Br?=
 =?utf-8?B?dE50NUlvWFRML3hxODR5cWgzMWREQ21rMm4rZ0FIaHhId1VxTEZCTmNMSWw3?=
 =?utf-8?B?QjlYUFhHdnRNK2dOQUhoNXdhWWxTNDBxdmtyNnBzOVZWM0twS3BkWjJIb3N5?=
 =?utf-8?B?WlNYZVp6NURvNmF6UjFyazgwMFFYMmszSGc5azUrV3prS2l6NnFtcTFtcHNr?=
 =?utf-8?B?RldkZjhReXNSUkZDcmp0YmlpaEJZQmx1TDV5dTAwK2pTdzdDcjhLY3JRZEtw?=
 =?utf-8?B?a0hzNUNwNmxqSG5YQkcyaUk0R3BYakVaMVRwMElIcXN1VjBUVUE3bnpQQVVz?=
 =?utf-8?B?MUowbUVvNURrTEE3R1RjcFU1ZEJLRkg5OURnY2NBRmFOZWVjeCtpMGFvdFB5?=
 =?utf-8?B?Q1g3akxUUVZIbzRQeTNvbHVlSXB1aUUrZFkvL2pXUWttVkFhYlU3cVVkUThL?=
 =?utf-8?B?YTB5NjEvT2ZKYW9sYVBqSEV2M1VXcmNPYTVobkJ6dUR3WjhZZmdrUjFTREY2?=
 =?utf-8?B?Z0xnY0U5L0s2c1NFWEM4Y21ZVXdUdVkvU2RYN014Zml1L1lSYVhrUG90eU4w?=
 =?utf-8?B?aHU2Ry9SZ1NlaldUS3BuM2huY1lxN1RhU0FVc0RwWXptb0lkYmYrbmZ2YzNx?=
 =?utf-8?B?aVNyTHN1ZW15S3BiVGhrMzI4ZzFUdmpwN3VNVzNkNzRIb3prVkxmaUR0OWVv?=
 =?utf-8?B?aTdiYnRhdWVHNnJLbjA0N1ZRenpiUWJDcThHVmtEcGxXNysvVjRsL3ppbVpT?=
 =?utf-8?B?aHJnelc0ZDlFZFhYNkx2blJHcFo4eEdiK2Q3U1dLdTJOakZxMEJjbytwallw?=
 =?utf-8?B?ZUVIVkE4MFdPb2VBS2xmVHJIVE1HMWR3Um9BdFpCTXpidzBxSXIrR0JBaGlQ?=
 =?utf-8?B?ZDN5Rk4xRFZjZ2F0dXRKVHhBbWRBQXVKMlFoaEZVdWcreEFHby9KU1hCaFc1?=
 =?utf-8?B?RTVxalRGOW5tZFNjaGYxYWtQOGJJQkhZbHp1a0JaSWdKOXh2NG5JTVpOWWRl?=
 =?utf-8?B?SkZhQXFJVk5kYzFDaUo0SW1VeDRreUFObmtPUWFUbkRPNEtHQ1R6cjdXcjZN?=
 =?utf-8?B?U3JtSStEMzRnejRrc2FtOXlLdExzSW0xYzkxcFE4aTNab0VGRWxzN3pMVjZl?=
 =?utf-8?B?aVhFSjdFbFNNSWMxNnBPM3kxYzF4TzgrOXk5WHJVSzhqUGFsMWRZUFdqaDV2?=
 =?utf-8?B?c3NCOEl6c3RRWGRBYUV3d2xzREpJa3YwSVRneHhCMkNoaDNXcG4xelRvdlBh?=
 =?utf-8?B?TEgyK2ZUQmZDek0vRHlFclpQZEdFdnkvZ21QTytZVEx0L3lER1k0d3hnSFh5?=
 =?utf-8?B?WHZmREloenNndGlFT2VWRjJxNUhoK0JtenQ0VmNyYzBpcXdYVWRueWxzbDRJ?=
 =?utf-8?B?Q2xOT2RxZ3FmQkIwU2tuaEdCaVVZbTN5RkxXZG9Hc3Y0SkdicW5qSDVjZWJn?=
 =?utf-8?B?eHhqME1iME50SWdYVlZuYndsZForcXRyZ2FMaCt2bUlIb2FUbCtSa0kvWlRH?=
 =?utf-8?B?MmQrS0JUZG1IYzcxTXUzei9uY3JGUXRFWmJ5dmN2M1VkTlBnaVdBbXh6OXlF?=
 =?utf-8?B?K21Nb2llcXdOalUzeHZpUFdiWFVtaXdKTmVSN2pHcXdnRlZIeXJTTnp2cUpD?=
 =?utf-8?B?REFMcjRSaUUwZ3JwdHRCZVdHSUFYaXJpM3k2eXBLQzNSL0l1R2lNOTViWHZB?=
 =?utf-8?B?bFp5TWZxeVdTd3ZKTk9jODFxL0c5TS9tQlpYMVZIbnJJT2VDWVlHTHJEM3ls?=
 =?utf-8?B?L2RTMVhUeEU1eXVjOE1EdUl6NWljSmE1V1B2blBIcFhaaEVYNFNvNXZ4bWpI?=
 =?utf-8?B?MEVxeGR2ekhaTDRkcXBnSkxXRktpQlJQQVZmd0RRMUMzZ1hXOHNMLzZtUXFj?=
 =?utf-8?Q?B34ikOOXsq/E+9/ikBnrdoohu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97234e57-3d2d-41b1-7d50-08dac9a89630
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 21:05:13.9982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xhizNDcwPxpChmhUvCErSAu5SqjCEOXWOtVwU25ztuU9S51nbDpnoihbK//xXUeEFpWaRfaZg2cCImYmilWofQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7439
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/18/22 15:25, Alex Deucher wrote:
> On Thu, Nov 17, 2022 at 4:40 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>>
>> On Mon, Nov 14, 2022 at 5:21 PM Lyude Paul <lyude@redhat.com> wrote:
>>>
>>> There's been a very long running bug that seems to have been neglected for
>>> a while, where amdgpu consistently triggers a KASAN error at start:
>>>
>>>   BUG: KASAN: global-out-of-bounds in read_indirect_azalia_reg+0x1d4/0x2a0 [amdgpu]
>>>   Read of size 4 at addr ffffffffc2274b28 by task modprobe/1889
>>>
>>> After digging through amd's rather creative method for accessing registers,
>>> I eventually discovered the problem likely has to do with the fact that on
>>> my dce120 GPU there are supposedly 7 sets of audio registers. But we only
>>> define a register mapping for 6 sets.
>>>
>>> So, fix this and fix the KASAN warning finally.
>>>
>>> Signed-off-by: Lyude Paul <lyude@redhat.com>
>>> Cc: stable@vger.kernel.org
>>
>> This is the correct fix for asics having 7 audio instances.  It looks
>> correct to me, assuming DCE12 actually has 7 audio instances.
>> @Wentland, Harry Do you know off hand?  If you can confirm that, the
>> patch is:
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> The driver currently defines 7 audio instances, whether or not it
> actually has 7 remains to be seen but the code as is is broken, so
> I'll apply this.  If it turns out there are only 6 instances we can
> fix the count later.  Applied.  Thanks!
> 

Good catch. I seem to recall some DCE generations had an extra audio
device and if DCE12 defines 7 audio instances then this is the correct
fix.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> Alex
> 
>>
>>
>>> ---
>>> Sending this one separately from the rest of my fixes since:
>>>
>>> * It's definitely completely unrelated to the Gitlab 2171 issue
>>> * I'm not sure if this is the correct fix since it's in DC
>>>
>>>  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>>> index 1b70b78e2fa15..af631085e88c5 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>>> @@ -359,7 +359,8 @@ static const struct dce_audio_registers audio_regs[] = {
>>>         audio_regs(2),
>>>         audio_regs(3),
>>>         audio_regs(4),
>>> -       audio_regs(5)
>>> +       audio_regs(5),
>>> +       audio_regs(6),
>>>  };
>>>
>>>  #define DCE120_AUD_COMMON_MASK_SH_LIST(mask_sh)\
>>> --
>>> 2.37.3
>>>