Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c92d811-63d4-2c92-3018-7ba8d9c4f21a@redhat.com>
Date:   Fri, 18 Nov 2022 15:22:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] kselftest/cgroup: Add cleanup() to test_cpuset_prs.sh
Content-Language: en-US
To:     Kamalesh Babulal <kamalesh.babulal@oracle.com>,
        Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Shuah Khan <shuah@kernel.org>
Cc:     Tom Hromatka <tom.hromatka@oracle.com>, cgroups@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221118101330.251332-1-kamalesh.babulal@oracle.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20221118101330.251332-1-kamalesh.babulal@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/18/22 05:13, Kamalesh Babulal wrote:
> Install a cleanup function using the trap command for signals EXIT,
> SIGINT, SIGQUIT and SIGABRT.  The cleanup function will perform:
> 1. Online the CPUs that were made offline during the test.
> 2. Removing the cgroups created.
> 3. Restoring the original /sys/kernel/debug/sched/verbose value,
>     currently it's left turned on, irrespective of the original
>     configuration value.
>
> the test performs steps 1 and 2, on the successful runs, but not during
> all of the failed runs.  With the cleanup(), the system will perform all
> three steps during failed/passed test runs.
>
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
> ---
>   .../testing/selftests/cgroup/test_cpuset_prs.sh | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_cpuset_prs.sh b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> index 526d2c42d870..b8ed82b55b1d 100755
> --- a/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> +++ b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> @@ -16,7 +16,12 @@ skip_test() {
>   [[ $(id -u) -eq 0 ]] || skip_test "Test must be run as root!"
>   
>   # Set sched verbose flag, if available
> -[[ -d /sys/kernel/debug/sched ]] && echo Y > /sys/kernel/debug/sched/verbose
> +if [[ -d /sys/kernel/debug/sched ]]
> +then
> +	# Used to restore the original setting during cleanup
> +	SCHED_DEBUG=$(cat /sys/kernel/debug/sched/verbose)
> +	echo Y > /sys/kernel/debug/sched/verbose
> +fi
>   
>   # Get wait_inotify location
>   WAIT_INOTIFY=$(cd $(dirname $0); pwd)/wait_inotify
> @@ -54,6 +59,15 @@ echo +cpuset > cgroup.subtree_control
>   [[ -d test ]] || mkdir test
>   cd test
>   
> +cleanup()
> +{
> +	online_cpus
> +	rmdir A1/A2/A3 A1/A2 A1 B1 > /dev/null 2>&1
> +	cd ..
> +	rmdir test > /dev/null 2>&1
> +	echo "$SCHED_DEBUG" > /sys/kernel/debug/sched/verbose
> +}
> +
>   # Pause in ms
>   pause()
>   {
> @@ -666,6 +680,7 @@ test_inotify()
>   	fi
>   }
>   
> +trap cleanup 0 2 3 6
>   run_state_test TEST_MATRIX
>   test_isolated
>   test_inotify

That looks good to me. Thanks for the improvement.

Acked-by: Waiman Long <longman@redhat.com>