Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bb060ac3-b413-6db7-9738-0774764a9457@oracle.com>
Date:   Fri, 18 Nov 2022 16:02:59 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2] cxgbi: cxgb4i: Added pointer check
To:     Denis Arefev <arefev@swemel.ru>, Varun Prakash <varun@chelsio.com>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org, trufanov@swemel.ru, vfh@swemel.ru
References: <20221118121740.128877-1-arefev@swemel.ru>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20221118121740.128877-1-arefev@swemel.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWJPY0dDRGNNeEI0aVlpMEZaank0YWJSRUo4aW41emMzcUJ6RC81RTAvSUFP?=
 =?utf-8?B?RUNkWnc0WDZXL2w5SzluLzJ6cFJqOXNDU1BEb2d6Sm9PdGtnUDZHbkZCeFZr?=
 =?utf-8?B?TzBuOUlReFViN2FDM2RlQk95RzM3eStuTS9Fc3BZNnNyR1pGdmVML212VWZr?=
 =?utf-8?B?c0w3TE4xcWhic0xyYWRHaHJvZ0FXWEtQa2ZwRlhXN3Rjd3c5eWhkQ3hFQmkv?=
 =?utf-8?B?cE1BUmVueCtUZWttcFlJSVVGazhzQWlab1BNVjBmOTNRYmV3M1FIOTVlTnVs?=
 =?utf-8?B?bmdHVGVZS21rZEt2aXIvRVhJOVp0WWs3OHBzYzc4MFMyaWdOcnJhc000b1ZV?=
 =?utf-8?B?cTE1amFHK0MzcmFYUVZhNzdjNE9TVkRWQ3pJanJkNDBQcGpkSFd2QmsyeFY3?=
 =?utf-8?B?VGtVNG55ZlFRanRNSWdQbHhRZ3NCenQ4WnVvc1F4ZjJMVnZnZVBoTHZCbU00?=
 =?utf-8?B?QnBkY0ZtR01oaW5HbTJHV2RRR1NCb1R3dVVxc2h2eVNOcXpNL3kzZnczdW1u?=
 =?utf-8?B?NFdCamdOZTRtNzRFeWNrY2NpckZQdzNIVEYybTlrUWN3eW4zT3ZhMVExL2Fl?=
 =?utf-8?B?bVZ4Zll6YlgzZER4ekZ4cHFQUzRzY2pRRnFXazZERDB5SzdPQjdPdGhWMzNR?=
 =?utf-8?B?dzNidlUrMVd2a2xaR1ZYdVBrZUVhQW5tVWczdFg4WTNPbFlCOVorVTgxY1d2?=
 =?utf-8?B?QzhKLzdqeWRqdS9LWlNhVUhSL01UVy85K2RIQVFHRVpJVnRoYUxua2FBRDVO?=
 =?utf-8?B?V05xd0tSZFFmcm90eVYzeVpXQVhnb1RCSnFTejQyM3hubVkrQVpRYXJVYUNk?=
 =?utf-8?B?bXpmenlFRm9vYVhOREd2ZHRxNlpzYnJNTGc0K1JsREgvNHY5NGNIOG9WQTBx?=
 =?utf-8?B?R0FQTno3V0V5UFhKbEhKTW5FQkRIK2ovS3ZHM29DU3NybUdwVDUyMWx4SkRO?=
 =?utf-8?B?RnZuTElDYjNnQ0Uva2RQRmVRYmU4SkpxNlNqQUltdkRmZmttNVFLRCszeUZN?=
 =?utf-8?B?UlZnUXdPMitrYklLSHc3b0dPRWFYK1labjlHUHJJeEFmMk1yK0swMVNzbThQ?=
 =?utf-8?B?bUZ6WEs1b2ZsZkR3LzEyQTlocDczcDNGek9ncVJDMFFENlhld3hsVW1JV1dO?=
 =?utf-8?B?T0hoeTVrR2lpZVY0WGMzSzNReGNUVDNWQ1dFSWdkY0laazZLZ0o5SUxTU3J0?=
 =?utf-8?B?S0pHbDFJbExObXZuZS9OZzVNTTBxWEUzUGFJT2kzRG12cCtxRGZvbjk2U3pS?=
 =?utf-8?B?UzAvOU12eGtUY2s1aUgrdmxkZ2JzUVVlTTFmeWgwTFJkREYveDFlWVVSRmlo?=
 =?utf-8?B?ZTk4ZmJIRFdYUk5kM2Qxa285M2hWWEdIVFBLYUdtSUF3b0FpT0VVT2hiVjY1?=
 =?utf-8?B?OERZSDEwOXRtWjlZa3ZoamhlQ0hBRzlZRmMwMWp2bmYvZmdDUERnQUs5YWti?=
 =?utf-8?B?M29JcDVlRTVqRG84S0FJaXNNQTl5QVlkTXpCcDFZZDlqNmNQcmExc2RhWmRU?=
 =?utf-8?B?SkZ6Y2FVQW9lYTFQenFQSG5JMlR3a3VDWm1UeWdoVEo4Smk4Q3dIZDA4N2Vp?=
 =?utf-8?B?ME01TG1PSFBod3lJT1N0dmlRMjZ1YXRhT2pLenJFVnh5enNRYUJjeUVZUDFm?=
 =?utf-8?B?eGlkUmI2cFJTK3lxWDlCcHF3M3ZZR2Z5Uy9VT1ZjaHM2M1F1TUlKblV6dUZh?=
 =?utf-8?B?M0ZiRktDWHFjbG9rdC9OeDJ2dUNyeDE2aGRDV25LcjBBV2l2ckMyOVZNVlN5?=
 =?utf-8?B?UHJpWUxnUytTbHBEa1pyUm1valJYMVN0dnJyNEV5TGRYRVFHSUxUaUpUSEFz?=
 =?utf-8?B?dDdDL1NFWEJCbkY0OHNMQXBFeThoY0RmOTBYZFg1NHBhNEVNd0JoY3p3NTZS?=
 =?utf-8?B?N3NTQXc2eG5LY2ZjNHlpMDczVUlab1VjN2lBenNiSlpMYTN5VjBBamNEa3Ux?=
 =?utf-8?B?Y3ZmcWF4UHF5MjJQUWNSbXg2aTd6Szh2SzcyMXZwTXZITlM3NDBzbW1wZG1y?=
 =?utf-8?B?RlI4VTU2WTJvc2RYNDZDTTNzbVNRcG5nTFBMZlcrWW55OTBXNnBJSlFoNG03?=
 =?utf-8?B?QTQwRm4ySVJUOGs3dFNyejR1eTdrSkI1b01yU0QyQU1XcmVFTGVTSGFobGdE?=
 =?utf-8?B?N0dDTHpmcXhwVjY5TnFaUTZxK3lyWmY3emV4YVcxSlNxenJ6cmtsbkxick1L?=
 =?utf-8?B?NUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Nkc0VGkyTTJ5ZGlSTUw4TVFFbHVzeWJDbGxXUWV2MnJVWE9zbUFHVHBLT1N5?=
 =?utf-8?B?UElKQ1QxMk9OcXNjTnlQbER0ZEhPb1BtL3M4THF1UEUzVDhXNDFKWUUyOS9W?=
 =?utf-8?B?OFJHRlNrTytYQWt0RjA3VmVxaEdWbkVqSXA2NUpnNFg0Vmo2YnNCaE0vVnJp?=
 =?utf-8?B?NmtUQmtFSTR5T0k2K1dIeUdGS09Id3ljcGt0NUZVd0lTUjlWMCtwODBUa3Ez?=
 =?utf-8?B?QU0ycTFrMTRibnlEdnhpZGpJZHBHNGc1bmlHVGZvemNnSnNOYis3Q0JJVEg4?=
 =?utf-8?B?b1I0M2FsVUNVd1ZLaFk4Vmg0amdOZThNUk1kK0VSVUN3NDR5aytHQ2ZUclZz?=
 =?utf-8?B?SW1sKzloN2xPK2Jld0VtMVNYd3NiRkY3YnpVUW9hRk4yN2hTZFExcktWS015?=
 =?utf-8?B?YXN6K2g3dWgxdDAwZjV2RzVaMzAxTDVmWkZPOE91bTBGTEtkODRWbnV6MFB5?=
 =?utf-8?B?TDRZSXBFOU9NQTRaYmFyTTRzVGVUOGRoTXlXeVY0SHRESnpvMGpsSWVzUVo2?=
 =?utf-8?B?cGdGV0g1OUNia1FGOHRKVkFRR0toZUZyQ1ZCdTVzMTZXdHk0MFFONFZqZzhM?=
 =?utf-8?B?OWp4N2dIdjg3NDcrVitPL0xuRHFzbktWa1U4ZG9pKzJnWDZsaEtUbVlnZmg1?=
 =?utf-8?B?cDZZenVaOHBaQnRrQWpvR0o1MmdNUHlPQ0R3dDJqSlRoaHhYVzNrMHpCRXRU?=
 =?utf-8?B?RCtJOXZodS8zSzlIdG5lWjZWY2k3amFWa2I0dUEydjREYXRLQmtyMjdaL041?=
 =?utf-8?B?T3pkbEw2bURXaVpVT1krZTJFbmEvT1JYMW42ODdsamdjSEJOc0dXL3lHOEJv?=
 =?utf-8?B?cmRYMTRhTHhuNDJIQS91V2dxQ2xzMGFFUFJFbTEvVVRoU211UGZrU0Fqdm5T?=
 =?utf-8?B?YWFBMXgwRVB6NEhyUG5uWTJuS3FDakJIUTdNenc4V2c1dm9JcGJGRWR0M2hh?=
 =?utf-8?B?QUZoYTJLZ2Npd1dRYUlwTkltYlNxSEUyWXVJc3MyRmFBR2dnVGRiOHRJaFZX?=
 =?utf-8?B?c05pUHRtNHV4UENRNmdldWNscXFhNkd5OW5JMWNCaVdyTlpEZE5lOEVGbUtW?=
 =?utf-8?B?dzU0YUtXWEg1NytLazBXcEdhNC9KT25OcjBYZzBDMnZVK3ovT20wWFF1R3BT?=
 =?utf-8?B?SldOMHRLUmljc2tWQ28vR2RJNzhJelp1T01IcVZwMENLSnR6aUNjcDhmZ3pV?=
 =?utf-8?B?ZE9nMXhPNjYzSTZUVHhjTGpmc0dKZEtwWlNTb2FVUHRmSUlGWXM2MUJlZVFV?=
 =?utf-8?B?MHprSFN5SURkWG5LUm1YclhTYzdaaUgzS3lXWnZ6U3FQT0I2NVZxbWpub01s?=
 =?utf-8?Q?PdKhfFUvgXRVoRkvQp+M4mjkh5TKjXRrNu?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af3292c8-205b-4f7b-9efb-08dac9b0ab9e
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 22:03:05.8635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYGZezlwkl864sE6Xsby+VL/v1HbCh2h4yhk+qCCOyqNB9NKkk5GPeA1sgVXYr10wrDGxFW2dZ2aB2zt+1beI+1EKUJeDgMnZnyv7heGA8U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6276
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-18_08,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211180131
X-Proofpoint-GUID: i8fPNBB8kzJxGlrOnEmdD97k4y9OuJj1
X-Proofpoint-ORIG-GUID: i8fPNBB8kzJxGlrOnEmdD97k4y9OuJj1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace Karen with Varun.

On 11/18/22 6:17 AM, Denis Arefev wrote:
> Return value of a function 'alloc_wr' is dereferenced at cxgb4i.c:624
> without checking for null, but it is usually checked for this function
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> index 2c3491528d42..b93bd36dcb2d 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> @@ -620,6 +620,8 @@ static inline int send_tx_flowc_wr(struct cxgbi_sock *csk)
>  #endif
>  	flowclen16 = tx_flowc_wr_credits(&nparams, &flowclen);
>  	skb = alloc_wr(flowclen, 0, GFP_ATOMIC);
> +	if (!skb)
> +		return -ENOMEM;

If this returns a negative value push_tx_frames is going to mishandle it.
I'm not sure how to best handle the failure there, but I cc'd the correct
maintainer, Varun.