Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Fri, 18 Nov 2022 22:31:55 +0100
From:   Michael Walle <michael@walle.cc>
To:     Jonathan Corbet <corbet@lwn.net>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 02/18] of: base: add
 of_parse_phandle_with_optional_args()
In-Reply-To: <20221118185118.1190044-3-michael@walle.cc>
References: <20221118185118.1190044-1-michael@walle.cc>
 <20221118185118.1190044-3-michael@walle.cc>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <8b976cf546bad3aa159a6f05cd3c15d1@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 2022-11-18 19:51, schrieb Michael Walle:
> Add a new variant of the of_parse_phandle_with_args() which treats the
> cells name as optional. If it's missing, it is assumed that the phandle
> has no arguments.
> 
> Up until now, a nvmem node didn't have any arguments, so all the device
> trees haven't any '#*-cells' property. But there is a need for an
> additional argument for the phandle, for which we need a '#*-cells'
> property. Therefore, we need to support nvmem nodes with and without
> this property.

I've just noticed that this isn't enough. We also need to fix the 
parsing
in drivers/of/property.c, otherwise spurious device links will be 
created
because the phandle argument is treated as a phandle itself.

-michael