Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1204878rwb; Fri, 18 Nov 2022 14:33:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf6W1dNNDCCAytCmufLI52MG+K1C4+ujThqaNXEClLlC9xIGtUAuDJosu3Jl8TRB206vLZXP X-Received: by 2002:a17:902:f78c:b0:186:8c13:50b3 with SMTP id q12-20020a170902f78c00b001868c1350b3mr1385309pln.153.1668810813239; Fri, 18 Nov 2022 14:33:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668810813; cv=none; d=google.com; s=arc-20160816; b=gG1Bu9AbMbP9aKEYD5i2Sl4K5rZTyN/EKfyyrIuVkLqUDjGS7bOJmyDaMlTn/V5CSb ybDKImpzvjmvaYx/LFqsWH1bdFcTdloR5IELUnzSviAwKTxa7sfQEBeGqgjugrSh1SSA PTBxIBvQDPkdkLdmgqtDgi9IhX5gbzee+PXaonqLjlrX+HU7TzhrOwrHULdHZFY6Nk3I n07m0iXRGwX4GqQ/G2iCSS35BtpGdlrlh9n4VV+9YWWK5MvcR5Scu9f4zjem0X3QzS5Y 2wCMrK/r72LX0kzFP6H+v6stfBR+q6NHXIhvcd8Gx4jXumCVbZzdtqDbgQmYH5tbXbYB 11Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sPsTPFJs+c12da0mW0C8g+kC/p0ECuxXLSQBBv8/z1g=; b=YgYrbiC61Teb7wPLxSGG+n6sDWwCIhcLcuQ5jDDCqszk/0ZQetaPQ/GCba8LlbFR5m UtxmACmfjL0KrXxTReaM/TpYCDCBWc+ITLLpfqHU1xc6FrxkP4EOdfgEEOj2gw97joV3 zXeTStQCnZDzW0a3ImD2GBxuqwKQ21AR08SMpvIxejygX/w2XoBGRch6UFWLl2Ur57Gs zHZjVbj0bgM8HCH4Plz5CnSWaebTcYQcSk44ZzI7Y97dsHdVN1Ei16tDgbMDI9BEENl9 Rc+fCs7X99W4jGsPolCw/SOrUPuy/v8E57/fyqNZZIko6wztwdD3w9qDSMz6kPUkwsyc KM3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="toPfbsH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a1709028f8700b0017f908814c6si4306503plo.532.2022.11.18.14.33.12; Fri, 18 Nov 2022 14:33:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="toPfbsH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbiKRWWO (ORCPT + 90 others); Fri, 18 Nov 2022 17:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbiKRWVp (ORCPT ); Fri, 18 Nov 2022 17:21:45 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F24B73B1 for ; Fri, 18 Nov 2022 14:21:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1EA266279B for ; Fri, 18 Nov 2022 22:21:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57381C433C1; Fri, 18 Nov 2022 22:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668810066; bh=4DoYnw76fqOF8eoz1c60HE/LDDgiMmHOaEFrZSG7zM8=; h=From:To:Cc:Subject:Date:From; b=toPfbsH/EUCweFHQkkcTAJAYHlBhpjWw6HJuieDCirr45iDNrounR1QQbmJu3XkbT SQTLhLHW+fTgvDx8tt5VSbBO4EI73wCapTukbtkBQRtfJHD0R9sCAOwNEay+zl9PaK hVxQ0i/j9Rpqr3ljz16xoInTo/spcexxVq9gIdN668vjKAtoqefmcmDz/DcBOQQxNe OrId17JArabETsrwELjHo9VaRVM8Mo9sfkiVlTPF7ZOk2F8TsSiXU5RfV3AF2yWWQD u3TdTCADxuAfV0cKjafQcn3aSEJJWLnGr4VMvJ71WwvA9H8P4fqXxWUzPwNbZz84Qp 0NeCaeR4vIFaQ== From: Conor Dooley To: Conor Dooley , Jassi Brar Cc: Daire McNamara , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] mpfs: fix handling failed service requests Date: Fri, 18 Nov 2022 22:20:42 +0000 Message-Id: <20221118222043.1214776-1-conor@kernel.org> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Conor Dooley As things stand, if a service request fails, we never know about it as the status register is not read. This is quite obviously far from ideal, as we would be reading garbage from the mailbox if a service was to fail. This pair of patches adds handling of the service status to both sides of the mailbox implementation. @Jassi, there should be no build, or really functional, dependency here between patches. In the failing case, the buffer is allocated by the service driver, so things will "work" just as badly as they did before if only one of the patches is present. As a result, should be safe to do the mailbox patch via your tree & the client via the soc tree. Thanks, Conor. Changes since v1: - Send the patches I meant to send, with an extraneous ; removed. Conor Dooley (2): soc: microchip: mpfs: handle failed system service requests mailbox: mpfs: read the system controller's status drivers/mailbox/mailbox-mpfs.c | 31 +++++++++++++++++++-- drivers/soc/microchip/mpfs-sys-controller.c | 6 ++++ 2 files changed, 35 insertions(+), 2 deletions(-) -- 2.37.2