Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f431abb-356c-b057-2784-6b5f165a2a2d@flatmax.com>
Date:   Sat, 19 Nov 2022 10:01:07 +1100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 603/606] ASoC: codecs: src4xxx-i2c: Convert to i2c's
 .probe_new()
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <uwe@kleine-koenig.org>,
        Mark Brown <broonie@kernel.org>
Cc:     linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-604-uwe@kleine-koenig.org>
Content-Language: en-AU
From:   Matt Flax <flatmax@flatmax.com>
In-Reply-To: <20221118224540.619276-604-uwe@kleine-koenig.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Reviewed-by: Matt Flax <flatmax@flatmax.com>

On 19/11/22 09:45, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   sound/soc/codecs/src4xxx-i2c.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/src4xxx-i2c.c b/sound/soc/codecs/src4xxx-i2c.c
> index 43daa9dc8ab5..27026030704a 100644
> --- a/sound/soc/codecs/src4xxx-i2c.c
> +++ b/sound/soc/codecs/src4xxx-i2c.c
> @@ -12,8 +12,7 @@
>   
>   #include "src4xxx.h"
>   
> -static int src4xxx_i2c_probe(struct i2c_client *i2c,
> -			const struct i2c_device_id *id)
> +static int src4xxx_i2c_probe(struct i2c_client *i2c)
>   {
>   	return src4xxx_probe(&i2c->dev,
>   		devm_regmap_init_i2c(i2c, &src4xxx_regmap_config), NULL);
> @@ -37,7 +36,7 @@ static struct i2c_driver src4xxx_i2c_driver = {
>   		.name = "src4xxx",
>   		.of_match_table = of_match_ptr(src4xxx_of_match),
>   	},
> -	.probe = src4xxx_i2c_probe,
> +	.probe_new = src4xxx_i2c_probe,
>   	.id_table = src4xxx_i2c_ids,
>   };
>   module_i2c_driver(src4xxx_i2c_driver);