Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd214418:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <6cb6c30b-2670-446a-8425-92d340ab5b90@app.fastmail.com>
In-Reply-To: <20221117190507.87535-2-linmengbo0689@protonmail.com>
References: <20221117190507.87535-1-linmengbo0689@protonmail.com>
 <20221117190507.87535-2-linmengbo0689@protonmail.com>
Date:   Sat, 19 Nov 2022 09:27:39 +1000
From:   Alistair <alistair@alistair23.me>
To:     "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
        linux-input@vger.kernel.org
Cc:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        devicetree@vger.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: input: cyttsp5: document vddio-supply
Content-Type: text/plain
Precedence: bulk

On Fri, 18 Nov 2022, at 5:05 AM, Lin, Meng-Bo wrote:
> The Samsung touchscreen controllers are often used with external pull-up
> for the interrupt line and the I2C lines, so we might need to enable
> a regulator to bring the lines into usable state. Otherwise, this might
> cause spurious interrupts and reading from I2C will fail.
> 
> Document support for a "vddio-supply" that is enabled by the cyttsp5
> driver so that the regulator gets enabled when needed.
> 
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

> ---
> .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> index 1959ec394768..869a9bdd962f 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> @@ -34,6 +34,9 @@ properties:
>    vdd-supply:
>      description: Regulator for voltage.
>  
> +  vddio-supply:
> +    description: Optional Regulator for I/O voltage.
> +
>    reset-gpios:
>      maxItems: 1
>  
> -- 
> 2.30.2
> 
> 
>