Date: Fri, 10 Aug 2007 01:39:10 +0200
From: Adrian Bunk <bunk@kernel.org>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz,
       pcihpd-discuss@lists.sourceforge.net, akpm@linux-foundation.org
Subject: Re: [2.6 patch] cpqphp_ctrl.c: remove dead code
Message-ID: <20070809233910.GB18938@stusta.de>
References: <20070723145105.GK26212@stusta.de> <20070809145140.654303a0.kristen.c.accardi@intel.com> <20070809222427.GA32127@suse.de> <20070809154702.caa67a61.kristen.c.accardi@intel.com> <20070809230436.GA18938@stusta.de> <20070809162001.a5dc0b76.kristen.c.accardi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20070809162001.a5dc0b76.kristen.c.accardi@intel.com>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1487
Lines: 43

On Thu, Aug 09, 2007 at 04:20:01PM -0700, Kristen Carlson Accardi wrote:
> On Fri, 10 Aug 2007 01:04:36 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > On Thu, Aug 09, 2007 at 03:47:02PM -0700, Kristen Carlson Accardi wrote:
> > > 
> > > fine by me - let's NAK this patch (and all future ones for this driver) until 
> > > someone with hardware steps up to maintain this driver.  Eventually it
> > > will just die I guess.
> > 
> > We have tons of unmaintained drivers and none of them has such a silly 
> > auto-NAK policy.
> > 
> > cu
> > Adrian
> 
> OK - "all future ones" was too extreme.  I'll take trivial patches (of
> which this one is not).

As I've wrote in the patch description, all it does is to remove an if() 
check that could never be false (which is easily verifyable if you look 
at the source code).

I've also verified that my patch does not change a single bit in the 
object file (after compilation with gcc 4.2.1).

What's your definition of a trivial patch?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/