Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1320035rwb; Fri, 18 Nov 2022 16:40:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf5XaYoRZ18pI/oYILo3NYcoWF9+Loz2wrlcqF6o+rpiY2hwdS7+Uoacu5oE4waROQvc+KsB X-Received: by 2002:a05:6402:389:b0:459:2515:b27b with SMTP id o9-20020a056402038900b004592515b27bmr8269855edv.338.1668818448472; Fri, 18 Nov 2022 16:40:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668818448; cv=none; d=google.com; s=arc-20160816; b=OxjLRENUZ8nUhtT/Zg5R/U1WXK0xTRvoOca0SpGjHNjzp/6xu77hyVy55JOk7O4gfu OjXIRf0oCUhdz//NJPA4RNswGBPX7nLUv4cT/BIxanwRKqQ/R+O/yXujpNwJoUpTcy3z eEoC9rsqTuu6+TwP8DKON0h7MdzwRIonTvNAm32/MYYZPYpaHEiSJcmjEc0Q7j8Sim12 IIIVSYL8GvKeCj74oSGjQioMhgOfxlqDjb8EWbwWwk1JcEg/JxWd6iTFYliMHekGihp5 RXWNygjmb9gM+qgVOnVhLj4C7UolL5jhju/hKSOwUX3cRM+eWMY6X2lvtz0M0oYR60qN GRxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FUkjlDNArKjjQ8kJZjGwzF/3HUFx7XOdaVbyxfCWcUE=; b=QKUpRI21410xJvFA8E7KewrjbEZYqF4ALVauGJRFqrY3mUWa1WwP3Dwl2diVWS/yLc htCmdcsIY2ZVnDqzoxBLO7GIlvqjDa57wv2NPYODz5t1CvIbL/lV5OQ1T1ZB3mde4/FF i5CpCV2HbJfpEweJTr+V6D0BHJmOcgGIe+cnWxpg20CorTFofjP0ErWoXxc9Rpeq5pwh ef6VrzJliHbV3I+XsppogtM9SaqMgN//Mr7CDV/w3vsAxQr/zE/tzAqK4KuovN+3u5yO SwYX9dOcWOx+NgRNbqA0Zn8GZwwg9rkOrLgks2SW4CD4lBuI4vJlt7BlIBSJGlBEABa/ xVlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=b1swgfix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm8-20020a170907948800b007add150c78bsi4464096ejc.216.2022.11.18.16.40.27; Fri, 18 Nov 2022 16:40:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=b1swgfix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236683AbiKRXhg (ORCPT + 90 others); Fri, 18 Nov 2022 18:37:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236484AbiKRXdF (ORCPT ); Fri, 18 Nov 2022 18:33:05 -0500 X-Greylist: delayed 600 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 18 Nov 2022 15:21:12 PST Received: from ixit.cz (ip-89-177-23-149.bb.vodafone.cz [89.177.23.149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F6425D3; Fri, 18 Nov 2022 15:21:12 -0800 (PST) Received: from [10.0.0.163] (_gateway [10.0.0.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id BB27723094; Sat, 19 Nov 2022 00:05:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1668812735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FUkjlDNArKjjQ8kJZjGwzF/3HUFx7XOdaVbyxfCWcUE=; b=b1swgfixVG0FdjL+U8GaKKbsNZMUrJWDHjsK/Rd2P3cz8KUyn/0pnKUrjBI0SXjYmdYrR0 2V+F79kEOoejoa6HrzAYl6/NKzo9gM7FkNlDMBo+Mmo62KzWCavXK/xDSaYZYotmG5MGqY Rb/FwxzNF/ZFkzIl8/uwNGQIXOoDtTo= Message-ID: <0ff119d8-958b-4978-83c7-e066b8e0cab9@ixit.cz> Date: Sat, 19 Nov 2022 00:05:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Thunderbird/104.0 Subject: Re: [PATCH 114/606] iio: light: al3010: Convert to i2c's .probe_new() To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Jonathan Cameron , Paul Cercueil Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-115-uwe@kleine-koenig.org> Content-Language: en-US From: David Heidelberg In-Reply-To: <20221118224540.619276-115-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you! Reviewed-by: David Heidelberg On 18/11/2022 23:37, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > drivers/iio/light/al3010.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c > index ce5363845b22..69cc723e2ac4 100644 > --- a/drivers/iio/light/al3010.c > +++ b/drivers/iio/light/al3010.c > @@ -164,8 +164,7 @@ static const struct iio_info al3010_info = { > .attrs = &al3010_attribute_group, > }; > > -static int al3010_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int al3010_probe(struct i2c_client *client) > { > struct al3010_data *data; > struct iio_dev *indio_dev; > @@ -230,7 +229,7 @@ static struct i2c_driver al3010_driver = { > .of_match_table = al3010_of_match, > .pm = pm_sleep_ptr(&al3010_pm_ops), > }, > - .probe = al3010_probe, > + .probe_new = al3010_probe, > .id_table = al3010_id, > }; > module_i2c_driver(al3010_driver); -- David Heidelberg Consultant Software Engineer