Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ff119d8-958b-4978-83c7-e066b8e0cab9@ixit.cz>
Date:   Sat, 19 Nov 2022 00:05:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101
 Thunderbird/104.0
Subject: Re: [PATCH 114/606] iio: light: al3010: Convert to i2c's .probe_new()
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <uwe@kleine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>
Cc:     linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-115-uwe@kleine-koenig.org>
Content-Language: en-US
From:   David Heidelberg <david@ixit.cz>
In-Reply-To: <20221118224540.619276-115-uwe@kleine-koenig.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thank you!

Reviewed-by: David Heidelberg <david@ixit.cz>

On 18/11/2022 23:37, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   drivers/iio/light/al3010.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
> index ce5363845b22..69cc723e2ac4 100644
> --- a/drivers/iio/light/al3010.c
> +++ b/drivers/iio/light/al3010.c
> @@ -164,8 +164,7 @@ static const struct iio_info al3010_info = {
>   	.attrs		= &al3010_attribute_group,
>   };
>   
> -static int al3010_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int al3010_probe(struct i2c_client *client)
>   {
>   	struct al3010_data *data;
>   	struct iio_dev *indio_dev;
> @@ -230,7 +229,7 @@ static struct i2c_driver al3010_driver = {
>   		.of_match_table = al3010_of_match,
>   		.pm = pm_sleep_ptr(&al3010_pm_ops),
>   	},
> -	.probe		= al3010_probe,
> +	.probe_new	= al3010_probe,
>   	.id_table	= al3010_id,
>   };
>   module_i2c_driver(al3010_driver);

-- 
David Heidelberg
Consultant Software Engineer