Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1348280rwb; Fri, 18 Nov 2022 17:14:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf66betyEgFMCxqSOgEFo4Nu9IBy8LAonES1IuMrgNSkxCvKRM7wKnchNlW4+P73hvjW9588 X-Received: by 2002:a63:5802:0:b0:46f:59af:c1f4 with SMTP id m2-20020a635802000000b0046f59afc1f4mr8446798pgb.344.1668820479424; Fri, 18 Nov 2022 17:14:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668820479; cv=none; d=google.com; s=arc-20160816; b=OKRCnWg57M0mv7EHEUuALnAnG0GUnv+dK/1wOTbCJFpvanaW1wGqZqq3Q//c4eoS94 i6j0Z6FLcg9JvDM3T71KSx1lxWFx/CR4/P5vqa+rTgI5YA7hZfmWgq4xcWg+8NylLWPa hkmsz9fF51ezw51Zjt6uIHeoUePnrrzfBG2mq3jA9XvscRcwZSnBE0Jui/VeRoA1sIQZ hBbLNMS1JhIjp2M2IU1g09yGbiN5smF0I/eZE2zty87lWjl9o9cF17edosYTuqce78GT XVA1etz/NPsx94fISentK8d72wLgIkKwq4mmOkzYxbSNroPJkbwF8FfT9CIQW+TyvwKN drEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WtctSNu4qusCcZu4K/5G/SQ0DUIhv1MzbdacNVOFg5s=; b=dHkuJM0nDfqqOb95azsgA4ok/06besnGMKNIvaNJQe0lwn0ka4lWhAztIgnzy5T8vr UafpheZLUv41fcmwNMsKjjIISH8peX+HL0CfHfIwUc4ltlTgrNXDRRjNO9+CeegBKuH4 RyCQQgQrdctGNBvWaVounLEmFAdTZYIVw0QrGBI+rVrOi48wSOHcCbja1FjedN5rLan2 u8QH6IRUWPXe9n+3Mm2Myv/eURTnFGdJRNqZshq7GJwOeJu5j4VXaYUjT0FTi8R/1WIX Z+u44fKYmE2aLQbDowXnc3/edcGtdakJ+akjnaJwL8kG7vuxhQ8Ol3iKUDatXXJDrxZp xj1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C54qqpT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d63-20020a17090a6f4500b002119e6aa0casi4542214pjk.43.2022.11.18.17.14.24; Fri, 18 Nov 2022 17:14:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C54qqpT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbiKSAIx (ORCPT + 90 others); Fri, 18 Nov 2022 19:08:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238006AbiKSAII (ORCPT ); Fri, 18 Nov 2022 19:08:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9293F039E; Fri, 18 Nov 2022 15:32:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C4C262530; Fri, 18 Nov 2022 23:31:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDC3BC433D6; Fri, 18 Nov 2022 23:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668814285; bh=MZRS+OxXQgl42Jjr+WbabGJEkBW38tBtHB6EUxM6AKk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=C54qqpT5p8AJ9wUR+xc0T+6B4T96kvXuIeWdyAckzRkYZNZS5VAr8v3AUt9YcmNcm YMtZUGODSZmsu8b88G/cOHiWNVl5+LaDl65qyWwJj4sEbERq2vKDKGQpA1rhztZMk/ hSU++cew6i/ziFIPa5YdkKdjwdo3VRe4wCu3sXB1Qrpu13VKkBKCWWHsUOX7bTt2Gd oKtOqmswhMZbhOCaXWgK6a2yteC/ad9lEjF2uQp5EQz5vdaIEGjc3WJXwGPvaDNVsr vQFQrfPtOOpuq7ptCs9nilWOU4vOq1WtV/4Mp2zgEC5Nc5NKX8jUcKeAnHNe1nBwfz RJaCRz831PWNg== Received: by mail-lf1-f51.google.com with SMTP id be13so10642254lfb.4; Fri, 18 Nov 2022 15:31:25 -0800 (PST) X-Gm-Message-State: ANoB5pkKlpvb/FO3LA52IKr+ho0SQdQsNUSkDp4pQH5iC8F1IgJnoAw9 sLOHIFmcvG2+P/ZKWFoEtlvRALEGC12bECsg+kw= X-Received: by 2002:a19:6b19:0:b0:4a2:740b:5b02 with SMTP id d25-20020a196b19000000b004a2740b5b02mr2898306lfa.122.1668814282766; Fri, 18 Nov 2022 15:31:22 -0800 (PST) MIME-Version: 1.0 References: <20220921145422.437618-1-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Sat, 19 Nov 2022 00:31:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/16] x86: head_64.S spring cleaning To: Borislav Petkov Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , Michael Roth Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Nov 2022 at 19:26, Borislav Petkov wrote: > > On Wed, Sep 21, 2022 at 04:54:06PM +0200, Ard Biesheuvel wrote: > > arch/x86/boot/compressed/Makefile | 8 +- > > arch/x86/boot/compressed/efi_mixed.S | 337 ++++++++++++++++++++ > > arch/x86/boot/compressed/efi_thunk_64.S | 195 ----------- > > arch/x86/boot/compressed/head_32.S | 4 - > > arch/x86/boot/compressed/head_64.S | 299 +---------------- > > arch/x86/boot/compressed/mem_encrypt.S | 152 ++++++++- > > drivers/firmware/efi/libstub/x86-stub.c | 2 +- > > 7 files changed, 496 insertions(+), 501 deletions(-) > > create mode 100644 arch/x86/boot/compressed/efi_mixed.S > > delete mode 100644 arch/x86/boot/compressed/efi_thunk_64.S > > Ok, it all looks ok to me. > > You could send me a refreshed version ontop of latest tip/master, after > having tested the EFI side and I'll test the memory encryption side. > > If there's no fallout, I think we could queue this. > Sounds good.