Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd214418:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <ecb333d9-b681-4024-ac3a-3a9e51d613eb@app.fastmail.com>
In-Reply-To: <20221118224540.619276-265-uwe@kleine-koenig.org>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-265-uwe@kleine-koenig.org>
Date:   Sat, 19 Nov 2022 09:27:04 +1000
From:   Alistair <alistair@alistair23.me>
To:     =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>,
        "Angel Iglesias" <ang.iglesiasg@gmail.com>,
        "Lee Jones" <lee.jones@linaro.org>,
        "Grant Likely" <grant.likely@linaro.org>,
        "Wolfram Sang" <wsa@kernel.org>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc:     linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
        linux-input@vger.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 264/606] Input: wacom_i2c - Convert to i2c's .probe_new()
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 19 Nov 2022, at 8:39 AM, Uwe Kleine-K=C3=B6nig wrote:
> From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> The probe function doesn't make use of the i2c_device_id * parameter s=
o it
> can be trivially converted.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

> ---
> drivers/input/touchscreen/wacom_i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/tou=
chscreen/wacom_i2c.c
> index 141754b2764c..c9188ee00c62 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -162,8 +162,7 @@ static void wacom_i2c_close(struct input_dev *dev)
> disable_irq(client->irq);
> }
> =20
> -static int wacom_i2c_probe(struct i2c_client *client,
> -    const struct i2c_device_id *id)
> +static int wacom_i2c_probe(struct i2c_client *client)
> {
> struct device *dev =3D &client->dev;
> struct wacom_i2c *wac_i2c;
> @@ -265,7 +264,7 @@ static struct i2c_driver wacom_i2c_driver =3D {
> .pm =3D &wacom_i2c_pm,
> },
> =20
> - .probe =3D wacom_i2c_probe,
> + .probe_new =3D wacom_i2c_probe,
> .id_table =3D wacom_i2c_id,
> };
> module_i2c_driver(wacom_i2c_driver);
> --=20
> 2.38.1
>=20
>=20