Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9df48e3d-a4b3-58ef-ab2d-9c4ac931cee8@intel.com>
Date:   Fri, 18 Nov 2022 16:19:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.2
Subject: Re: [patch 21/33] genirq/msi: Provide msi_domain_alloc_irq_at()
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>, <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        "Marc Zyngier" <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Alex Williamson" <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>
References: <20221111133158.196269823@linutronix.de>
 <20221111135206.463650635@linutronix.de>
 <0cbf645b-b23a-6c85-4389-bb039a677a52@intel.com> <87k03tkrii.ffs@tglx>
 <87zgcok4i2.ffs@tglx> <87wn7sjzeq.ffs@tglx>
 <d33e63f0-a5ba-38d3-1cfb-dd5ab8d249b8@intel.com> <87y1s7j3o4.ffs@tglx>
 <36615cba-4429-a493-a533-d7dc0bc46056@intel.com>
In-Reply-To: <36615cba-4429-a493-a533-d7dc0bc46056@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnV5OUZHWWxKclpWZ1F0TDI3SmROQTRrT3ptTUhEYlFrcnZsOUJqUFEwaFRy?=
 =?utf-8?B?Ky9xRENHMEFHeVhqUTlCOHFGVkI3WlE5K0VGV0cyT2RZWnYvNEVqL0VYdjBN?=
 =?utf-8?B?N3VVb3J0b1ZMRk5RcmlNeFlxVWo5MU1JVGNvcGVWQ2lqTFZ5NXkvWmNFRlBH?=
 =?utf-8?B?OWlnZGZCZjExM0J6SVJUZzlKazBBaHNiK3VlNmNVNmtXOG5XeDhad1d1NG16?=
 =?utf-8?B?VkR5YzlNZGNMcVdPdDFySHVBSjh6WnFEZHplTVlteHpMSFpkWFljUkxZalRu?=
 =?utf-8?B?S2lyWnZ6VGN5MnI1clRyTmJ1M3d5N05jZTdndzZPVzd4a0svUjJTRm01TTEw?=
 =?utf-8?B?c2dLS0UySld2YnNrMGRDY0xaaXUrdG1vWmo4OUZMcWZVTVhiT3E2NVBWTWoz?=
 =?utf-8?B?dGltZ0x5ODU1dUFDRTlLRllKTk5SbXlFUGk1RTVjcFI3eDlOQmdwWW5kdmp1?=
 =?utf-8?B?aHVteUhVV09qREUyVXFLa09QUDJocUdyNS80ZDl2cnd2OW94Sk1OeHl2MTZB?=
 =?utf-8?B?WlVud3h1RmpvSWkvUnNvNTJMeUx4TU5Yb2wrRi9ZaDg5TG5UeVhyS2lNc2Zw?=
 =?utf-8?B?MVpkczVHU2IzKzZDdXlGUjg4bU5VSGw4WWtGMGJHelNwQm1NQ2lrSUVKOFNq?=
 =?utf-8?B?WVpIVmhyTWMrM3pwTWtia0VvUTdiWVIyQ0FUdWpMRy9LZk9Cek4xb1V4Z2Q2?=
 =?utf-8?B?akkxMVZPT0dCeUQyS0JUbm9MRWlhbzY0ODRqSVUrcTJ5aWRZdmtmcGZTMXpW?=
 =?utf-8?B?eUxFVFVhNjFyOThGeVBQWkpQYm1WMitqcFZtTklQVEpsa21UbkhnZExQcFpV?=
 =?utf-8?B?WlQzNmtCUmhBaTJ6WlFhWGxLR3I2NmY1Q0NJczRBaEMydytNbDk2YWJLdkkz?=
 =?utf-8?B?MmxSK2M5d0g4WnNXNTl0TjVPdXVLYkszSDZZSFlxWldHS1BpRDBHWXptdjdi?=
 =?utf-8?B?Mzlwa0Y5bXNHY2h3T0lOSWNuMXlua29pM1dNdHpXbUVxbnFPNXVxaFhxckdv?=
 =?utf-8?B?elk2MzJkZFRjb0V0RFE2aEtXSGxuMm1SM1QwdGF5dUI0Qk4rUzBFUEZqcG4r?=
 =?utf-8?B?S0Vkc1hEOTBFRzNNeW5SUXRYL3RueVBYY1hrMGVYbUhKQjRhb0c0R2V1M0xD?=
 =?utf-8?B?eUFqVjlvMk1FellvZk5lRFVrbXdkRm13dWRqQmQwZ2hIY1d3WVNvczdmVFpy?=
 =?utf-8?B?UC9QdGRuNi85R095NGg5UTFQN3pKTFZMMU00TTZBcnpqZ3RYQTJyUGtwTmJK?=
 =?utf-8?B?ck9pblNwZWFEd2k4Y2ZISVFlRW9XNlFHMDF3bkJiZ2pvZXRiRW1JZHJBMDZV?=
 =?utf-8?B?SXZDUGhvdlZOSkFtNUV3UERZMXBxNTJ1clZRUG9WQWhZSzZHclRoVm8wNHBX?=
 =?utf-8?B?WTE3dWMyZ2M4Q0tUM0tEK1lsUTYzWWdrTGxzUWRMYkhIcjdBZUNWRmlhVVNT?=
 =?utf-8?B?OG1Sc1ZrSE1LZ3Z5VGwxdzB5UGxGTXBGS1lFZlhJZXkrK1dza1NCSnBSRktw?=
 =?utf-8?B?eXhZSmdXbVhxNm9OajNqSFAvUHhwaXZNNnFtYS8rR0JNVHhnTVlMUmcyaTlq?=
 =?utf-8?B?UUY1TGlLSUFCSXBBVFJJOGFkUDIrdXV0ZnU2Z2svOGpRaGlGNWd5UnNrRDlm?=
 =?utf-8?B?V25mdXpHM0dCQ1ZHMGNOcmVpMjlrd0JKTTVIbEVlU05EWnpKVnlxaG1Balh4?=
 =?utf-8?B?a3dKSlM5eG5TSHVZUTkxTHRUSHJoemZ1NERjVDJXVk5COVBZOXBKakhSRWE5?=
 =?utf-8?B?TUhvbHlTTFZFaGN3WnEzZCtoVmN5N3ZSSU1sWmZxdGh2RHVOdktXRTYyYm56?=
 =?utf-8?B?c2F5YXdXQ1NUTzVtYkpkbmRkdmczSVdVQWJCY3pYbzlnUi9SME9sQUZxWm4r?=
 =?utf-8?B?TFA2dzhyM2ppQXZNUHdrT2VlbWxCSVNvYTFYbXY0VStCNWRkTWdCT2lIOXB6?=
 =?utf-8?B?NVI1TEpiNGI0ZGNVYTArNElUb2VPcWRwSnRoRGlVVThHbkVMNEVQUjhTNW8r?=
 =?utf-8?B?ckw0ei9YUzVWbFF3UkdheHFoNjZ3bVNzejhVRjd2Tkc1TWlHN0RvSTV2dEZs?=
 =?utf-8?B?R3Z0R2lSUzlBczVXODJldm5hMWxqZm1ubVgwNW15QTFwRDNaSVJqbTJLOWMv?=
 =?utf-8?B?YTB0cyswME9zY3gxNUtUbVEyMlI0V01rNXVmS3MyNDdKTVdKN2wrL212U0Fv?=
 =?utf-8?B?UUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a37e0de4-21c9-48c7-b631-08dac9c3b29a
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 00:19:19.2384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jwC9YNy54XSWtvMn37i0/31geYKsb5Dr80R/5Ix+DO8kT7Opdh9CITeg9i2PtCRAoSDuWdF2BQ6l0TKE7HlIazslXqTimI5LMXpvHeif/jk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4698
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thomas,

On 11/18/2022 2:59 PM, Reinette Chatre wrote:
> On 11/18/2022 2:31 PM, Thomas Gleixner wrote:
>> On Fri, Nov 18 2022 at 10:18, Reinette Chatre wrote:
>>>> @@ -141,7 +141,7 @@ static int msi_insert_desc(struct device *dev, struct msi_desc *desc,
>>>>  		if (ret)
>>>>  			goto fail;
>>>>  
>>>> -		desc->msi_index = index;
>>>> +		desc->msi_index = index - baseidx;
>>>
>>> Could msi_desc->msi_index be made bigger? The hardware I am testing
>>> on claims to support more IMS entries than what the u16 can
>>> accommodate.
>>
>> Sure that's trivial. How big does it claim it is?
> 
> 2048

Dave Jiang corrected me ... the max the hardware can support
is 16128 so the current size of msi_index is sufficient.

Reinette