Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934031AbXHJCBz (ORCPT ); Thu, 9 Aug 2007 22:01:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758689AbXHJCBo (ORCPT ); Thu, 9 Aug 2007 22:01:44 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:40369 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759221AbXHJCBn (ORCPT ); Thu, 9 Aug 2007 22:01:43 -0400 Date: Thu, 9 Aug 2007 19:01:41 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Daniel Phillips cc: Andrew Morton , Matt Mackall , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Pekka Enberg Subject: Re: [PATCH 04/10] mm: slub: add knowledge of reserve pages In-Reply-To: <4a5909270708091854n7c84ae9aj84170092a5eb61db@mail.gmail.com> Message-ID: References: <20070806102922.907530000@chello.nl> <20070806103658.603735000@chello.nl> <20070808014435.GG30556@waste.org> <20070808114636.7c6f26ab.akpm@linux-foundation.org> <4a5909270708091854n7c84ae9aj84170092a5eb61db@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1891 Lines: 40 On Thu, 9 Aug 2007, Daniel Phillips wrote: > No matter how you look at this problem, you still need to have _some_ > sort of reserve, and limit access to it. We extend existing methods, The reserve is in the memory in the zone and reclaim can guarantee that there are a sufficient number of easily reclaimable pages in it. > you are proposing to what seems like an entirely new reserve The reserve always has been managed by per zone counters. Nothing new there. > management system. Great idea, maybe, but it does not solve the > deadlocks. You still need some organized way of being sure that your > reserve is as big as you need (hopefully not an awful lot bigger) and > you still have to make sure that nobody dips into that reserve further > than they are allowed to. Nope there is no need to have additional reserves. You delay the writeout until you are finished with reclaim. Then you do the writeout. During writeout reclaim may be called as needed. After the writeout is complete then you recheck the vm counters again to be sure that dirty ratio / easily reclaimable ratio and mem low / high boundaries are still okay. If not go back to reclaim. > So translation: reclaim from "easily freeable" lists is an > optimization, maybe a great one. Probably great. Reclaim from atomic > context is also a great idea, probably. But you are talking about a > whole nuther patch set. Neither of those are in themselves a fix for > these deadlocks. Yes they are a much better fix and may allow code cleanup by getting rid of checks for PF_MEMALLOC. They integrate in a straightforward way into the existing reclaim methods. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/