Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a521db6342b977805d7161406f86d44fea7ba55.camel@kernel.org>
Subject: Re: [PATCH] Add process name to locks warning
From:   Jeff Layton <jlayton@kernel.org>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     chuck.lever@oracle.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 18 Nov 2022 21:06:03 -0500
In-Reply-To: <20221118234357.243926-1-ak@linux.intel.com>
References: <20221118234357.243926-1-ak@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-11-18 at 15:43 -0800, Andi Kleen wrote:
> It's fairly useless to complain about using an obsolete feature without
> telling the user which process used it. My Fedora desktop randomly drops
> this message, but I would really need this patch to figure out what
> triggers is.
>=20

Interesting. The only program I know of that tried to use these was
samba, but we patched that out a few years ago (about the time this
patch went in). Are you running an older version of samba?

> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  fs/locks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/locks.c b/fs/locks.c
> index 607f94a0e789..2e45232dbeb1 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -2096,7 +2096,7 @@ SYSCALL_DEFINE2(flock, unsigned int, fd, unsigned i=
nt, cmd)
>  	 * throw a warning to let people know that they don't actually work.
>  	 */
>  	if (cmd & LOCK_MAND) {
> -		pr_warn_once("Attempt to set a LOCK_MAND lock via flock(2). This suppo=
rt has been removed and the request ignored.\n");
> +		pr_warn_once("%s: Attempt to set a LOCK_MAND lock via flock(2). This s=
upport has been removed and the request ignored.\n", current->comm);
>  		return 0;
>  	}
> =20

Looks reasonable. Would it help to print the pid or tgid as well?=20
--=20
Jeff Layton <jlayton@kernel.org>