Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7de35859-97ab-8e88-f590-d5851b81773b@nvidia.com>
Date:   Fri, 18 Nov 2022 18:33:30 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.0
Subject: Re: Intel timed i/o driver in HTE
Content-Language: en-US
To:     "N, Pandith" <pandith.n@intel.com>, linus.walleij@linaro.org
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hall, Christopher S" <christopher.s.hall@intel.com>,
        "Gross, Mark" <mark.gross@intel.com>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@intel.com>,
        "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>,
        "T R, Thejesh Reddy" <thejesh.reddy.t.r@intel.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>, timestamp@lists.linux.dev,
        dipenp@nvidia.com
References: <BYAPR11MB3240F382BD180FF90C7DF0B9E1069@BYAPR11MB3240.namprd11.prod.outlook.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <BYAPR11MB3240F382BD180FF90C7DF0B9E1069@BYAPR11MB3240.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWxxTnB1SUV1azdOckEyb3F1aTc2aUJxeVBITHpFZGxFcW4vdFB0RWNuVjJR?=
 =?utf-8?B?ZUozd2hveElhNEc5Y3B6STVzVVd0ZFdRU1NSTkZTRWhRMVBxa0xUNDdFRk1V?=
 =?utf-8?B?cGpjYjNXcmpMeXdWWUoxcGJrcWtvb3k5RnZXY2ZzRDZ2cXc5VmhJOEJxVzZR?=
 =?utf-8?B?UGJ3M2p2V0FuVjVRZDIwVkp2bFVGRS9LNEs5SmMxb2s2S3ZSMHp0Yk41bXRz?=
 =?utf-8?B?NnJRODVJaWNPaEpvV25kKzdSMld3SERNMnhCcDZGbytkS3BXRTd5RERDeTV3?=
 =?utf-8?B?bDJ5QjZmdTVpanlvQThkaFBvUmxsRjRzQkk5NHNBd3BkVFF2RlNCNEE2MVpm?=
 =?utf-8?B?eEdVbVpoYUNCenZMMHRJTWU0d0kveHJZR2JYVzZxWmNPbWdILzd4RFlmcWU2?=
 =?utf-8?B?NWROQ2EzOHN3SkM1WXdsZ3lvVVp1YTBYWklJZml0eWtoZ2dDRU4vcUJ5NEcr?=
 =?utf-8?B?T0lWM205UWRnMnhISDFsODc4bzZwWjJsZmdtUzVremdYeHBxN045MElmUFA1?=
 =?utf-8?B?RmRNa3lEeEtUUDVRRXFlTWo5T2ZmTzJlSGd1K0JZRi9GbWdVZWFOdENYM2FV?=
 =?utf-8?B?V1hTTjNLOG1oTDZ6c3F2UnlNeFNhYlRzOXFia25qS0tIaWluc1c5ZjBGTDVo?=
 =?utf-8?B?U1FDNEdXU3VWQVFtc0JzY29iOE9wWXJrc3dFeUs0Ny93UzBEaERncmpldkVT?=
 =?utf-8?B?bFk2MUxWdHBoeVM3VFN1Q0hzdTUvUWlGdjE4TkZJNW9rZmE2YTR2Y0E3RE1L?=
 =?utf-8?B?aGI0SzFpR1QzNVlpZmxhVjFLNWIzVUJpTG1OOTVicVY2c1pLWENpS1ZPR21t?=
 =?utf-8?B?MWRHK0c3bGRETzdlZVliblppbVFlZ2d1S29vZzhuWHFXT1J3a0dPekZ4WUQy?=
 =?utf-8?B?K05MNWdqQ2FsQ1I1N3dKSVQ0RzFDNHREV0xsTlRHejZJRjU2TkxBdGorRCsr?=
 =?utf-8?B?N21zb2FXU0lvK3NudFNycVZKT1ZIUHJ1SjVBQ3RqVjlEVlMvT0kyUDBFdmp4?=
 =?utf-8?B?azBXZ3pGUkdLcFF3YTloV1kvRURXUzg5ZDgrbWRsMEtxT3loaFVLeGt4Skt3?=
 =?utf-8?B?RWU1b1F4Y0lnbzNDWFJNZFdrY2creEFXRUJMMlh5TjJueWs2SkUxOWdSVUNY?=
 =?utf-8?B?Zm1vZVhmUTlucmtzaWJEYkdvUWp5bkdMK2o4OC9yanpiTmlFSjlvY2NWSGEy?=
 =?utf-8?B?eHVNRDVFTmVXMS9IM2VVMVlFdERobUtvWWt5OGNVVXIreUR3WWphOEdzME03?=
 =?utf-8?B?QURBNmpzRzA2dXNCTkN3cGdFTEc5Y0RNQ3NBTGtpVVlsUDkwUjhZcTdnRG5i?=
 =?utf-8?B?VkJyanptUFJQd1RuTkFESWtpTmJ2cFEyQS9Fdndwbk9ISGdFZjMydlF5bi9G?=
 =?utf-8?B?WDhGa2tPNlJmNzFGVksyNWpDODdRT0lMZmF3cFBoRk9hUDJyNVl1bmhoOFU3?=
 =?utf-8?B?RkRjUjVScldjTHlZdDFHRmYwYWlzVEQweWhYaml0U1FHY0NNK2lDWTBoR2RZ?=
 =?utf-8?B?cE5WZ3lwYXZxTjJSUVd0OTFZNTRUTVU4SVA4WmxYV3g3Yy95YXhXUHVoeTNH?=
 =?utf-8?B?VTZZTGlKaUxVOEQ4cldvdTVPVDNzOGVybWh5V2JRQzJQckZ0alBVM29TZktK?=
 =?utf-8?B?d3Bza1hNeTQydkRwRVVnZ0RtLzI2dE5kTEx3V1RpQy8wcFdjUlZRSTBSZWZD?=
 =?utf-8?B?UXZ6NEFZL2lXLzhtOVUyMWNmQ01Vc0ViajZLSGYrejdtRmNuN2tsNXY5VWZy?=
 =?utf-8?B?K0IzdHhCWTg0YlEyVkZMMlpxbG1ZZDRuaDczMXZlN2FlQmEra0Y1bGFyZ3NL?=
 =?utf-8?B?U0JhSDFxcVRXS2R1aWo4eThiMFFKdFA1NVkrQXBSN29VSG1FZGRuWUY5WWlI?=
 =?utf-8?B?d1RFTXMyaVhTUm5XZ2w1aDdXMG9LeW5SbGhyMWd3L0hRZFBSZWlNbGk4TzY5?=
 =?utf-8?B?ZTF5eWVGdjNFMzlBUUcrQ2pGQXRsWWVIVjBxbHVpdkVFZ1JHOEVlQ3daelh3?=
 =?utf-8?B?dDVrTm5oK3k4UjViZEdLU0NGbWJCVGpYQklZVDRTQWdWVGZPQ3Fid1V2alBi?=
 =?utf-8?B?ckd1OFJMZFFPMzU0UlZGdU0wSEIyeHMwUWhLRnhIUUV4MGE3WVFOeElUcmtL?=
 =?utf-8?Q?a3MciAMqBYdpf+SRa9t0Fy1+e?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a765d5a2-fffa-4b65-f0bc-08dac9d6756a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 02:33:35.8504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6beDXYv/jT/5dO5JnVZ7hdLlAltGer6fE6Wh2pqrb7v5K27B+EUyu6YyKDCoH49ucr1l0VigPD2YwNi/GmEqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7317
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/17/22 10:47 AM, N, Pandith wrote:
> Hi Dipen,
> 
> To support Intel timed i/o driver, it was suggested by Linux community to enhance hte framework.
> However, we see some limitations to support complete Intel timed i/o device.
> 
> 1. The current framework supports Nvidia IP, which has two IP blocks (hw timestamping engine interfaced with GPIO)
> Intel timed i/o is a single IP block handling multiple functionalities like:
> 
> 	a. Input timestamping with event counter.
> 	b. Timed output  - single shot or periodic pulse train.
> 	Uses TSC(Timestamp counter) for timestamp or generate events, which could be translated to system time.
> 	c. Implement PPS functionality to export time.
Isn't 1c similar to 1b, where IO (mostly GPIO) is programmed to toggle/periodic pulse train at 1s.
> 
> This requires new functionality(interface) to be developed in hte framework specific to timed-io device.
I can see 1a is straight case for the HTE.

For 1b, the timestamp part can be added as hte provider. I see opportunity to enhance hte framework to provide
translation facility between the domain, system time in this case. However programming interface to facilitate
timed IO output can not fit into HTE the way it is right now. May be one possible way is to enchance HTE with API something like
hte_configure_timestamp_periodic/timed could be possible in which case HTE does something more than just timestamping the event.

I have to see how in GPIO case that proposed API works out, if it will bypass gpio framework etc...

Adding Linus W into the discussion....

> 
> 2. The current hte framework has a provider and consumer concept.
> Consumer is responsible for user space interaction.
> Currently Nvidia is using GPIO for input timestamping  (by adding hw timestamps in gpiolib-cdev.c)
> 
> For Intel timed i/o functionalities, current gpio user interfaces cannot support event counter
> or output modes.
Can you elaborate on event counter and output mode?

> Rather than jigging hte consumer into other subsystems to support timed i/o device. 
> Any possibility of developing a native consumer in hte subsystem, which could handle user space interactions for timestamping engines.
yes, feel free to send patches to me and cc timestamp@lists.linux.dev, I guess you can register your IP as one of the provider.

To explain why GPIO was treated specially, there was already a
user facing framework i,e gpio-cdev and range of userspace tools which could be leveraged for the HTE GPIO consumers. However this does
not prevent kernel space GPIO HTE consumer from using HTE core directly.
 
> 
> I cannot think of an existing subsystem that handles Intel timed i/o functionalities 1a, 1b and 1c (mentioned above).
> 
> Regards,
> Pandith
> 
> 
> 
> 
Best Regards,
Dipen Patel