Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933550AbXHJCib (ORCPT ); Thu, 9 Aug 2007 22:38:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754187AbXHJCiW (ORCPT ); Thu, 9 Aug 2007 22:38:22 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:46519 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbXHJCiW convert rfc822-to-8bit (ORCPT ); Thu, 9 Aug 2007 22:38:22 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: YOSHIFUJI Hideaki / =?euc-jp?B?tcjGo7HRzMA=?= Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, devel@openvz.org, adobriyan@sw.ru Subject: Re: [PATCH 3/3] sysctl: Error on bad sysctl tables References: <20070810.110144.117508471.yoshfuji@linux-ipv6.org> Date: Thu, 09 Aug 2007 20:18:53 -0600 In-Reply-To: <20070810.110144.117508471.yoshfuji@linux-ipv6.org> (YOSHIFUJI Hideaki's message of "Fri, 10 Aug 2007 11:01:44 +0900 (JST)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=euc-jp Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 31 YOSHIFUJI Hideaki / ??ƣ???? writes: > Hello. > > In article (at Thu, 09 Aug 2007 > 14:09:29 -0600), ebiederm@xmission.com (Eric W. Biederman) says: > >> After going through the kernels sysctl tables several times it has >> become clear that code review and testing is just not effective in >> prevent problematic sysctl tables from being used in the stable >> kernel. I certainly can't seem to fix the problems as fast as >> they are introduced. > : >> The biggest part of the code is the table of valid binary sysctl >> entries, but since we have frozen our set of binary sysctls this table >> should not need to change, and it makes it much easier to detect >> when someone unintentionally adds a new binary sysctl value. > > I don't think everyone needs to have this code, so > it is better to make it configurable via > CONFIG_SYSCTL_DEBUG or something..., ...no? I guess the other thing is. Except for code size it doesn't matter. As register_sysctl_table gets called very rarely. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/