Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com>
Date:   Sat, 19 Nov 2022 13:21:03 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined
To:     <richard@nod.at>, <s.hauer@pengutronix.de>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <weiyongjun1@huawei.com>, <yusongping@huawei.com>
References: <20221115083335.21211-1-hucool.lihua@huawei.com>
From:   "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
In-Reply-To: <20221115083335.21211-1-hucool.lihua@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

ping

在 2022/11/15 16:33, Li Hua 写道:
> When CONFIG_UBIFS_FS is enable but CONFIG_UBIFS_FS_AUTHENTICATION is not set:
>      ERROR: modpost: "ubifs_bad_hash" [fs/ubifs/ubifs.ko] undefined!
> 
> Fixes: 16a26b20d2af ("ubifs: authentication: Add hashes to index nodes")
> Signed-off-by: Li Hua <hucool.lihua@huawei.com>
> ---
>   fs/ubifs/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
> index 45d3d207fb99..93bda1057fdc 100644
> --- a/fs/ubifs/Kconfig
> +++ b/fs/ubifs/Kconfig
> @@ -13,6 +13,7 @@ config UBIFS_FS
>   	select CRYPTO_HASH_INFO
>   	select UBIFS_FS_XATTR if FS_ENCRYPTION
>   	select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> +	select UBIFS_FS_AUTHENTICATION
>   	depends on MTD_UBI
>   	help
>   	  UBIFS is a file system for flash devices which works on top of UBI.
> @@ -91,6 +92,7 @@ config UBIFS_FS_AUTHENTICATION
>   	select KEYS
>   	select CRYPTO_HMAC
>   	select SYSTEM_DATA_VERIFICATION
> +	select SYSTEM_TRUSTED_KEYRING
>   	help
>   	  Enable authentication support for UBIFS. This feature offers protection
>   	  against offline changes for both data and metadata of the filesystem.
>