Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1576330rwb; Fri, 18 Nov 2022 22:51:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf6C8ecLc5UvgI1c4gNUWWbA3nSfESS5eZx1okEF5btidv0nDq9J0q2K2skuRb81P2zNkjDl X-Received: by 2002:a17:902:7683:b0:186:9fc8:6672 with SMTP id m3-20020a170902768300b001869fc86672mr2827117pll.65.1668840688339; Fri, 18 Nov 2022 22:51:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668840688; cv=none; d=google.com; s=arc-20160816; b=MoYWDuEoJAEYEj1WOwr8C7Prr7jIRhsExru8rTU5c8KreeMRE3OPGzZBT2rQrpPHv2 XVKii3TdSQ1C5NqmYussJrSNfrA5gK0HhMtW6J/EYjd8BJ8S/8ZvsIvfwdGFPPh7fbLI WDFS9LzfA+WEX8d6I+HyoOc/gPbVTKWZBk+wYlg0wblJ+Itpf6L9xZUsv56GSHt8xGfr wmGRoiE5mHjzVpaOX/mA2GRnr01PexUlb/KTs37MyKnjWiiC7aEHMXCjGYeWlzKm0K7Y GD4uipHLIlMnwk4Ypq1vc1gwdGsWsECabuPh0c+qzaLucHxrAOtq5JSMpcq4ns3SDioS mv+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pLHmdx/s2bNzJOCPIe1oF09TPacI4B0ijrv0wl6UcQY=; b=pru6TKaY7Bw0stVQucuR29e6x4cmjOzF2EiwUivQQil1RptDVrw88y1GYK4QOE1nVx xk3wXmbbUlRjqmlrRxRTRcaGoiUQ+AQTH78CHvynsYsGMkrbI8rohd5IwqMQZGyhIiGo Yz3D9uE7d9jyaNeIWVm+lrWdkzHrBfalFGi+1DPKQkIoBA5A48tKT0f2FaEotmxxIDlg Jbby+TyNtoCQWNNdLkRzQQs6lNHiTU04TwL++g+2MYOcpSvA0ZakOCWLzUpF8OdBuveq O5DZ6yOskTjRucHMF9Dprw1/f6GsRrBkGM+cZXh7caQ3huBxEbpICkSsmTm1K/UvWWse wSyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h20-20020a633854000000b0045fb345cfedsi5783108pgn.640.2022.11.18.22.51.15; Fri, 18 Nov 2022 22:51:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232171AbiKSGoN (ORCPT + 90 others); Sat, 19 Nov 2022 01:44:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbiKSGoJ (ORCPT ); Sat, 19 Nov 2022 01:44:09 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A477E7C; Fri, 18 Nov 2022 22:44:07 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NDkYC0qlLzqSYH; Sat, 19 Nov 2022 14:40:15 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 14:44:06 +0800 Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 14:44:05 +0800 From: Zhen Lei To: Chris Mason , Josef Bacik , David Sterba , , CC: Zhen Lei Subject: [PATCH] btrfs: fix a resource leak in btrfs_init_sysfs() Date: Sat, 19 Nov 2022 14:43:48 +0800 Message-ID: <20221119064348.1743-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When btrfs_debug_feature_attr_group fails to be created, btrfs_feature_attr_group is not removed. Signed-off-by: Zhen Lei --- fs/btrfs/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 699b54b3acaae0b..947125f2ceaaf96 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -2322,7 +2322,7 @@ int __init btrfs_init_sysfs(void) #ifdef CONFIG_BTRFS_DEBUG ret = sysfs_create_group(&btrfs_kset->kobj, &btrfs_debug_feature_attr_group); if (ret) - goto out2; + goto out_remove_group; #endif return 0; -- 2.25.1