Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-359-uwe@kleine-koenig.org>
In-Reply-To: <20221118224540.619276-359-uwe@kleine-koenig.org>
From:   Janusz Krzysztofik <jmkrzyszt@gmail.com>
Date:   Sat, 19 Nov 2022 08:00:34 +0100
Message-ID: <CAGfqbt6HG88psov6CE2PqNn1YOdrc=TfYXHw8BgqrLbUc1MJRA@mail.gmail.com>
Subject: Re: [PATCH 358/606] media: i2c/ov6650: Convert to i2c's .probe_new()
To:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <uwe@kleine-koenig.org>
Cc:     linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Dnia pi=C4=85tek, 18 listopada 2022 23:41:32 CET Uwe Kleine-K=C3=B6nig pisz=
e:
> From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so i=
t
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

LGTM

Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>


> ---
>  drivers/media/i2c/ov6650.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
> index 18f041e985b7..4c0ea2ae671b 100644
> --- a/drivers/media/i2c/ov6650.c
> +++ b/drivers/media/i2c/ov6650.c
> @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650=
_internal_ops =3D {
>  /*
>   * i2c_driver function
>   */
> -static int ov6650_probe(struct i2c_client *client,
> -                     const struct i2c_device_id *did)
> +static int ov6650_probe(struct i2c_client *client)
>  {
>       struct ov6650 *priv;
>       int ret;
> @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver =3D {
>       .driver =3D {
>               .name =3D "ov6650",
>       },
> -     .probe    =3D ov6650_probe,
> +     .probe_new =3D ov6650_probe,
>       .remove   =3D ov6650_remove,
>       .id_table =3D ov6650_id,
>  };
>