Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1704558rwb; Sat, 19 Nov 2022 01:49:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4952lJ3TROusde2Q/FL7b6AbsZ44+84ULeEPARYiXU1QwzUX+ajDI5Jp9lv8bIrp4ro9hM X-Received: by 2002:a17:903:130c:b0:186:85c3:98af with SMTP id iy12-20020a170903130c00b0018685c398afmr3328607plb.101.1668851389904; Sat, 19 Nov 2022 01:49:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668851389; cv=none; d=google.com; s=arc-20160816; b=Hw2LBLyTMaMCBRvAbVa20S2L3sgkhpA/U//BPPSDKmS7ztzR4xCairWpaGzYzlmvQC rKJfu9VaLwd6097Xmu+43Vy4WnybVFMeDWQ0t/lbHeybRt1e1JleDsrZS7o908g0lToe sCGmsEVMI5Diq4xToamAVWS8FkUAUKhRUyIMlT3e9CPNQdPZLFxnpiuvLAc1Ps1TAAlT bQ2xLj66Sl0STwwFruOI33F23czYd/m5LpRmTB65owjtJ5zLdho2ChcEVaUbz7uLg+eL tG5EW6qnZpFhYmfrEL/LWFWhWlJXkRZqWPB2GMeScMfKL/ye/hCeZrn3VAuEkrGUg9vI r8HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Qvgl+kT/HrVkZ7hfT+bPqb6eQdVjehMSWm5iMRWOcyQ=; b=xXvGPva5Bkq9OW9PsnRxRovS9hlL6rjehB5dLvyW8t7LwyKuiXFWTva9ewvCnaeRjn 2bkdHcKUm7Q+MxozKteWzD+dlwY89ldEo2UJFGRGVp3mz2YXp21stsevMUR+ZwouboHt MQpvcl+zNXHLgmMocrm69upt4H7Q1z57z6gcxFcOZ7A0MnvgU8OFbMP5RSljCE/EIGZz AC1dE4nDdau8jz2gryAnYdqGyhyut9+74sv344gF2n4rORBI568sEKseJmOA8ZPI78a+ 5LzD0hjsAjeLxPGkrXQVSr3aD8wEJIZELusKzDJqLYBakdxiMlyZGtSYzmFrLerGncQZ QpBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm18-20020a656e92000000b0047699804989si6008796pgb.64.2022.11.19.01.49.38; Sat, 19 Nov 2022 01:49:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbiKSJU0 (ORCPT + 90 others); Sat, 19 Nov 2022 04:20:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiKSJUZ (ORCPT ); Sat, 19 Nov 2022 04:20:25 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EBDC74602; Sat, 19 Nov 2022 01:20:24 -0800 (PST) Received: from canpemm500006.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NDp5S53hXzmVt9; Sat, 19 Nov 2022 17:19:56 +0800 (CST) Received: from [10.174.179.200] (10.174.179.200) by canpemm500006.china.huawei.com (7.192.105.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 17:20:22 +0800 Subject: Re: [PATCH net] wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx() To: Kalle Valo CC: , , , , , , , References: <20221119051900.1192401-1-william.xuanziyang@huawei.com> <87v8nbphrr.fsf@kernel.org> From: "Ziyang Xuan (William)" Message-ID: <215ec3cc-88ad-3f68-6dc3-c1aed2a17c76@huawei.com> Date: Sat, 19 Nov 2022 17:20:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87v8nbphrr.fsf@kernel.org> Content-Type: text/plain; charset="gbk" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.200] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500006.china.huawei.com (7.192.105.130) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ziyang Xuan writes: > >> urbs does not be freed in exception paths in __lf_x_usb_enable_rx(). >> That will trigger memory leak. To fix it, add kfree() for urbs within >> "error" label. Compile tested only. >> >> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices") >> Signed-off-by: Ziyang Xuan >> --- >> drivers/net/wireless/purelifi/plfxlc/usb.c | 1 + >> 1 file changed, 1 insertion(+) > > plfxlc patches go to wireless tree, not net. But I think I'll take this > to wireless-next actually. OK, thanks. >