Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bce610de-60a5-2c00-0231-e5891c480ccf@infradead.org>
Date:   Sat, 19 Nov 2022 09:14:15 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] octeontx2-pf: Remove duplicate MACSEC setting
Content-Language: en-US
To:     Zheng Bin <zhengbin13@huawei.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     zhangqilong3@huawei.com
References: <20221119133616.3583538-1-zhengbin13@huawei.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20221119133616.3583538-1-zhengbin13@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/19/22 05:36, Zheng Bin wrote:
> Commit 4581dd480c9e ("net: octeontx2-pf: mcs: consider MACSEC setting")
> has already added "depends on MACSEC || !MACSEC", so remove it.
> 
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> ---
>  drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/Kconfig b/drivers/net/ethernet/marvell/octeontx2/Kconfig
> index 6b4f640163f7..993ac180a5db 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/Kconfig
> +++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig
> @@ -32,7 +32,6 @@ config OCTEONTX2_PF
>  	tristate "Marvell OcteonTX2 NIC Physical Function driver"
>  	select OCTEONTX2_MBOX
>  	select NET_DEVLINK
> -	depends on MACSEC || !MACSEC
>  	depends on (64BIT && COMPILE_TEST) || ARM64
>  	select DIMLIB
>  	depends on PCI
> --
> 2.31.1
> 

-- 
~Randy