Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2183900rwb; Sat, 19 Nov 2022 10:27:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf57WOCKP87cBKLKGInRpgatPdt7JrGw91m9npUXdptgEsZbKf1TGLkHyOmCTSveCRx8g9zj X-Received: by 2002:a05:6a00:410b:b0:56d:91d1:a903 with SMTP id bu11-20020a056a00410b00b0056d91d1a903mr1319010pfb.61.1668882435597; Sat, 19 Nov 2022 10:27:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668882435; cv=none; d=google.com; s=arc-20160816; b=IKwo1sxSpA50lSvsY8Pf0wLAX6kZ0PLxGWxxXx67tj0/d9xYDZUpoBOoCfpZ/z9+vy Lqa2F9e+Gq9LnTXkhuFFMBNsVEogKZA4KLEKu+lJGF7R14CLzt9/WeclipSnykJ4Edbi W8qFK658KqHdjS3QisR4+4rhGE7L/Tu27owZSi7ubqpwgF5YgBFbaoGtVOv2Jl3cfTno RBy4JlsJC9mQmdStu3XwlliBgmurDfCA739VkpFM4W/I5d9PfyW0iYvRvMgVFGCLMNXY OmFj7ghrbBhk9sA4RtSA7TRY9UrIciGXhTf9oVLNaFfaUC5k6srMot5NM/Yaa+q57Vd3 sddg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+YbUqbxm4ze3nnh2C59BLtHxgdcbKQGzkGPiuA5jikk=; b=xjBmhhyRKVdcc3H5rVM6gR/GEdiKSQ5sldmzp02OQaucwBkY02gmNbrUeQ5vhuxkuq OWFVjxJvNp6oG6tfFd7gK8bZmSkvOhAUaRggZeNpoYEeGeePsGaTY8nWNF/PxrI+xSDR tiurwO5K3P0xUfTWn0flw9nmJYYMzaWumqJ9YO0bi4b43izAqHDgkb6OsZbcx3MlLgJI 7mEQayRaOk1NVven5zItiypdHnzp15NvNMTjvYv1o/fQxjYqnpLscyXfUxZOTE/7fcr8 1PcfxMoopQyldNiSsZAKoMZUVCWVuDoNsbT2e9+ktmJuPzKtoyBHAfTx1BJHfgxbBuN1 PVig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=rrEiHpwK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o123-20020a62cd81000000b0056bfd285876si6549205pfg.84.2022.11.19.10.27.04; Sat, 19 Nov 2022 10:27:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=rrEiHpwK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234411AbiKSRal (ORCPT + 90 others); Sat, 19 Nov 2022 12:30:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234320AbiKSRai (ORCPT ); Sat, 19 Nov 2022 12:30:38 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 071A61179; Sat, 19 Nov 2022 09:30:37 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E938749; Sat, 19 Nov 2022 18:30:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879035; bh=o9lUHRbGBJ0hhJHW6kYdWTu2wvJ8H+zsns7IATdHrbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rrEiHpwKhllKXjddcBxHOnbfouXahjh8kHM9Y+KBoChKcIJIGdcds5ltGgJsT70xQ ngASIOg81jJgPbfCgGtqvD3+AJfW1RWt+B4EFPM4Ps0sJ41bqhG/knvEoyBAxX1ron um213vJD5vIKI8cw2LXfb9pBRSe7Sdj4BRr7FJwQ= Date: Sat, 19 Nov 2022 19:30:19 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 031/606] drm/bridge: sii8620: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-32-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-32-uwe@kleine-koenig.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:05PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/sil-sii8620.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > index 511982a1cedb..b96d03cd878d 100644 > --- a/drivers/gpu/drm/bridge/sil-sii8620.c > +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > @@ -2284,8 +2284,7 @@ static const struct drm_bridge_funcs sii8620_bridge_funcs = { > .mode_valid = sii8620_mode_valid, > }; > > -static int sii8620_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int sii8620_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct sii8620 *ctx; > @@ -2379,7 +2378,7 @@ static struct i2c_driver sii8620_driver = { > .name = "sii8620", > .of_match_table = of_match_ptr(sii8620_dt_match), > }, > - .probe = sii8620_probe, > + .probe_new = sii8620_probe, > .remove = sii8620_remove, > .id_table = sii8620_id, > }; > -- > 2.38.1 > -- Regards, Laurent Pinchart