Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2184669rwb; Sat, 19 Nov 2022 10:28:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7f6Q765WAjfJekV3xa674bqm2jPN9YlkT4huhCxuXvkL4/ppVPa4fe7zKMUkY5yzgP2bzF X-Received: by 2002:a65:681a:0:b0:462:6197:caa2 with SMTP id l26-20020a65681a000000b004626197caa2mr11159900pgt.223.1668882498759; Sat, 19 Nov 2022 10:28:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668882498; cv=none; d=google.com; s=arc-20160816; b=viBGXpm008ztwj3sQozdgdkIK3AlA4IsZBoguNnaHBoJrICB+dshC5F3RAENUSRAVa 9Q9zOJ/JSHLojIqqriFfqIo7jmzGd7vQPUWLGEq3lCsELHntV5IprCjI6AlRBRRDFGPT OT1UJMYNO2io0y+gcdX9m/CF2xmjl0mSvwPxBUxuoY30gD7dC6hCquGclyZkLaHTvEE8 JwzIHZJxpt3DZS1c7hnIjfdKqWj5lq4G67fz+qanecRziyRJKUzjfyBSbypB7flJKOq+ wjjxzM9dWP9j0k7A8psA8qCW3VjjI0WLluPQmwKK7FpQPBjBR/FeVkVDyABWW4QOE0Bd rXcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TECWTEnY6N2cRniDuV5elXskWGjH99Z+QZo8jzIqacY=; b=iqAEO0fPL4vRP3lJi8H4H8paVrqFdeU042lJ3gyvNUfKkacybhVnqgXRzk2PeyzaQy 8YKA7f8KVf9R8Q2kTdqM5m6VILMs8lzcp56OtxGMYhvFPghF94XNzlMNj8bQ9oCBnQNx qF1lwj4qSwNYvY7Vs2i2CHQB0NoxGSkBsDnmhS9UbiHaUXq+RjX/fiZFa3Z15IIhfiXR H32KEehicwRjDTXVlF3q6dcvXY66Bu5L2rQkmQKw0ewjAvC0eAd2C6pcXHc54OmGbLma /PoQxdny33RH9SaWsjByQQ+pzE3CiAqxoAty70aQHp2e8cET/yQ1wc7Eqpsk8Gazf/CI cyIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=SfeAl0PW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g63-20020a625242000000b0056e41e4272dsi6102974pfb.315.2022.11.19.10.28.07; Sat, 19 Nov 2022 10:28:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=SfeAl0PW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234951AbiKSRji (ORCPT + 90 others); Sat, 19 Nov 2022 12:39:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234723AbiKSRjg (ORCPT ); Sat, 19 Nov 2022 12:39:36 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D9791902F; Sat, 19 Nov 2022 09:39:35 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 61D05749; Sat, 19 Nov 2022 18:39:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879573; bh=KLORL0n/eeuSzLDMfgx0jgrjdSgC3DFFC/4yiTROnhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SfeAl0PWgVPzjz8cJiuwEIAVbgeaeTijrZwOPZmyYPddFO2aFui906JzJjkt6eGcd i6MkHUSslGrlHdS1H20eCQdEuP5qibdOa+QbLsnhtkztt77qoiHMO32bsIjRd4RAWZ chXaNrTR0kNN0sx0FgtVJ87LPjeNheOOinw9FyD8= Date: Sat, 19 Nov 2022 19:39:17 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Javier Martinez Canillas , Thomas Zimmermann , Dmitry Torokhov , Benjamin Mugnier , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 016/606] drm/bridge/analogix/anx78xx: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-17-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-17-uwe@kleine-koenig.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:35:50PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 5997049fde5b..a3a38bbe2786 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -1214,8 +1214,7 @@ static const u16 anx78xx_chipid_list[] = { > 0x7818, > }; > > -static int anx78xx_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int anx78xx_i2c_probe(struct i2c_client *client) > { > struct anx78xx *anx78xx; > struct anx78xx_platform_data *pdata; > @@ -1390,7 +1389,7 @@ static struct i2c_driver anx78xx_driver = { > .name = "anx7814", > .of_match_table = of_match_ptr(anx78xx_match_table), > }, > - .probe = anx78xx_i2c_probe, > + .probe_new = anx78xx_i2c_probe, > .remove = anx78xx_i2c_remove, > .id_table = anx78xx_id, > }; > -- > 2.38.1 > -- Regards, Laurent Pinchart