Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2184805rwb; Sat, 19 Nov 2022 10:28:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf6djhT7yDlcSCyFY53Om/6Z32PdPcGEeXkAbyJwADMIdfREmEtkBrvGC2RSvj+A8w8LdvmJ X-Received: by 2002:a17:90a:b011:b0:20a:97e2:5373 with SMTP id x17-20020a17090ab01100b0020a97e25373mr13054407pjq.200.1668882510317; Sat, 19 Nov 2022 10:28:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668882510; cv=none; d=google.com; s=arc-20160816; b=yYtkBtjlwc4cXCHbd6f7vgtC/ievZesP2n0P1UN/jPL985gkgOFbOHc0oA39f+V/tp cQQUdn6zF19g6srIj3u0WteEvJV3m2H/I6ol9q6WgJMhb6fvuBC7RWkWw8zKU3kujvFn u+Lvqg+9cJ3UD8zNKJYJTZ3rNC8jXamwIyhTyJMiidVT0PVL3D+hXA4UsnCAigDtFA2F WXFzPQbH/UrceSGnVocr8oLhGEc+Sncuk/omsL6El4aae4XRVgEwjCOHlAmNbpiaAGZO c8im35cBQHRDjr6aj8FmPNL/Zb0Dmqkk2prDnDeZmrBG7sJqOxy0IbLyEO7ZlEgllgKK 3WOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Be9ps0CdbuctRF59V6gdl+/fIMvXk6olRUYQnj005Cc=; b=GwTSyM6WQtepH1yh4FmmTm1SiAd1Ub7qlKFxNsQReUwK8K3nFylV4C3JA8ld/9m5FH jvB0f2qwj81FIiDz0YrvG8IKzTtOBYV/h0CM+moWVFykQRteL4d+gBTC5fZgfkWscpKw HUEdIVcE2VGo9mP9DUtWDvpPBGGF/f7INiq/mlW63eastW/N55mXHZ/p6kyZJPIh1m9k BeLsipf0In4WKwlb438jhnfAGSxEbbqvPRWj5OTdHglwCLQD8KI5vce2I+3H1I2ieuoM AXaFes8HF2bJ31PU8Ub0WbdJDo7HOhxxLLAqOa1gjfPohHDKIxN5BKMMWgQVLm6mIfYL 5kTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=OruFA3N1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 6-20020a631546000000b0046fed3af6c9si6908889pgv.370.2022.11.19.10.28.19; Sat, 19 Nov 2022 10:28:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=OruFA3N1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234867AbiKSReQ (ORCPT + 90 others); Sat, 19 Nov 2022 12:34:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234843AbiKSRdl (ORCPT ); Sat, 19 Nov 2022 12:33:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B3517895; Sat, 19 Nov 2022 09:33:39 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4735E749; Sat, 19 Nov 2022 18:33:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879218; bh=qb+DtyPGnqHLki0PE911QgLlJ2I1/jXnP9YLT5h0d+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OruFA3N18YfSqufN1EupAaMCLQtDFW0qAnRBQknY02WwUmC0Hqnt9DGFDo30o8qee 6aHBDro/53DI+2tMH0mtLQu8DXcSKmCVG1w+0TWaY7CbAYqYBS01K1GY0uIMyyPbnO 0V7htj6hMF/f/jB4TYInP5o9z22MY4vZe73mRvv4= Date: Sat, 19 Nov 2022 19:33:22 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 033/606] drm/bridge: tc358768: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-34-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-34-uwe@kleine-koenig.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:07PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/tc358768.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 4c4b77ce8aba..839b8832b9b5 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -1018,8 +1018,7 @@ static int tc358768_get_regulators(struct tc358768_priv *priv) > return ret; > } > > -static int tc358768_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int tc358768_i2c_probe(struct i2c_client *client) > { > struct tc358768_priv *priv; > struct device *dev = &client->dev; > @@ -1085,7 +1084,7 @@ static struct i2c_driver tc358768_driver = { > .of_match_table = tc358768_of_ids, > }, > .id_table = tc358768_i2c_ids, > - .probe = tc358768_i2c_probe, > + .probe_new = tc358768_i2c_probe, > .remove = tc358768_i2c_remove, > }; > module_i2c_driver(tc358768_driver); > -- > 2.38.1 > -- Regards, Laurent Pinchart