Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 19 Nov 2022 19:41:49 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <robert.foss@linaro.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Jeremy Kerr <jk@codeconstruct.com.au>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 014/606] drm/bridge: adv7511: Convert to i2c's
 .probe_new()
Message-ID: <Y3kVXfxsPJNkq++H@pendragon.ideasonboard.com>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-15-uwe@kleine-koenig.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221118224540.619276-15-uwe@kleine-koenig.org>
Precedence: bulk

On Fri, Nov 18, 2022 at 11:35:48PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index e7a6e456ed0d..ddceafa7b637 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1185,8 +1185,9 @@ static int adv7511_parse_dt(struct device_node *np,
>  	return 0;
>  }
>  
> -static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
> +static int adv7511_probe(struct i2c_client *i2c)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(i2c);
>  	struct adv7511_link_config link_config;
>  	struct adv7511 *adv7511;
>  	struct device *dev = &i2c->dev;
> @@ -1392,7 +1393,7 @@ static struct i2c_driver adv7511_driver = {
>  		.of_match_table = adv7511_of_ids,
>  	},
>  	.id_table = adv7511_i2c_ids,
> -	.probe = adv7511_probe,
> +	.probe_new = adv7511_probe,
>  	.remove = adv7511_remove,
>  };
>  
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart