Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 19 Nov 2022 19:42:22 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Antoniu Miclaus <antoniu.miclaus@analog.com>,
        Jose Cazarin <joseespiriki@gmail.com>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 092/606] iio: dac: ti-dac5571: Convert to i2c's
 .probe_new()
Message-ID: <Y3kVfm0zPb2E4VnG@pendragon.ideasonboard.com>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-93-uwe@kleine-koenig.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221118224540.619276-93-uwe@kleine-koenig.org>
Precedence: bulk

On Fri, Nov 18, 2022 at 11:37:06PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/iio/dac/ti-dac5571.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 3210e3098f9a..40191947fea3 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -306,9 +306,9 @@ static const struct iio_info dac5571_info = {
>  	.write_raw_get_fmt = dac5571_write_raw_get_fmt,
>  };
>  
> -static int dac5571_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int dac5571_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct device *dev = &client->dev;
>  	const struct dac5571_spec *spec;
>  	struct dac5571_data *data;
> @@ -426,7 +426,7 @@ static struct i2c_driver dac5571_driver = {
>  		   .name = "ti-dac5571",
>  		   .of_match_table = dac5571_of_id,
>  	},
> -	.probe	  = dac5571_probe,
> +	.probe_new = dac5571_probe,
>  	.remove   = dac5571_remove,
>  	.id_table = dac5571_id,
>  };
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart