Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2208119rwb; Sat, 19 Nov 2022 11:00:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf7cwhvUWqcNexGfLKJGbY2WyezLN4Y3+ChmYYrrgxKgJMIGI+VuTzLdr8scc8poCR2cl8na X-Received: by 2002:a17:90a:55c6:b0:213:f3b:c5e2 with SMTP id o6-20020a17090a55c600b002130f3bc5e2mr13532690pjm.226.1668884454653; Sat, 19 Nov 2022 11:00:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668884454; cv=none; d=google.com; s=arc-20160816; b=UoyikysVsCTxCGEXq5tO3GfkADERwuM2I41D/d8pYJaD9DRfoaMae8Y4aa0v6Lojbc ayWpLJRBac+HceL1y9bWFKHOhiW+hB94IMxIJafui02OraejeduB0g2uBe9gZD7klyuT 78NJdNhoBY20AfGHF7vwEb7sTMkcLhvsf2eB59l8ae1uYEkBCxss0qdgOQItkNtT9TFL 6LyZkcefGcO8i8PP+U+cRdD+BHSf0EL6OGDacpIy3OFSdXOt/S7ayZg09Gy3ooFBdxTM fwTKSi1sOVVLJrThkKiKwSWRSZczfged8OHBvCm/62JI3ONEwgD1sSjRiwu7tUwptQ+g rwCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=Hygy7F65S609NQFcqg6vDNh07pkYe/unIVrwGkaPmX4=; b=JgHhF/IZ4pGla7MGw9zF2yhVwgYxE/iqiiygSIDPESlQXBO5YjtZEfA8NkMdHqiTkY aMZUL765lJ0Jgg7y6IqezMtDzJ5FQUPbct7BEGfWzYzsqIbcziLTeEx2cUZAtLfdPaBm jcAifjfc8OggykMZ0ilbBslhvZXC61oGaYYaiMQki5Efu5bnbO8wPvJdVeup8PX8iZ7d jNqxZPGd32GbaGMtYiAEU11lnqda7dWBNRcpRmOyLV0rn8EtgnH2sZEg38kp8moWJDGy WuxT6LSvjeQRCfyooTZqO1mn8JhNzKdNHAzey7eBJKf8jZBuW5mBSw/wCGfaL6rbbcHr vayA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="E/JTQKcE"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y191-20020a638ac8000000b004772bd28105si5062413pgd.831.2022.11.19.11.00.43; Sat, 19 Nov 2022 11:00:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="E/JTQKcE"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234669AbiKSSZz (ORCPT + 91 others); Sat, 19 Nov 2022 13:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbiKSSZx (ORCPT ); Sat, 19 Nov 2022 13:25:53 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DAC2AE43; Sat, 19 Nov 2022 10:25:52 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF1491F383; Sat, 19 Nov 2022 18:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668882350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hygy7F65S609NQFcqg6vDNh07pkYe/unIVrwGkaPmX4=; b=E/JTQKcEyvySP/5ZvZlinvaVsNdHs1wUZOvqj9/DofqDN+1KaT3NkccHONqqtR40XMjr/y nPxUstvWsvIERHsTOBFtm/qY5IohnAZNXUNYXi4Gc54mgOcqYdB+GogwBjbuwTljYIHAGd /2E7/4NJgXO2rpLFM4YaWzB6KtSIja4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668882350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hygy7F65S609NQFcqg6vDNh07pkYe/unIVrwGkaPmX4=; b=yPTfHdWj1uogn8KFqbBRDkDMDZ3ZW3hDWUWFzDs5i8Vud5oMV/5b/yRHwTpAlwVkr+rIWZ BvnQqfXonn0ps6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E295A1377F; Sat, 19 Nov 2022 18:25:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u6E8N64feWMyXwAAMHmgww (envelope-from ); Sat, 19 Nov 2022 18:25:50 +0000 Date: Sat, 19 Nov 2022 19:25:50 +0100 From: Borislav Petkov To: Peter Gonda Cc: Tom Lendacky , Michael Roth , Haowen Bai , Yang Yingliang , Marc Orr , David Rientjes , Dionna Glaze , Ashish Kalra , stable@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH V5] virt: sev: Prevent IV reuse in SNP guest driver Message-ID: References: <20221116175558.2373112-1-pgonda@google.com> <3e50c258-8732-088c-d9d8-dfaae82213f0@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 07:19:17AM -0700, Peter Gonda wrote: > Thanks Tom. I'll update with all the feedback after Boris chimes in. No need - it looks pretty good to me. I'll queue it next week with Tom's comments incorporated. Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman (HRB 36809, AG Nürnberg)