Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 19 Nov 2022 22:25:50 +0100 (CET)
From:   Richard Weinberger <richard@nod.at>
To:     "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>, yusongping@huawei.com
Message-ID: <433070166.256175.1668893150374.JavaMail.zimbra@nod.at>
In-Reply-To: <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com>
References: <20221115083335.21211-1-hucool.lihua@huawei.com> <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com>
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: ubifs: Fix build errors as symbol undefined
Thread-Index: xvKUd6iNeIA9uYaj0+JoIBNTDdG+WA==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
>> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
>> index 45d3d207fb99..93bda1057fdc 100644
>> --- a/fs/ubifs/Kconfig
>> +++ b/fs/ubifs/Kconfig
>> @@ -13,6 +13,7 @@ config UBIFS_FS
>>   	select CRYPTO_HASH_INFO
>>   	select UBIFS_FS_XATTR if FS_ENCRYPTION
>>   	select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
>> +	select UBIFS_FS_AUTHENTICATION

I fear this is not a proper fix.
This changes does not longer allow building UBIFS without the authentication feature.
With what configuration do you see this error?

I just tried with:
CONFIG_UBIFS_FS=m
CONFIG_UBIFS_FS_ADVANCED_COMPR=y
CONFIG_UBIFS_FS_LZO=y
CONFIG_UBIFS_FS_ZLIB=y
CONFIG_UBIFS_FS_ZSTD=y
CONFIG_UBIFS_ATIME_SUPPORT=y
CONFIG_UBIFS_FS_XATTR=y
CONFIG_UBIFS_FS_SECURITY=y
# CONFIG_UBIFS_FS_AUTHENTICATION is not set

But don't get the error and, as expected, fs/ubifs/ubifs.o has no
reference to ubifs_bad_hash.

Thanks,
//richard