Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: [PATCH v2 net-next 0/3] cleanup ocelot_stats exposure
Date:   Sat, 19 Nov 2022 15:14:03 -0800
Message-Id: <20221119231406.3167852-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GKF0hpL+nd+BHPinVveiUiS+Gyy8aO1mFY0KRSQxIfKO9/gzaszqUD3kxE5/?=
 =?us-ascii?Q?Nj1yV9UxOnOLy7TEnGwCrRrSY9+c92ssrRrkKfdHDYrJEhF8nPb1IikvI7w8?=
 =?us-ascii?Q?yl4jUBe9Ykd+MG6hZrT9y+9//7Oo0WExOm8AEXATlADkAstoYDt7ojvKD5BF?=
 =?us-ascii?Q?zVk9jwdu/za2Xf+P9ZmiQS3EmmPnJJ+r9gAHD0fcS8VY8pVXCQ/Yvu9+KmWN?=
 =?us-ascii?Q?LSebTVLXMFqli3tMLrw1Wsv/to8TjITTnj5sURcqSRtFhrznEbE//9lwbICf?=
 =?us-ascii?Q?DgAkKEErLL8aDOhsKyV42m51t6Yz3OOeR5EQLaXrUpumpKSowjAJKNU8CYOD?=
 =?us-ascii?Q?ck7GGfa6XvySQY+z4hlWDfKRRJ99HJ1f2yLkrk8N7tYmlKLTVOxLbRP4mHNk?=
 =?us-ascii?Q?aPA/DUmuvwDC3VuIfF2PgVM6cemWm91X/nzm7oYdUd3pYj8/EdsrgmealZ2o?=
 =?us-ascii?Q?V/I0yan6QQLG7vi1BT5DhVgfn6Nig5vhXLGIq1nM2yHwsCklN57PfQZVy2fk?=
 =?us-ascii?Q?bsfbvswCsSdJMup9zeSjVaF9sWII7qN5SgCYNERn/4o2ICpjb08TsT8JDc0E?=
 =?us-ascii?Q?YezvQqApEeguDZgUm1uWpzAxMOboXpeBF/DdeauosDbiTzyiyk3r1Dmbu8+S?=
 =?us-ascii?Q?HS81O7ItbdX+WzpjelRZbNFCtG+bzUGNwzfOwik+mgGU0JVdwzB4mx7UTUVe?=
 =?us-ascii?Q?oe+SpWm8jU2EClQYtOilKvWqvieCDRKxpONm968RVR/0iR0ntBZms+pMU3M9?=
 =?us-ascii?Q?3Ejsrb3A6uXdjCBzr81BBBjdETF2jDnZGVZZo7dwaHYZrrP6D4cR7lfr9G5r?=
 =?us-ascii?Q?2NeqvKsu+PNFUsrUWRmBQ76ciawgi1m1juO0c+SZw46IzJSZGjraJ/MJJrGS?=
 =?us-ascii?Q?ZFXYrrm9IgNHk2VsQOJE+HUdleI1My4jzblCU1QvuwSP5oHT/lxIlpODgR4k?=
 =?us-ascii?Q?fo9JX8OaVEV4HEd9wfhe2DNHogwX9/4e5g+rV8hxda6mTt7yZWqkfNTm3pwg?=
 =?us-ascii?Q?2G+yfw1djgAtI94R9w8QarairBiwIjZfZNRasgTCD0gv+fRhLKeJR8ic2pOd?=
 =?us-ascii?Q?B7mCie55I1YzL4BdAptU5kQYHc+KJtMxURUHDrww0ixcR3aA7B8pRGAAqz8i?=
 =?us-ascii?Q?nVQ39ZRNQwd1+SjVcBTLMJc7igvt2ZOPxc5luqJOfY7t67a4kEz+ZOTIP5l0?=
 =?us-ascii?Q?EZi7Re9tFoB7on0Blit1+pcLIcMGE74yDDXtOqickOwPfqbKpVj+hlkHhkub?=
 =?us-ascii?Q?AXUebeuFvv0X0G63V7B9WFVKRqcUJk+Zzkkwp9mPJsMN3aUupj6yZUGb1TlM?=
 =?us-ascii?Q?E2SLMFxk02jzdLiUeMV72tn1G5Rt8lALXio53a0NN5/79V//UoHlHdgtPTs3?=
 =?us-ascii?Q?qN6q8b8JHgbLL7CDf8JnlPvPIg0raBBoQzn/QeJh5H0icYRgYdyWoBL7o52H?=
 =?us-ascii?Q?2nEg/VR/w/+Qgbz4jOVYAMLMMzv+mc90hYmvmI8bqCXXHzum0JrnTbNzCChu?=
 =?us-ascii?Q?b4EB0hsyYZElb+0rr9D0vMwN4uD/rdnyCJ5zBpSunMEXYA7jlGHulw9+KrYf?=
 =?us-ascii?Q?ly7h9vPUbG0JsPcXCP77q2LG/w8k9IJeLW9gH4CvwOCBCzyqeAz/nOywXvO6?=
 =?us-ascii?Q?7g=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05cdc468-90d0-41ea-e40e-08daca83cb3f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 23:14:22.7553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xRkfxaghndxKzP5r3UUXEtMYILd0xwFBEJ8Ylr8luFmv4a5xIGM1uSKLHoH21RzEfIUiu5Suuv6lirNSHl5WAV6C2d3C9HkBTvRF4U8KkvA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4293
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The ocelot_stats structures became redundant across all users. Replace
this redundancy with a static const struct. After doing this, several
definitions inside include/soc/mscc/ocelot.h no longer needed to be
shared. Patch 2 removes them.

Checkpatch throws an error for a complicated macro not in parentheses. I
understand the reason for OCELOT_COMMON_STATS was to allow expansion, but
interestingly this patch set is essentially reverting the ability for
expansion. I'm keeping the macro in this set, but am open to remove it,
since it doesn't _actually_ provide any immediate benefits anymore.


v1->v2
    * Fix unused variable warning from v1 (patch 1)
    * Pick up forgotten stats patch (patch 3)

Colin Foster (3):
  net: mscc: ocelot: remove redundant stats_layout pointers
  net: mscc: ocelot: remove unnecessary exposure of stats structures
  net: mscc: ocelot: issue a warning if stats are incorrectly ordered

 drivers/net/dsa/ocelot/felix.c             |   1 -
 drivers/net/dsa/ocelot/felix.h             |   1 -
 drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
 drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
 drivers/net/ethernet/mscc/ocelot_stats.c   | 244 ++++++++++++++++++++-
 drivers/net/ethernet/mscc/ocelot_vsc7514.c |   5 -
 include/soc/mscc/ocelot.h                  | 216 ------------------
 7 files changed, 235 insertions(+), 242 deletions(-)

-- 
2.25.1