Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <819bdb10-2569-b7b1-b75b-168b77d1959f@oracle.com>
Date:   Sun, 20 Nov 2022 22:08:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] cgroup: Fix typo in comment
Content-Language: en-US
To:     "haifeng.xu" <haifeng.xu@shopee.com>, tj@kernel.org
Cc:     lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221120155134.57193-1-haifeng.xu@shopee.com>
From:   Kamalesh Babulal <kamalesh.babulal@oracle.com>
In-Reply-To: <20221120155134.57193-1-haifeng.xu@shopee.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGJCY0NxZ3loWjBFdkRhN0pCM2U4YUJaOXM1Z0d1VUtVaElOTnFJVTBnTGVB?=
 =?utf-8?B?N0RQYWtyTUFxazZuNU1zMTgxVGo4S3JsQ0MrRW5TYTlVbXNTelU1eFMyNWZJ?=
 =?utf-8?B?c2lWMXJ3WTRXZS9QRGhBRTRMR3N6bnQybkFQRTdLQWhCM1JRTkh6UlRPcW9v?=
 =?utf-8?B?Q292d2VxR2g3UFlqMTdteEExOUFuNFUyMksyaFdUYXI1Ym9BaG5yd29aakli?=
 =?utf-8?B?LzlkSFRvTzgyYUJIbzRjNnl4aGV2V2V6TTQ5L09SWFJiZWxVcXZQM1hTcUxk?=
 =?utf-8?B?NWhQcStabCtGRURxcEU3NUIvS2gvMVBadjE5RGpSS2VrSFVkY3RTNWFwUU9N?=
 =?utf-8?B?MXM0K29NTFI2MzhsRGFPZ3NLckZDMkZTNHNGcWYxMjBSaW9oZjQ0K0R0MG9q?=
 =?utf-8?B?S0d4RW4rL1dMc29BeE9LRzQzaTBWSkRqWFJpclV4U29jNXNyTllXK00zaERz?=
 =?utf-8?B?a3drbW9DdlpNWEtUQkVnd0lTcFJWVC9tT0dZVWVUbmp5SzE5c0d1WlJzTjlr?=
 =?utf-8?B?cVRwWGM0KzM5S014SCtnWlplcmtIYkQxaGhPS04rYWpZTGYyeHVMUmVEREVU?=
 =?utf-8?B?Nk5hL1ZXc0MxNVB0MWNXdTFvN0dZcFpaOWVnYUVUaVZZTkZXNjljMEtlTE1K?=
 =?utf-8?B?SXQyb0crTlVkd0hZWlpPT3R6SFIxakRpbXRjdmNyMkpEeUJjUzM2NXh1dzhU?=
 =?utf-8?B?SDdja2tMNzNORTJpNVZkUjN1RFpHSzhjM1lCeURkY1lJWXg3dDFNQnNDZkJS?=
 =?utf-8?B?MzErUmxaclAzRzBlTURuUHl2QzkvYnExT0FOZEovY2gxVmxXNnpnSUpFRm1l?=
 =?utf-8?B?SFlOUGJLTXFpSDZDeWtsUmxIdkxieWF3YU8rSjlQekxENmQ4WUhrY01JOVhS?=
 =?utf-8?B?ZzhNSEw0VW1RYTJQUENaV3ZKdXkyTnZjTU9xVXUrWm41L3ZVM3ZZODNadHl1?=
 =?utf-8?B?WDRzRk0zdEN6SDdRNkdxMVZlOXR4ckc5Nk9GRkM4bk5GYjRYWHZyTlJLSTJL?=
 =?utf-8?B?QzRubGRYcW1sSHEyWmlOOVZVRUJYNFBUQXNkQUJrbUVlanZQa2FHT3pLZGkx?=
 =?utf-8?B?MG4vZVlXR0hlak9jem8yTmRjanFIR1BFWlNQWFlybk55MjcvTnlrbytWY2tZ?=
 =?utf-8?B?ZlhFMDMra0NvbzVueksrZjdydWV0YXgwV2JSY2k5eTJURDdnUElQRjNtaUNp?=
 =?utf-8?B?djlCaFp4eUNnS1Z2a0tZc0FETUxvamNjRjRTT2UrTTJENzFlU1I0b290NmlT?=
 =?utf-8?B?eVhscFIrUFlSWm9DcDNhekJyTWd1Y1Nub0dXVGhsYy9Fcm9NNGgzTUwvTGJV?=
 =?utf-8?B?SDZmeVFwUHl5RFlDcWtHTklpU2tmYnhpa1ZQRnE3L3VyV2haY1NLYkI3bHAv?=
 =?utf-8?B?U0QwOFUzQlRiZHlPcXVQNHlMTllhd1U5N3pCWnJRRlNUNnFZc0k0K0o4YkY2?=
 =?utf-8?B?REE0T0NVNEgvY2UyUFh6M3RadnN2RlhLK3c3SkMzUDNqdllUZ3BCQkJyQXlu?=
 =?utf-8?B?bnBFWnhYNlMzUGZ3SGJQVyt1RGpkSnRGUkJaTDdlb3l5c0pGc2pUSUc2OURJ?=
 =?utf-8?B?SU0wTUJzam9LZlY4UFhzYzZvQW01Sm8rMDkwU3doQWpndEJyOWhTTS9EUlhy?=
 =?utf-8?B?d292a2JHVHN6K1YwS2ZXWG1wUk5qcGJjVitIbEVDMUlpa1U0WDhJUC9ZUFNH?=
 =?utf-8?B?em5PQ2pIUG1HMmtyN1NOdnY0bjBRdjI0NFZBUVpQV1NVR0FrRStCRXlCQWtY?=
 =?utf-8?B?SzA4S0wvTnNEZzB5eS8wRUx6TFlwRDZtSnhnM25lRU9vcjhFa0Q0MGFvOEdQ?=
 =?utf-8?B?eWY2emZmWUFaRFZNZGZpSnl1cDFudGFpYWk4TEJmNGkrV25BdmFpRTlyeGZO?=
 =?utf-8?B?ZTgwTEtWY0hJallHek1DdklqMkFna2gvUmZaaU9xRVdZVEdnbXZFVk1SMDVT?=
 =?utf-8?B?cEppbko3MHFLS05pbThiSytIUkFCUU5RbDBhV0FvbUlVZ28vU2VkTHRIUm80?=
 =?utf-8?B?M3lnTGwzL0VwTGRpUk5BVVJ0ZDJ3c1NkUEJHYjFBVGZ3Zkd4NHVlREQ0V3py?=
 =?utf-8?B?enl2YW04Si9Nb25NcUF0ZGpTMHRqcmE1RlFYNzJwcGlsMVlzUzZHYUdwSlNP?=
 =?utf-8?B?QlIwanBJc2N4U0t5NFp1N0xNQkVaSktSMlkxSGVGOXpJNWsrMmpaWFhiZnYz?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UWdLOWJUbm94cVM2YWN0NmJNK1V1SEFiWWQwY1JIazdwY3BCNVZhbnR5U0ZD?=
 =?utf-8?B?OVRjWlBHZmo4b3pJckpaeTd2WUtFK3c3NExGbzVxYklLR2lGdGQzWERXUWlH?=
 =?utf-8?B?NkxBYXA2UzIzTG5WamZFN2QwcHd5TDB4bldNYlk1NUZ0MVJ1UGxwWDdCWHg4?=
 =?utf-8?B?NDJwbWhHS1VCd0NwZm12dkhERm0zVnVaRU1FR2I2ZytkWkdhejdQNW1wN3Ny?=
 =?utf-8?B?MGtpUDhqS3lNYWhKWWp3SHFNaHhHNWV2ekNZTTVTdlZVWTdPMWc5THVkYitp?=
 =?utf-8?B?a0R1cHQvZWZ0VXhQOU1rMHdpRG02T3hrdC9MblNXQkZWNk5ic2gzVW5aWFpU?=
 =?utf-8?B?M3F6TEp4ZC9BdXlpZVFRY3BPTzdmV0hzYUw5SnJXWVMvckQ0dzN0bVY3N0U0?=
 =?utf-8?B?d0VRMHhCWndoRXZseGtJc1NxaVR1MDRvc3g5c2s1ZDNFa3g0VFFVZFVDc0ZP?=
 =?utf-8?B?dUtwemp3V0U3Q21NSVYwSTltN3VMMC9VMGxKU2ZnN2NQeGhmaUZ4a3psTnZz?=
 =?utf-8?B?T0N4M0hiOXBNMTFibW9HSG9ndHgyS0NTRWhjUE9Eb2Uzeks2L0ltOTJ2cmJR?=
 =?utf-8?B?Y29jRldFS0tEeGU4SG9xMVJtTEdwN1VOd2JYSUM4YnJNTllWbDFMWGgwRjNj?=
 =?utf-8?B?cVlTWklTb3FqakZSOHUwN0NYc2JFNm4zb1oxUHlUT08wMnU4elJpLzhrbFRr?=
 =?utf-8?B?M2VRc0NEUkZ3L0xUUTZsSEttcEpCQUtENHZYVTFkY3Y2YkUyNWt1Z3hacVhw?=
 =?utf-8?B?UitJVDdGMDErWVlSeDhXeGpIOHA3ZTIrcDVaTFJseFg1eFZIVG1lUHUvaHV4?=
 =?utf-8?B?dENrQnU1NVUrTXRmQStnQSsxZU9Wd242TmRVcEZPUVJGSldHYVhIRVJmeTNm?=
 =?utf-8?B?TzJZd3JpY2VveGt2aHpJWlhyQzB3MmNVNGVieDM2dytRREhBRWwwdHR1Mnp1?=
 =?utf-8?B?d01aSDhwTW1oUm0vemo2cUdVL2NoYjhaZGFUMFRCMGR5Y2h4VGR0NGxMbUEy?=
 =?utf-8?B?OTBjOFU0b1l0bkpodGRYb1hETU96blBPT2hvbmF5WWdVbGxYWEFEdG1RczZI?=
 =?utf-8?B?SEcwRm9SZFVCQ251N0FEa0xOSkhvVHlMTnE1Tyt6K2xFYmJxOUNYcE4zeTBH?=
 =?utf-8?B?K044aGg3RWw4aFc4YmZyc1JwMjBVUXRpT200S0JiRFhPenB6QkxNQ2xjbm1a?=
 =?utf-8?B?dW8yUFZmZGtkcmxrZzZ2dG1ZSERkaUlEd012dEk3R3M5bDdtZEwxdHFTU0ND?=
 =?utf-8?Q?NmvW77Rc6MThhz+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1b91b50-235e-4297-480f-08dacb15bebe
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3001.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2022 16:39:08.4520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZkUxXy8BPNIV25P/GgJoRt4fLnHSFtr3VkZptZWCT5YfnX6GrgXXZl7T+KxkJNj5P877+lSJEYmKuB1C70jqAZi6adWtAC6J0AHFWDkvwXI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6333
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-20_11,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0
 phishscore=0 mlxlogscore=911 bulkscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211200142
X-Proofpoint-ORIG-GUID: vrAa9MIcrRDxcNbtFb_4C4SbYLnUW6bD
X-Proofpoint-GUID: vrAa9MIcrRDxcNbtFb_4C4SbYLnUW6bD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/20/22 21:21, haifeng.xu wrote:
> Replace iff with if.
> 
> Signed-off-by: haifeng.xu <haifeng.xu@shopee.com>
> ---
>  kernel/cgroup/cgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index f2743a476190..93c5e50b1392 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
>   * One of the css_sets associated with @cgrp is either getting its first
>   * task or losing the last.  Update @cgrp->nr_populated_* accordingly.  The
>   * count is propagated towards root so that a given cgroup's
> - * nr_populated_children is zero iff none of its descendants contain any
> + * nr_populated_children is zero if none of its descendants contain any
>   * tasks.
>   *
>   * @cgrp's interface file "cgroup.populated" is zero if both

iff abbreviates to if and only if and it's a valid usage.

-- 
Thanks,
Kamalesh