Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3197238rwb; Sun, 20 Nov 2022 09:03:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf6PGvTMA7tXv3RPVVpOL/1gAYGI2vAB2RwJ7YF18xgkm/PoJQqR5PUIZI1y0drsmmOFzgKJ X-Received: by 2002:a05:6a02:108:b0:46b:3acb:77ab with SMTP id bg8-20020a056a02010800b0046b3acb77abmr14463557pgb.359.1668963807582; Sun, 20 Nov 2022 09:03:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668963807; cv=none; d=google.com; s=arc-20160816; b=ROF5tW432FrNtKg9P58P5WpdoEKlXbbjByJ0iqdv1c6d/BeAhsD59qCIwsPH4CW3mY eZvkSWHVrP/a8Sv3fBUcdGEgY2D34mJ+DqorQbvLI4e5/kPIwh5+vSIZ9MtCZG4WdQs7 tD36wqojiZEp+QppWBS9mq//iE+2WgqI3Yu6Re3RXhg4sTwd3bbpl9ZC+vAjOk8juHvw RTlsQOwJUWl2JlB9zC6N1XO+e5QGxqvGZi139oA4cDrbz0+8GT3fSj9xC1qgU3IXpvHv tigDlKy8y+Q5KczApibgB/Uqk7mozuLLrpr1jgcpk/1FsrsTz+9dF9F/hgYYQcURC/Hq q5sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature:dkim-signature; bh=T92+v4p0yoPMR+XXc97vmTr3nevRE1nyZjgXzKzwKyM=; b=JqNJljHUCE4L2ZEvvqYUth69tq24FhSD8WAouKv9erKl3MtGroAPOhZ/MUJCTTNuV8 cOB8IUbfhXfw6NqiJOYznmSfnatEfatbbvXVeXxFklVOef3drRIQPywY/NPIHSId5aY/ JwbgBBnzOf0VkNAqSj2uQ6P8Il7DxgPGSlKSU0dgoixGZavdAQ2C9bdk1XVKkHIwQ47z V+gWDlhf04ctE4+9x7P+BdeNUqTv7rT7SKcx7RLq2KAghRVktW1TE6hzRu6eU8wQ4LYE /ZLak1MjXhAay9ubyvOdKalMLRnE+TQDavNYaH2RO82pKel85aLD2/xG9Ug9fWv6gnwR o0ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=pRHgB9QT; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=pRHgB9QT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b190-20020a6367c7000000b0046066611352si9195938pgc.502.2022.11.20.09.02.46; Sun, 20 Nov 2022 09:03:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=pRHgB9QT; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=pRHgB9QT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiKTQZV (ORCPT + 90 others); Sun, 20 Nov 2022 11:25:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiKTQZS (ORCPT ); Sun, 20 Nov 2022 11:25:18 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72F1B2DDB; Sun, 20 Nov 2022 08:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1668961514; bh=n1RHYaSr7YVqpR8H4s00LHMTau2igcsd/5bJkmmJeNU=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=pRHgB9QTxpHTbMYjOUJS8PqOUVjx2KvI2Lxodd+h9qHf0pQCvDVJi7WkHXSAY19Qm MljcSA6rjBNuSm2tuErOP7ZWZsPcKfTh5o7JQojVBC+BAK9Njz1B1vWK3Y4wq5cgCi VVKcVitj2q63UqJCdmm4jJ8ALaWB2yXLXsIXOodY= Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id ECE3D128115A; Sun, 20 Nov 2022 11:25:14 -0500 (EST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ldle52qfiSPc; Sun, 20 Nov 2022 11:25:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1668961514; bh=n1RHYaSr7YVqpR8H4s00LHMTau2igcsd/5bJkmmJeNU=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=pRHgB9QTxpHTbMYjOUJS8PqOUVjx2KvI2Lxodd+h9qHf0pQCvDVJi7WkHXSAY19Qm MljcSA6rjBNuSm2tuErOP7ZWZsPcKfTh5o7JQojVBC+BAK9Njz1B1vWK3Y4wq5cgCi VVKcVitj2q63UqJCdmm4jJ8ALaWB2yXLXsIXOodY= Received: from lingrow.int.hansenpartnership.com (unknown [IPv6:2601:5c4:4302:c21::c14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 3ACCA1280FD2; Sun, 20 Nov 2022 11:25:14 -0500 (EST) Message-ID: <77e79fad98b945f4f3f72b584d10fe01e187b8a8.camel@HansenPartnership.com> Subject: Re: [PATCH] cgroup: Fix typo in comment From: James Bottomley To: "haifeng.xu" , tj@kernel.org Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 20 Nov 2022 11:25:11 -0500 In-Reply-To: <20221120155134.57193-1-haifeng.xu@shopee.com> References: <20221120155134.57193-1-haifeng.xu@shopee.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-11-20 at 15:51 +0000, haifeng.xu wrote: > Replace iff with if. You can't do this without a more detailed analysis. iff means if and only if (logical implies in both directions), which appears to be more correct in the code being patched than if, which is logical implies in only one direction only. James